These are chat archives for coala/coala-bears

30th
Oct 2017
Surya Widi
@blazeu
Oct 30 2017 03:31
@Makman2 I think it's ready to be merged coala/coala-bears#2086
John Vandenberg
@jayvdb
Oct 30 2017 07:14
@blazeu , gitmate classifies your patch as "XS" (extra small). was your patch tiny when first created and increased in size for latter versions of the pull request?
Surya Widi
@blazeu
Oct 30 2017 08:01
@jayvdb no, initially there's a separate commit for test modifications but i squashed it as per review comment
John Vandenberg
@jayvdb
Oct 30 2017 08:04
ho hum, let me go look at that
oh, I see it. Ya, multiple commits usually results in that review comment.
another reason to use multiple PRs ;-)
Surya Widi
@blazeu
Oct 30 2017 08:06
so ideally if i want to make multiple commits it should be in separate PR?
John Vandenberg
@jayvdb
Oct 30 2017 08:07
but seriously, in future, if you have a good reason for multiple commits, reply to the review rather than doing what they say.
in this case, a separate PR is useful, so we have a permanent record that the revised tests passed ESLint 2.
Surya Widi
@blazeu
Oct 30 2017 08:07
yeah, beginner's mistake :)
John Vandenberg
@jayvdb
Oct 30 2017 08:09
we're all equal, and we all make mistakes. so if you dont agree with something anyone says, regardless of who they are, discuss it with them. everyone will learn a bit more from that type of discussion
John Vandenberg
@jayvdb
Oct 30 2017 09:48
@RaiVaibhav , fwiw, you can safely disable circleci on your fork , and only use travis ci on your fork. it is actually recommended to do this
Vaibhav Rai
@RaiVaibhav
Oct 30 2017 11:09
But
Travis is already building fine
John Vandenberg
@jayvdb
Oct 30 2017 12:27
yes, that is why. You dont need to build on Circle , because you can run tests on Travis.
John Vandenberg
@jayvdb
Oct 30 2017 12:38
@RaiVaibhav , i.e. dont get fixated on this problem. It is an extremely hard problem, and you wont finish the newcomer process if you try to solve it.
Infer is one of the hardest dependencies we have
iirc, it is excluded from our docker image, because it is a too darn hard
John Vandenberg
@jayvdb
Oct 30 2017 12:44
@blazeu re https://github.com/coala/coala-bears/pull/2098/commits , the new rule is from ESLint ? And that new ESLint rule is enabled by default in Happiness & JSStandard?
Surya Widi
@blazeu
Oct 30 2017 12:46
yes
Ah, the commit message looks confusing doesn't it?
John Vandenberg
@jayvdb
Oct 30 2017 12:47
it is a little confusing, but your clarification means it is accurate. dont modify it
it isnt worth restarting the build
Vaibhav Rai
@RaiVaibhav
Oct 30 2017 13:40
Hope you understnd but I think my test is passing all the case either on CI or check by gitmate, but why CI is not initiating from other branch how can I tell, I already gave so much time time to that issue and find the error and solve it, I already find two way to solve that opened issue but :disappointed:
From 3-4 days I am trying soo hard to solve low issue asap to focus on GCI
John Vandenberg
@jayvdb
Oct 30 2017 14:09
@RaiVaibhav , just disable circle on your fork please
John Vandenberg
@jayvdb
Oct 30 2017 14:15
(and then force push again)
Vaibhav Rai
@RaiVaibhav
Oct 30 2017 14:44
It initiated really really thanks
I am closing all others PR only will open with the branch name somebranch
John Vandenberg
@jayvdb
Oct 30 2017 14:46
ya, only need one open
Vaibhav Rai
@RaiVaibhav
Oct 30 2017 14:46
:+1:
John Vandenberg
@jayvdb
Oct 30 2017 15:06
we have a rather persistent problem on AppVeyor with BearTest.test_download_cached_file_status_code_error
it is timing out while trying to fetch http://httpbin.org/status/418
Vaibhav Rai
@RaiVaibhav
Oct 30 2017 15:08
I will try to take a look after some time ,as i did't get anything by seeing the link :sweat_smile:
John Vandenberg
@jayvdb
Oct 30 2017 15:09
I am not asking you to investigate it
Vaibhav Rai
@RaiVaibhav
Oct 30 2017 15:10
:+1: and also i did't push before change i check whether circle ci initiated
John Vandenberg
@jayvdb
Oct 30 2017 15:32
that appveyor problem is occurring on win32 and 64, often both, but not always. so: intermittent :/
John Vandenberg
@jayvdb
Oct 30 2017 15:37
oh, whoops, ^ problem is in coala repo, not bears repo