These are chat archives for coala/coala-bears

27th
Nov 2017
Mischa Krüger
@Makman2
Nov 27 2017 01:59

i think this issue sud be migrated to coala-bears

This issue is not related to a specific bear, but to the base bear class which is maintained by coala/coala

newbazz
@newbazz
Nov 27 2017 02:14
@Makman2 so how to write a test for SEE_MORE is set
I am not able to figure it out
Mischa Krüger
@Makman2
Nov 27 2017 02:15
he probably meant you should write a bear that sets SEE_MORE inside. Nothing complicated.
however, please read the link I posted to the comment
maybe the issue is invalid, this has to be settled before you continue to work
newbazz
@newbazz
Nov 27 2017 02:16
sorry but i actually was not able to get ur comment ;P
newbazz
@newbazz
Nov 27 2017 02:23
what is doctested?
i read the docstring of class Bear.
Mischa Krüger
@Makman2
Nov 27 2017 02:44
SEE_MORE is doctested
@newbazz
inside the docstring of class Bear
newbazz
@newbazz
Nov 27 2017 02:45
Yeah i saw that
so now what about that issue?
Mischa Krüger
@Makman2
Nov 27 2017 02:45
the issue is about testing SEE_MORE
and it's already doctested
maybe @jayvdb has overseen this, or he meant something different
newbazz
@newbazz
Nov 27 2017 02:47
ohk, btw just for knowledge, if i want to test the if SEE_MORE is set correctly how can i do so?
dont i need to import the class from coala-bears
Mischa Krüger
@Makman2
Nov 27 2017 02:48
no
you write your own bear
just for the sake of testing this
the bear would be nearly empty
but it would just fiddle with SEE_MORE
newbazz
@newbazz
Nov 27 2017 02:48
okk as it does with the attribute language
Mischa Krüger
@Makman2
Nov 27 2017 02:49
what "attribute language"?
ah
yeah right
(please don't use code blocks for something that's not code...)
newbazz
@newbazz
Nov 27 2017 02:50
ohk ;P
i can see ho an empty bear is made in the language test right?
Mischa Krüger
@Makman2
Nov 27 2017 02:50
:+1:
newbazz
@newbazz
Nov 27 2017 02:50
coz i am unaware of writing an empty bear
oh :+1: thanks
Mischa Krüger
@Makman2
Nov 27 2017 02:51
you subclass it and write nothing into it ;)
newbazz
@newbazz
Nov 27 2017 02:51
ohk btw now what abt the issue
Mischa Krüger
@Makman2
Nov 27 2017 02:51
what's with it?
newbazz
@newbazz
Nov 27 2017 02:52
means sud i close it?
Mischa Krüger
@Makman2
Nov 27 2017 02:52
noo, you should wait man :sweat_smile:
newbazz
@newbazz
Nov 27 2017 02:52
coz coala/coala#4605 is also to be done ;P
John Vandenberg
@jayvdb
Nov 27 2017 02:52
@Makman2 , if you dont think SEE_MORE should have a dedicated unit test, you can close it
I thought it was useful to have examples of how to create unit tests for Bear attributes
Mischa Krüger
@Makman2
Nov 27 2017 02:53
I'm looking at the doctest again^^
yeah suffices imo, the unittest would do the same as the doctest
newbazz
@newbazz
Nov 27 2017 02:54
i thought @jayvdb was on holiday so was not pinging him :sweet_smile:
:sweat_smile:
Mischa Krüger
@Makman2
Nov 27 2017 02:55
generally please try to avoid pinging maintainers /issue-filers just because you don't know how to produce necessary code to solve an issue
try to get it on your own is best
if that doesn't work ask the community
newbazz
@newbazz
Nov 27 2017 02:56
@Makman2 okk got you
Mischa Krüger
@Makman2
Nov 27 2017 02:57
learning by doing :+1: and that doesn't work if others do the work for you
;)
so closing issue :+1:
newbazz
@newbazz
Nov 27 2017 02:58
:+1: so i sud strt working on coala/coala#4605 right?
Mischa Krüger
@Makman2
Nov 27 2017 02:58
sure if you like :+1:
Monal Shadi
@Monal5031
Nov 27 2017 17:20
@RaiVaibhav Please update your review on coala/coala-bears#2104 its been a while now ;)
Vaibhav Rai
@RaiVaibhav
Nov 27 2017 17:37
@Monal5031 really sorry I checked my mail just now, was totally busy with exams finally over , I think I missed many things,
on it :+1:
Monal Shadi
@Monal5031
Nov 27 2017 17:43
np :smile: I also completed my final exams 2 days ago
Vaibhav Rai
@RaiVaibhav
Nov 27 2017 18:07
Added a comment @Monal5031 please check
Mamat Rahmat
@mamat-rahmat
Nov 27 2017 22:06
where does coala generate https://coala.io/#/languages?
i see that some bears are not showing (are they not stable enough)?
also some bear already have SEE_MORE attribute but the some of them not showing in language directory