These are chat archives for coala/coala-bears

8th
Dec 2017
Amr Mohamed
@AMR-KELEG
Dec 08 2017 14:32

I get these error messages when i run pytest for the coala-bears repo
___ ERROR collecting tests/general/CPDBearTest.py __
ImportError while importing test module '.../tests/general/CPDBearTest.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/general/CPDBearTest.py:8: in <module>
from bears.general.CPDBear import CPDBear
bears/general/CPDBear.py:8: in <module>
from coalib.settings.Setting import language
E ImportError: cannot import name 'language'

Should i attempt to fix these errors and create a new pull request so that the checks pass for this pull request
coala/coala-bears#1937 ?

Vaibhav Rai
@RaiVaibhav
Dec 08 2017 14:41
@AMR-KELEG The CI on your PR don't show the error you mentioned here and If I remembered correctly those error showed when your PR was not rebase, can you check that you have updated your cloned repo also as rebase was performed on you branch
CI showing only coverage problem
Amr Mohamed
@AMR-KELEG
Dec 08 2017 14:44
I am sure my local branch is rebased.
Should i repush the branch in order to re-run the checks?
Vaibhav Rai
@RaiVaibhav
Dec 08 2017 14:46
you can check but currently CI not showing those error https://travis-ci.org/coala/coala-bears/jobs/313095169
Only warning no error
772 passed, 1 skipped, 1 pytest-warnings in 362.58 seconds
Amr Mohamed
@AMR-KELEG
Dec 08 2017 14:49
Emmm, interesting :worried:
BHAVISHYA
@bhavishyagopesh
Dec 08 2017 15:36
corobo assign coala/coala-bears#1771
Shashank Kumar
@realslimshanky
Dec 08 2017 15:40
@bhavishyagopesh corbo is not working. Please request a maintainer to assign you manually.
Amr Mohamed
@AMR-KELEG
Dec 08 2017 15:41
@RaiVaibhav Thanks.
I had a branch condition that wasn't covered by the tests.
BHAVISHYA
@bhavishyagopesh
Dec 08 2017 16:19
@jayvdb please assign me coala/coala-bears#1771
John Vandenberg
@jayvdb
Dec 08 2017 16:26
:+1:
BHAVISHYA
@bhavishyagopesh
Dec 08 2017 17:39
I tried writing the OClintBear (https://github.com/coala/coala-bears/pull/2149/commits/0a212eac24ac45acf39063a8ec0b383b66b24723) and I'm testing it inside (ubuntu) docker there is no output(I have the executable in the path, the regex matches the output of oclint executable)
any ideas what could be wrong?
BHAVISHYA
@bhavishyagopesh
Dec 08 2017 18:14
any idea why isn't there any output...
John Vandenberg
@jayvdb
Dec 08 2017 18:44
I see a log with errors
restart browser ? ;-)
BHAVISHYA
@bhavishyagopesh
Dec 08 2017 19:38
sry, didn't got you?
BHAVISHYA
@bhavishyagopesh
Dec 08 2017 20:34
@jayvdb coala/coala-bears#2156 ,probably needs rebuild...
Vaibhav Rai
@RaiVaibhav
Dec 08 2017 20:35
@bhavishyagopesh your one PR for newcomer issue gets merged , second one is open and needed a more work, (if you want you can unassign and delete a branch as you have already a mereged PR)
Vaibhav Rai
@RaiVaibhav
Dec 08 2017 20:40
your coala/coala-bears#2149 PR also needed more work
BHAVISHYA
@bhavishyagopesh
Dec 08 2017 20:44
@RaiVaibhav coala/coala-bears#2149 is failing as executable isn't giving any output(working on that)
also I did unassign myself from issue #3901
  • coala/coala#3939
Vaibhav Rai
@RaiVaibhav
Dec 08 2017 20:52
:+1: taking about this coala/corobo#454 :wink: although its status/bloked