These are chat archives for coala/coala-bears

16th
Dec 2017
Amr Mohamed
@AMR-KELEG
Dec 16 2017 01:14
Could anyone review this please coala/coala-bears#1937
:cry:
Mischa Krüger
@Makman2
Dec 16 2017 10:23
Oh sorry @AMR-KELEG that your PR wasn't recog
Recognized*
That happens sometimes :/
Would you ping me on the PR so i get a notification? Then your PR is in my review list ;)
I'm not available the next 2-3 hours, so when I'm back I'll review it :)
newbazz
@newbazz
Dec 16 2017 10:25
@Makman2 what abt my PR ;)
Mischa Krüger
@Makman2
Dec 16 2017 10:29
@newbazz also in my review queue ;)
However, note guys that I'm more or leaa the only maintainer doing reviews on general purpose PRs (meaning not GCI)
So please be patient, it's still a hell lot of work and i try to keep it up somehow
But there's a limit on how much I'm able to handle^^
You can help me by peer reviewing so basic issues are already cleared :+1:
Sushil khanchi
@khanchi97
Dec 16 2017 11:42

You can help me by peer reviewing so basic issues are already cleared :+1:

@Makman2 How to do peer reviewing.I would like to help.

Vamshi Krishna
@Vamshi99
Dec 16 2017 11:47
@khanchi97 you can review others PR, you can checkout PR's awaiting review at coala.io/review . If you feel the PR is good, you can comment ack <commit> on the PR.
Palash Nigam
@palash25
Dec 16 2017 13:14
If I have to install an elixir linter in which file should I add that dependency to be installed when the CI checks run?
Sangam Kumar
@sangamcse
Dec 16 2017 13:30
How much more time it will take to merge my PR. coala/coala-bears#2148
Sushil khanchi
@khanchi97
Dec 16 2017 13:36
@Vamshi99 Oh, so it is same as usual review process.I thought peer reviewing is something different :smile:
Vamshi Krishna
@Vamshi99
Dec 16 2017 13:37
:+1:
Mischa Krüger
@Makman2
Dec 16 2017 16:46
@AMR-KELEG you got your review ;)
Palash Nigam
@palash25
Dec 16 2017 16:55
@Makman2 how do I install the a linter written in elixir(credo)? In which file do I have to add that as a dependency?
Mischa Krüger
@Makman2
Dec 16 2017 17:04
I don't know the linter, can't tell you where it comes from ;)
(I even don't know its name :3)
@palash25
Palash Nigam
@palash25
Dec 16 2017 17:05
so in general what you have to do for such dependencies:
there are two spots where you currently have to add those:
  1. inside bear.REQUIREMENTS
\2. install it somehow manually in the CI (if possible via already existing package lists)
It seems that Mix is the package manager for Elixit, so I hope we have a requirement-class for that
if not, we have to file an issue at dependency_management and write one (this could be maybe part of a GCI task). This probably takes a bit longer then, but you can more or less finish the PR without this (doesn't mean we are going to merge, but once the requirement class is done, you just have to change one line and the bear would be good to go)
@palash25
Palash Nigam
@palash25
Dec 16 2017 17:11
thanks @Makman2 . I will look into it. I think the bear is done I only have to figure out a way to install credo so that I can test the bear :smile:
Mischa Krüger
@Makman2
Dec 16 2017 17:11
nice :D
@newbazz interrupting review for a bit, but on it in an hour again :+1:
Monal Shadi
@Monal5031
Dec 16 2017 23:19
Is something broken? travis is failing :/
Mischa Krüger
@Makman2
Dec 16 2017 23:20
failing on your PR @Monal5031
?
Monal Shadi
@Monal5031
Dec 16 2017 23:20
yes
It was passing a 2-3 days ago
Mischa Krüger
@Makman2
Dec 16 2017 23:20
coala-bears, right?
we are currently investigating an issue:
coala/coala-bears#2175
Monal Shadi
@Monal5031
Dec 16 2017 23:21
ohh ok, was testing stuff on my fork there also it failed :sweat:
Mischa Krüger
@Makman2
Dec 16 2017 23:21
so if it's also you, maybe we have an upstream breakage
(thanks packagers for breaking API again :v:)
Monal Shadi
@Monal5031
Dec 16 2017 23:22
:laughing: lol
Mischa Krüger
@Makman2
Dec 16 2017 23:23
yeah but it really sucks, our CI is not trivial any more and such problems take a hell lot of investigation work
Mischa Krüger
@Makman2
Dec 16 2017 23:23
CC @jayvdb :point_up: December 17, 2017 12:20 AM
Monal Shadi
@Monal5031
Dec 16 2017 23:23
Here is the build btw
Mischa Krüger
@Makman2
Dec 16 2017 23:24
infer build fail :O
oh man hopefully rebuilding helps in this case...
man everything happens in one day...
Monal Shadi
@Monal5031
Dec 16 2017 23:24
Okay let me try
John Vandenberg
@jayvdb
Dec 16 2017 23:51
@Makman2 , there was a new release of pylint very recently