These are chat archives for coala/coala-bears

11th
Jan 2018
Kriti Rohilla
@kriti21
Jan 11 2018 13:36
Please review my PR coala/coala-bears#2233.
Sangam Kumar
@sangamcse
Jan 11 2018 13:39
@kriti21 change your commit
Your commit is too long
Kriti Rohilla
@kriti21
Jan 11 2018 13:40
Doing it. Thanks :)
Sangam Kumar
@sangamcse
Jan 11 2018 13:44
git commit --amend is life saviour :laughing:
Sangam Kumar
@sangamcse
Jan 11 2018 13:54
@kriti21 It can be shorted more
You can reduce your short log
Sangam Kumar
@sangamcse
Jan 11 2018 14:01
@kriti21 Script checks 'Circle' in the commit message and kills the build accordingly. This much shortlog is enough for that according to me
Sangam Kumar
@sangamcse
Jan 11 2018 14:06
:(
gitmate bot has problem with that too :/
Kriti Rohilla
@kriti21
Jan 11 2018 14:07
What's going wrong now?
Sangam Kumar
@sangamcse
Jan 11 2018 14:08
Leave that for now. Let a maintainer check that for once. For now, let other checks to pass.
Kriti Rohilla
@kriti21
Jan 11 2018 14:08
Okay
Sangam Kumar
@sangamcse
Jan 11 2018 21:53
@sils Can you please guide me for this PR coala/coala-bears#2235 ?

@Makman2 @sils Am I on the right path?

@sils Can you please guide me for this PR coala/coala-bears#2235 ?

Mischa Krüger
@Makman2
Jan 11 2018 22:46
@sangamcse yeah looks like the right direction. If possible can you write tests with LocalBearTestHelper and check_results? That would be even better :+1: