These are chat archives for coala/coala-bears

12th
Jan 2018
Kriti Rohilla
@kriti21
Jan 12 2018 03:49
@Makman2 Please review my PR coala/coala-bears#2233 I have worked with circle CI for the first time... Please guide me if I have done it right or not and how can I fix the failing tests.
saksham189
@saksham189
Jan 12 2018 07:53
all the tests are passing when i run pytest locally on my computer even when i add invalid files to valid_files in verify_local_bear... what could be the reason behind this? @Makman2 (I have tried this with multiple bear test files now)
Ishan Srivastava
@ishanSrt
Jan 12 2018 07:56
@anctartica do you need to create files for unittests?
Ishan Srivastava
@ishanSrt
Jan 12 2018 08:05
in most cases you can do without it but if you really have to, use https://docs.python.org/3/library/tempfile.html
Sangam Kumar
@sangamcse
Jan 12 2018 09:05
@newbazz actually I opened that PR to ask if I'm on right path or not. coala/coala-bears#2235
saksham189
@saksham189
Jan 12 2018 09:39
@ishanSrt i don't see unittest being used in the test file. It is just using verify_local_bear
Kriti Rohilla
@kriti21
Jan 12 2018 12:04
In coala/coala-bears#337 we are required to check revert commits and that they have a corresponding reason. If reason is not there, it should display a message to add one. Am I getting it right ? @sils
saksham189
@saksham189
Jan 12 2018 12:21
I think my tests are being skipped. it shows ssss next to them
saksham189
@saksham189
Jan 12 2018 12:33
okay so my tests are being skipped because standard is not installed in python 3.6 packages... i am not sure how i would do this... standard is a npm package
Mischa Krüger
@Makman2
Jan 12 2018 13:36
just install standard @anctartica ;)
npm install standard
saksham189
@saksham189
Jan 12 2018 13:37
okay thanks
saksham189
@saksham189
Jan 12 2018 13:43
still getting this message:
SKIP [2] ../coala-venv/lib/python3.6/site-packages/coalib/testing/LocalBearTestHelper.py:323: 'standard' is not installed.
after npm install standard and pytest -k JSStandardBearTest -rsx
Mischa Krüger
@Makman2
Jan 12 2018 13:51
you have maybe to do npm install standard -g which does a global install
Kriti Rohilla
@kriti21
Jan 12 2018 18:56
Please assign coala/coala-bears#337 to me.
newbazz
@newbazz
Jan 12 2018 19:04
@kriti21 ask it on the issue ;)
Kriti Rohilla
@kriti21
Jan 12 2018 19:10
done it already
newbazz
@newbazz
Jan 12 2018 19:11
then u will be assigned ;)
Kriti Rohilla
@kriti21
Jan 12 2018 19:12
okay :)
saksham189
@saksham189
Jan 12 2018 19:18
@newbazz regarding the JSStandardBear issue #2230, I understand that I do not have any tests right now but I am trying to say that it is not possible to add any settings to the bear so, we won't need tests for the coverage
newbazz
@newbazz
Jan 12 2018 19:19
@anctartica not getting you sry ;P
saksham189
@saksham189
Jan 12 2018 19:35
@newbazz i think there are no settings for the JSStandardBear
newbazz
@newbazz
Jan 12 2018 19:50
Ohh afk rn will have a look at it soon ;P
saksham189
@saksham189
Jan 12 2018 19:51
thanks!