These are chat archives for coala/coala-bears

21st
Jan 2018
Paavini Nanda
@paavininanda
Jan 21 2018 13:31
pylama is a linter for python and javascript both, in which folder should be its linter bear be placed ?
newbazz
@newbazz
Jan 21 2018 14:13
Any I suppose ; P
Mischa Krüger
@Makman2
Jan 21 2018 14:23
python and javascript? sounds weird @paavininanda
Paavini Nanda
@paavininanda
Jan 21 2018 14:30
@Makman2 haha here it is https://github.com/klen/pylama
Mischa Krüger
@Makman2
Jan 21 2018 14:31
Code audit tool for Python and JavaScript. Pylama wraps these tools:
pycodestyle (formerly pep8) © 2012-2013, Florent Xicluna;
pydocstyle (formerly pep257 by Vladimir Keleshev) © 2014, Amir Rachum;
PyFlakes © 2005-2013, Kevin Watters;
Mccabe © Ned Batchelder;
Pylint © 2013, Logilab (should be installed 'pylama_pylint' module);
Radon © Michele Lacchia
gjslint © The Closure Linter Authors (should be installed 'pylama_gjslint' module);
we should rather implement those
it seems pylama is trying to do what we do at a more specific and primitive level

--force, -F Force code checking (if linter doesnt allow)

why the heck has a linter a --force flag... :sweat_smile:

Paavini Nanda
@paavininanda
Jan 21 2018 14:33
ohh strange
https://github.com/klen/pylama This is the issue i was looking at
Mischa Krüger
@Makman2
Jan 21 2018 14:33
that's the repo link to pylama again :3
Paavini Nanda
@paavininanda
Jan 21 2018 14:33
coala/coala-bears#2150
my bad
and many of these have already been implemented
gjslint is already deprecated
Mischa Krüger
@Makman2
Jan 21 2018 14:36
I've closed the issue, we should rather focus on those little tools instead pylama wraps
(if there are missing ones we don't have)
oh if gjslint is deprecated we shouldn't use it at all :D
Paavini Nanda
@paavininanda
Jan 21 2018 14:37
yes
saksham189
@saksham189
Jan 21 2018 18:49
@Makman2 please take a look at this: coala/coala-bears#2242
the appveyor build is failing with error that gherkin-lint is not installed
cannot understand why this is happening
Paavini Nanda
@paavininanda
Jan 21 2018 19:13
corobo assign coala/coala-bears#1849
Can someone assign me to this coala/coala-bears#1849
Mischa Krüger
@Makman2
Jan 21 2018 19:20
@anctartica it's probably not installed
it's a package on npm, you probably have to add it to package.json
newbazz
@newbazz
Jan 21 2018 19:27
he has added @Makman2
saksham189
@saksham189
Jan 21 2018 19:31
@Makman2 yes, i have included it there
Mischa Krüger
@Makman2
Jan 21 2018 19:32
have you tried locally installing that package? @anctartica
saksham189
@saksham189
Jan 21 2018 19:33
yes i have installed it locally @Makman2
and all the tests are also working
Mischa Krüger
@Makman2
Jan 21 2018 19:33
hm
linux builds pass, just not windows
ah yes I know why
on Windows we don't install npm dependencies
tests on Windows are skipped (we had problems setting up npm properly)
and you forgot the generate_skip_decorator ;)
see other bear tests using LocalBearTestHelper
@anctartica
saksham189
@saksham189
Jan 21 2018 19:36
okay let me see
thanks
should we include this information in the docs for writing tests? @Makman2
Mischa Krüger
@Makman2
Jan 21 2018 19:53
I actually want to get rid of this decorator, and I want to have something like
class MyBearTest(BearTest(MyBear)):
then you wouldn't need a skip decorator
and we should try to achieve coverage also on windows^^
saksham189
@saksham189
Jan 21 2018 20:03
yes probably shouldn't be skipping any tests...