These are chat archives for coala/coala-bears

26th
Jan 2018
Kriti Rohilla
@kriti21
Jan 26 2018 05:58
Anyone please help me correct the assertion error in coala/coala-bears#2253 I am not able to find what's going wrong here. The test I have written is similar to other tests in Jinja2BearTest.py but still it fails due to wrong indexing.
Ishan Srivastava
@ishanSrt
Jan 26 2018 06:03
@kriti21 the bear is giving an additional result as output whereas what you are asserting against has one less result
debug it why its happening, whether the changes you made is making the bear give an additional output which shouldn’t be there or whether you are making the bear give one less output while testing
Kriti Rohilla
@kriti21
Jan 26 2018 08:35
Thanks @ishanSrt
Kriti Rohilla
@kriti21
Jan 26 2018 13:53
Regarding coala/coala-bears#2253 I followed what you suggested and checked the code I wrote both in the bear as well as in the test file. Despite trying a lot of different changes, the assertion error still remains. Can you please help me with this? @ishanSrt
Ishan Srivastava
@ishanSrt
Jan 26 2018 13:56
@kriti21 did you look at LocalBearTestHelper.py, method check_results method
Try to narrow down why the bear_output is not matching the results you are asserting against
since it wasn’t failing before, clearly its either due to the changes you made or you are asserting against the wrong things
ok its definitely due to some changes you made in the Jinja2Bear. Now check whether that result was expected or not. If yes, then your assert statement in written incorrectly, if not then you have made the wrong changes in Jinja2Bear
Kriti Rohilla
@kriti21
Jan 26 2018 14:01
okay. Thanks a lot.
Manan Kalra
@manankalra
Jan 26 2018 15:17
@Makman2
please review coala/coala-bears#2257