These are chat archives for coala/coala-bears

27th
Feb 2018
Mohit Juneja
@Mohit17067
Feb 27 2018 06:06
Yeah, I did that but the errors are not related to the work I have done. (I think so) @Makman2
Vaibhav Rai
@RaiVaibhav
Feb 27 2018 07:57
CIrcle CI failing but error is not becuse of changes it failing on some different Bear
Viresh Gupta
@virresh
Feb 27 2018 14:19
@Makman2 , Please assign me coala/coala-bears#2286
I think I will give it a shot once :sweat_smile:
Vaibhav Rai
@RaiVaibhav
Feb 27 2018 16:24

need help in creating a test for coverage , as currenlty in I added the function is_mycve so I also need to create a test for coverage problem but problem is,previous test depend totally on LocalBearTestHelper like check_validity, check_invalidity, but the function I created can't be check using LocalBearTestHelper so I have to use unittest.TestCase for that function only

Is there any way I can use Both in test file or some other way to test it.

@Makman2
Nitanshu
@nvzard
Feb 27 2018 16:47
@RaiVaibhav You can create another test class in the same file and test your function?
Mischa Krüger
@Makman2
Feb 27 2018 16:50
@Mohit17067 okay yeah that looks unrelated, so can be reviewed anyway
though why the heck are those bears failing again... Dare them if they released a new version together...
Why the heck they can't test there stuff properly...
Vaibhav Rai
@RaiVaibhav
Feb 27 2018 17:36
@nvzard problem is class name is same as test file name , two class with same name will result into type error
Nitanshu
@nvzard
Feb 27 2018 17:38
oh right!
Nitanshu
@nvzard
Feb 27 2018 17:52
@RaiVaibhav you can do something like this maybe,
https://github.com/coala/coala/blob/master/tests/bears/BearTest.py
Mischa Krüger
@Makman2
Feb 27 2018 18:01
@RaiVaibhav just name the classes inside differently
we have tests with multiple test classes, and that's totally fine.
The name doesn't have to be the same like the file name^^
Vaibhav Rai
@RaiVaibhav
Feb 27 2018 19:46
Thanks @nvzard for helping me, I forgot about the naming convention
and thanks @Makman2
Nitanshu
@nvzard
Feb 27 2018 19:56
:metal: