These are chat archives for coala/coala-bears

8th
Mar 2018
Kriti Rohilla
@kriti21
Mar 08 2018 06:55
Anyone please review coala/coala-bears#2316
Sangam Kumar
@sangamcse
Mar 08 2018 07:05
@kriti21, I think you also need to add test for the changes you made.
Kriti Rohilla
@kriti21
Mar 08 2018 07:14
I thought of the same but not sure how to do that. One filter has already been mentioned inside test_files for CMakeLintBear . So if that's fine, then tests pass locally.
@sangamcse
Sangam Kumar
@sangamcse
Mar 08 2018 08:37
That test_files is for config test which was done for filter config. You can add new test for cmake_filter.
Here is rough idea ...
CMakeLintBearFilterTest = verify_local_bear(
    CMakeLintBear,
    valid_files=(good_file, bad_file_mixes_case),
    invalid_files=(),
    tempfile_kwargs={'suffix': '.cmake'},
    settings={'cmake_filter': ....yourfilter....})
@kriti21
Harsh Kumar Bhartiya
@harshhx17
Mar 08 2018 10:09
I needed some help regarding coala/coala-bears#2298
Using multiple languages in a build is not supported directly in circleci 2.0
A probable solution will be to use a custom docker image
There is also a way in which we can use different dockers for different parts of tests ....
But I don't think that will be useful as builds from one docker will not stay in the other docker
And the tests or commands that require more than one language will still be a problem
and we will continuosly need to change the circleci config with new tests
Harsh Kumar Bhartiya
@harshhx17
Mar 08 2018 10:20
If we decide to use a custom docker image...
Where should it be hosted?...Dockerhub?
Kriti Rohilla
@kriti21
Mar 08 2018 10:53
Thanks for the help @sangamcse
Naveen Naidu
@Naveenaidu
Mar 08 2018 13:13
Can someone please give me some example of bears that produce multiple diffs?
Ishan Srivastava
@ishanSrt
Mar 08 2018 13:14
most bears which do natural language processing can give you multiple diffs
Naveen Naidu
@Naveenaidu
Mar 08 2018 13:15
Thank you :)
Ishan Srivastava
@ishanSrt
Mar 08 2018 15:59

How do you say that multiple diffs are being generated in the Natural Language Bear

@Naveenaidu that’s why I stressed upon the word can, natural languages can have many ways to correct a sentence.