These are chat archives for coala/coala-bears

9th
Mar 2018
John Vandenberg
@jayvdb
Mar 09 2018 05:18 UTC
ping @nvzard , can you finish your PR now ?
Nitanshu
@nvzard
Mar 09 2018 05:22 UTC
yes
John Vandenberg
@jayvdb
Mar 09 2018 05:22 UTC
:+1:
Nitanshu
@nvzard
Mar 09 2018 05:22 UTC
coala/coala-bears#2303
let's get the master-branch fixed

@jayvdb I'm already done, please review. I'll make the changes if needed

ping @nvzard , can you finish your PR now ?

John Vandenberg
@jayvdb
Mar 09 2018 05:41 UTC
#2303 is the right approach. lets get that one merged first
supporting multiple versions which behave differently is not always a good idea.
we dont have good infrastructure to do that yet ; it would require testing against multiple versions of those dependencies, to ensure we dont break them
Nitanshu
@nvzard
Mar 09 2018 05:47 UTC

@jayvdb 0.3.0 was the bad version for dockerfile_lint, and they somehow unreleased that and released the patched version i.e 0.3.1, so there is no bad version
https://github.com/projectatomic/dockerfile_lint/releases

supporting multiple versions which behave differently is not always a good idea.

John Vandenberg
@jayvdb
Mar 09 2018 05:50 UTC
but 0.3.1 has a different featureset
Nitanshu
@nvzard
Mar 09 2018 06:24 UTC
@jayvdb I made the changes please take a look coala/coala-bears#2303
Nitanshu
@nvzard
Mar 09 2018 06:36 UTC
@jayvdb made the requested changes

:o

master is fixed atm

but how :O?
Manan Kalra
@manankalra
Mar 09 2018 06:39 UTC
@nvzard because they unreleased 0.3.0 according to you, and 0.2.7 gets installed maybe because of that
And the tests are compatible to it already
Maybe that's why
Nitanshu
@nvzard
Mar 09 2018 06:40 UTC
but they also release 0.3.1
John Vandenberg
@jayvdb
Mar 09 2018 06:40 UTC
ya, need to see if that is being installed
Nitanshu
@nvzard
Mar 09 2018 06:40 UTC
and even autoprefixer version 8.0.0 was breaking tests.
for CSSPrefixBear
John Vandenberg
@jayvdb
Mar 09 2018 06:41 UTC
coala/coala-bears#2319 makes it difficult
upstream problems often sort themselves out if we report the problem upstream
Vaibhav Rai
@RaiVaibhav
Mar 09 2018 06:41 UTC
what is going on here :sweat_smile:
Upstream mess
Nitanshu
@nvzard
Mar 09 2018 06:42 UTC

@jayvdb why don't we do a npm list in CI after all the deps are installed to show the versions

coala/coala-bears#2319 makes it difficult

John Vandenberg
@jayvdb
Mar 09 2018 06:42 UTC
@nvzard , the pinning for some of these is still a good idea , so dont close your PR yet.
will npm list show all, or only the versions of the direct dependencies listed in package.json ?
Nitanshu
@nvzard
Mar 09 2018 06:43 UTC
all
we can even only display deps listed in package.json
npm list [name]
by doing this for every dependency ^^
John Vandenberg
@jayvdb
Mar 09 2018 06:45 UTC
that requires parsing package.json :P
need a neat solution
Nitanshu
@nvzard
Mar 09 2018 06:47 UTC
its possible
John Vandenberg
@jayvdb
Mar 09 2018 06:47 UTC
everything is possible ;)
@jayvdb may I be assigned to coala/coala-bears#2319, I'll work on a neat solution ;)
John Vandenberg
@jayvdb
Mar 09 2018 06:55 UTC
no. do analysis first, dump suggestions on the issue
Nitanshu
@nvzard
Mar 09 2018 06:55 UTC
okie
John Vandenberg
@jayvdb
Mar 09 2018 06:59 UTC
rebuilding https://circleci.com/gh/coala/coala-bears/8564 on circle; we'll see if it passes; if not, we need to expire its cached npm package
Nitanshu
@nvzard
Mar 09 2018 07:00 UTC
:+1:
Adhityaa
@adtac
Mar 09 2018 07:33 UTC
corobo new issue coala-bears Add JSPrettierBear
corobo
@co-robo
Mar 09 2018 07:33 UTC
Command "new" / "new issue" not found.
Adhityaa
@adtac
Mar 09 2018 07:34 UTC
ah, we disabled that :/
John Vandenberg
@jayvdb
Mar 09 2018 07:35 UTC
cached circle build failed; now running an uncached build on circle : https://circleci.com/gh/coala/coala-bears/8565
John Vandenberg
@jayvdb
Mar 09 2018 08:13 UTC
shit; still problems installing language-check on circle ci
Maya Farber Brodsky
@farberbrodsky
Mar 09 2018 08:28 UTC
corobo assign coala/coala-bears#2304
corobo
@co-robo
Mar 09 2018 08:28 UTC
Command "assign" / "assign coala/coala-bears#2304" not found.
Maya Farber Brodsky
@farberbrodsky
Mar 09 2018 08:29 UTC
corobo help
John Vandenberg
@jayvdb
Mar 09 2018 08:32 UTC
i've invited you to join the org
then we can assign an issue to you
add a comment on the issue when you've accepted the invitation
Maya Farber Brodsky
@farberbrodsky
Mar 09 2018 09:50 UTC
@jayvdb I've accepted the invitation :)
John Vandenberg
@jayvdb
Mar 09 2018 10:01 UTC
assigned
ping @nvzard , waiting on you to fix your PR
Nitanshu
@nvzard
Mar 09 2018 15:18 UTC
pong @jayvdb , how can I get Circle CI to rebuild my PR coala/coala-bears#2303
I disabled it on my fork, stopped building nvzard/coala-bears
Vaibhav Rai
@RaiVaibhav
Mar 09 2018 15:32 UTC
@nvzard repush without any change
It will restart or maintainer have only access to restart Circle Ci
@jayvdb It will be helpfull if you take a look at coala/coala-bears#2296
John Vandenberg
@jayvdb
Mar 09 2018 15:40 UTC
@nvzard , yup, @RaiVaibhav is sort of right, but maybe not detailed enough. now you have disabled your circle ci, you need to repush. but you need to do an amend on the last commit, amending nothing except the commit sha , then the repush will trigger a new build
@RaiVaibhav , why using name "mycve" ?
Nitanshu
@nvzard
Mar 09 2018 15:43 UTC
At first I forgot to amend and did the push, nothing happened :P
done :+1:
John Vandenberg
@jayvdb
Mar 09 2018 15:44 UTC
yay; the build is happening on coala's Circle.
now cross fingers and toes it passes
Nitanshu
@nvzard
Mar 09 2018 15:48 UTC
It takes a lot of time for builds to pass :v
more than 25 mins :3
hope it passes
John Vandenberg
@jayvdb
Mar 09 2018 15:49 UTC
@nvzard , your commit messages need updating
the issue number is wrong for autoprefixer
Nitanshu
@nvzard
Mar 09 2018 15:49 UTC
yeah you closed that issue
I left comments
John Vandenberg
@jayvdb
Mar 09 2018 15:50 UTC
and I replied
Nitanshu
@nvzard
Mar 09 2018 15:51 UTC
Oh sorry, I just saw that
John Vandenberg
@jayvdb
Mar 09 2018 15:52 UTC
are you really confident that dockerlint 0.3.1 is breaking the tests ?
Nitanshu
@nvzard
Mar 09 2018 15:52 UTC
I re-pushed
John Vandenberg
@jayvdb
Mar 09 2018 15:52 UTC
because green travis build seems to suggest it is ok
but because we dont have an npm listing of versions we cant be sure what caching is doing behind the scenes
the commits are still useful, but the commit messages assert that dockerlint 0.3.1 is causing problems, and I am not confident that is true
Nitanshu
@nvzard
Mar 09 2018 15:54 UTC
@jayvdb
here are dem logs
I tested locally with dockerfile_lint 0.3.1
John Vandenberg
@jayvdb
Mar 09 2018 15:57 UTC
ok
that saves me having to verify it
have you found any solutions for the npm list problem? a custom script is not a good option
ideally we use some existing tool
oh shit; circle is doing an uncached build it seems
Nitanshu
@nvzard
Mar 09 2018 16:01 UTC
No issues, here I ran tests using both 0.3.1 and 0.2.7 :- https://pastebin.com/DmAPJzUG
John Vandenberg
@jayvdb
Mar 09 2018 16:01 UTC
which may means it breaks on language-check again
an old issue coming back to haunt us coala/coala-bears#1865
Nitanshu
@nvzard
Mar 09 2018 16:02 UTC
I was monitoring circle ci logs last time it was building and maybe it passes .ci/deps.pip.sh
John Vandenberg
@jayvdb
Mar 09 2018 16:03 UTC
ok. then we cross extra toes and stuff
Nitanshu
@nvzard
Mar 09 2018 16:03 UTC
haha :P

I left a comment coala/coala-bears#2319

have you found any solutions for the npm list problem? a custom script is not a good option

Nitanshu
@nvzard
Mar 09 2018 16:22 UTC
@jayvdb Circle CI passed :sparkles: :clap:
John Vandenberg
@jayvdb
Mar 09 2018 16:40 UTC
@nvzard , do you have that astyle patch handy ...
Nitanshu
@nvzard
Mar 09 2018 16:41 UTC
shit
John Vandenberg
@jayvdb
Mar 09 2018 16:41 UTC
though we might want a different approach. sf.net is a terrible dependency
we've uploaded tarballs to github in the past to avoid sf.net
Nitanshu
@nvzard
Mar 09 2018 16:42 UTC

let's do that again then? :3

we've uploaded tarballs to github in the past to avoid sf.net

John Vandenberg
@jayvdb
Mar 09 2018 16:42 UTC
your current PR is still building ok
John Vandenberg
@jayvdb
Mar 09 2018 16:44 UTC
https://github.com/coala/bear-runtime-deps , but it is for runtime dependencies, not build deps
Vaibhav Rai
@RaiVaibhav
Mar 09 2018 16:44 UTC
mycve it's just a random name :sweat_smile: I will change name and make the PR more understandable by viewing it.
John Vandenberg
@jayvdb
Mar 09 2018 16:45 UTC
thx @RaiVaibhav
we should have a green tree soon
Nitanshu
@nvzard
Mar 09 2018 16:45 UTC
:sparkles:
Nitanshu
@nvzard
Mar 09 2018 16:51 UTC
:palm_tree: GREEN TREE coala/coala-bears#2303
John Vandenberg
@jayvdb
Mar 09 2018 16:54 UTC
haha
not yet, it still needs to get merged and a master build to be green too
anything could go wrong in the next 30 mins :P
Nitanshu
@nvzard
Mar 09 2018 16:55 UTC
ok. then we cross extra toes and stuff
:P
John Vandenberg
@jayvdb
Mar 09 2018 16:55 UTC
hehe
feel free to create a new issue that describes the problem with autofixer 8.0.0 . focus on describing the problem, and the cause, rather than jumping to the solution
Nitanshu
@nvzard
Mar 09 2018 17:00 UTC
sure :+1:

I'll keep that in mind from now on, thanks : )

focus on describing the problem, and the cause, rather than jumping to the solution

Manan Kalra
@manankalra
Mar 09 2018 18:50 UTC
@jayvdb @nvzard https://postimg.org/image/mx2fh3n9h/
the old tests for DockerfileLintBear are passing for both 0.2.7 and 0.3.1
Nitanshu
@nvzard
Mar 09 2018 18:52 UTC
dafaq
Harsh Kumar Bhartiya
@harshhx17
Mar 09 2018 18:52 UTC
@jayvdb The builds are still failing on my fork...
However, the same builds are passing on coala/coala-bears
Manan Kalra
@manankalra
Mar 09 2018 18:54 UTC
@jayvdb @nvzard
and ideally, they should
because according to projectatomic/dockerfile_lint@638f227
they added an additional rule - so that we don't add the MAINTAINER thing in our dockerfiles (because there's something new in Docker v1.3.0)
and, the current tests do use the MAINTAINER tag and the old rule file, i.e. without the newly added rule
so there's nothing wrong with 0.3.1, it doesn't break any tests

https://pastebin.com/DmAPJzUG

yeah, I did see this

Nitanshu
@nvzard
Mar 09 2018 19:02 UTC
I tested it again
dockerfile_lint 0.3.1 is still breaking tests on the current master branch
@manankalra tests fail when we don't use the default rule file
Manan Kalra
@manankalra
Mar 09 2018 19:04 UTC
then it must be breaking the test which has accepts no rule files, right?
Nitanshu
@nvzard
Mar 09 2018 19:05 UTC
yup
Manan Kalra
@manankalra
Mar 09 2018 19:06 UTC
hmm
idk why this isn't the case with me!! :laughing:
Nitanshu
@nvzard
Mar 09 2018 19:09 UTC
do a version check again
npm list -g dockerfile_lint
Manan Kalra
@manankalra
Mar 09 2018 19:11 UTC
did, 0.3.1 passing
Nitanshu
@nvzard
Mar 09 2018 19:11 UTC
wierd
Manan Kalra
@manankalra
Mar 09 2018 19:11 UTC

but I know this shouldn't happen

the MAINTAINER command is deprecated

this must be there in the output^

Nitanshu
@nvzard
Mar 09 2018 19:12 UTC
yeah, and my error logs shows that this is missing
Vaibhav Rai
@RaiVaibhav
Mar 09 2018 21:31 UTC
If anyone is up then please take a look at coala/coala-bears#2296