These are chat archives for coala/coala-bears

18th
Mar 2018
John Vandenberg
@jayvdb
Mar 18 2018 01:10
safety does import pip, which fails with most recent pip
Vaibhav Rai
@RaiVaibhav
Mar 18 2018 03:28
Gitmate unassigned me :sweat_smile:
A PR was needed a last review from maintainers coala/coala-bears#2293
please reassign
Vaibhav Rai
@RaiVaibhav
Mar 18 2018 03:52
also please add status block coala/coala-bears#2113
don't want to get unassigned on one more issue
Viresh Gupta
@virresh
Mar 18 2018 04:50

Gitmate unassigned me on coala/coala-bears#2272
This has a PR approved coala/coala-bears#2278 and waiting to be merged :sweat_smile:

Also it unassigned me from coala/coala-bears#2286
Please re-assign, it has work in progress in the pr coala/coala-bears#2310

Also about the pip v 9.0.2, changelog was added here https://pip.pypa.io/en/stable/news/, but it doesn't really provide any useful insight about the builds failing.

Should I make an issue for version pin to 9.0.1 on CircleCI ? (Or we would wait for more information and use travis in the meanwhile ?)
@jayvdb

Viresh Gupta
@virresh
Mar 18 2018 04:57
Tested the downgradation of pip here https://circleci.com/gh/virresh/coala-bears/32
It works as an immediate fix
John Vandenberg
@jayvdb
Mar 18 2018 04:58
do we have an issue about it?
if not, please create
and note in a comment that downgrade works
and then we need to investigate why latest pip is failing
Viresh Gupta
@virresh
Mar 18 2018 04:58
Sure
John Vandenberg
@jayvdb
Mar 18 2018 04:58
what did they change (vendoring method, probably)
Viresh Gupta
@virresh
Mar 18 2018 04:59
The only change they've added is support for fallback to secure transport on macOS
John Vandenberg
@jayvdb
Mar 18 2018 05:00
eh? that is the only change in the latest release of pip ?
Viresh Gupta
@virresh
Mar 18 2018 05:01
Yeah
Apparently the date is erroraneous
on the official page
John Vandenberg
@jayvdb
Mar 18 2018 05:10
there was a bug about the changelog not being updated
Viresh Gupta
@virresh
Mar 18 2018 05:30
pypa/pip#5074
^This one ?
They have closed this one saying its done :worried:
John Vandenberg
@jayvdb
Mar 18 2018 05:57
Viresh Gupta
@virresh
Mar 18 2018 05:58

Looking at https://github.com/pypa/pip/issues/5079#issuecomment-373929937
In pip 9.0.2, the pip internals were moved from pip to pip._internal
So all packages that do a import pip will break

Apparently the import pip was never a supported thing, so it will remain unsupported until some other pip developer feels they should fix it....
They suggest to pin pip 9.0.1 or fix all the packages that do import pip

Vaibhav Rai
@RaiVaibhav
Mar 18 2018 06:00
pyupio/safety#90
Viresh Gupta
@virresh
Mar 18 2018 06:01

https://travis-ci.org/coala/coala-bears/jobs/354914979 - now a setuptools problem ?

This is getting crazier by the minute

Ankit Joshi
@MacBox7
Mar 18 2018 06:08
@jayvdb replied
John Vandenberg
@jayvdb
Mar 18 2018 06:33
ok, so pinning pip needs to be part of the PySafetyBear requirements .. ?
installing coala-bears with PySafetyBear should force a downgrade to pip 9.0.1
also we need to create an issue about py33 , as that needs to get fixed too
but if circle is fixed, we can make travis optional again, in order to keep merges happening
Viresh Gupta
@virresh
Mar 18 2018 06:36

ok, so pinning pip needs to be part of the PySafetyBear requirements .. ?

Apparently until PySafety is made compatible as per the following,

pyupio/safety#90

pinning pip is the only way out , but strangely enough we are using safety version 0.5.1 which has been long back succeeded by 1.7.0
Testing on Circle, if upgrading to 1.7.0 fixes it, we are saved until pip 10 is released

John Vandenberg
@jayvdb
Mar 18 2018 06:39
@RaiVaibhav has been working on upgrading safety I believe
does safety pin pip ?
Vaibhav Rai
@RaiVaibhav
Mar 18 2018 06:39
safety still uses the pip 9.0.1, either wait for safety org to do something then accordingly change our Bear (whole bear needs rewriting) or disable the safety bear for now
John Vandenberg
@jayvdb
Mar 18 2018 06:39
if not, we still need to pin pip ourselves
Vaibhav Rai
@RaiVaibhav
Mar 18 2018 06:39
pyupio/safety#90
see this there is already a issue open there
John Vandenberg
@jayvdb
Mar 18 2018 06:40
ya, that was months ago
Vaibhav Rai
@RaiVaibhav
Mar 18 2018 06:41
that whats I hate totally when no one respond to such a big problem
John Vandenberg
@jayvdb
Mar 18 2018 06:42
requirements_dev.txt:pip==9.0.1
Vaibhav Rai
@RaiVaibhav
Mar 18 2018 06:47
ok ok we are using safety version = 0.5.1and there they imported the pip in safety file
Vaibhav Rai
@RaiVaibhav
Mar 18 2018 06:59
@virresh does any else package on coala/bears also depend on pip internals(old one)
John Vandenberg
@jayvdb
Mar 18 2018 07:00
pyupio/safety#114
Viresh Gupta
@virresh
Mar 18 2018 07:01

@virresh does any else package on coala/bears also depend on pip internals(old one)

Apparently no, though I haven't finished checking all other requirements yet

Vaibhav Rai
@RaiVaibhav
Mar 18 2018 07:02
If may be no then dropping the safety bear currently is the only option to restart the workflow
Viresh Gupta
@virresh
Mar 18 2018 07:02
safety version 1.7.0 would require complete bear rewrite right ?
Vaibhav Rai
@RaiVaibhav
Mar 18 2018 07:02
yes
whole code changes
instead whole live data changes
John Vandenberg
@jayvdb
Mar 18 2018 07:03
what version can we go up to with your patch @RaiVaibhav ?
Vaibhav Rai
@RaiVaibhav
Mar 18 2018 07:03
let me check
John Vandenberg
@jayvdb
Mar 18 2018 07:06
I am loathe to add a pip pin in the bear; IMO we add a pin in dev-requirements.txt for the moment . and maybe also change .ci/deps.pip.sh so that it doesnt install a higher pip which is then downgraded.
Vaibhav Rai
@RaiVaibhav
Mar 18 2018 07:08
unfortunately only to 0.5.1
John Vandenberg
@jayvdb
Mar 18 2018 07:12
can someone create an issue about the py33 thing
and try to get circle green; I think @virresh you had a patch for that
Vaibhav Rai
@RaiVaibhav
Mar 18 2018 07:14
I can make it whatever I want but like same I need to change the code to make to work for higher version of safety
Viresh Gupta
@virresh
Mar 18 2018 07:22
Yeah @jayvdb
I have a patch that pins pip 9.0.1
John Vandenberg
@jayvdb
Mar 18 2018 07:23
PR ?
Viresh Gupta
@virresh
Mar 18 2018 07:23
will just make one
commit message not up as per the guideline :sweat_smile:
Made the PR here coala/coala-bears#2360
Looking into the py33 thingy...
That is getting on my nerves :sweat_smile:
John Vandenberg
@jayvdb
Mar 18 2018 07:44
@virresh , the pin in dev-requirements.txt should be <=9.0.1
we dont want to force people to upgrade if they have a compatible version
Viresh Gupta
@virresh
Mar 18 2018 07:45
oh
okay
Viresh Gupta
@virresh
Mar 18 2018 07:55
@jayvdb
silly one, but is the dev-requirements.txt this one https://github.com/coala/coala-bears/blob/master/bear-requirements.txt ?
saksham189
@saksham189
Mar 18 2018 08:14
could these issues #2214, #2226, #2290 be reassigned to me. I had PR's open for all of them
John Vandenberg
@jayvdb
Mar 18 2018 08:26
no, bear-requirements.txt is a generated file from the bears
@virresh , oh, test-requirements.txt
Viresh Gupta
@virresh
Mar 18 2018 08:28
Ah,
Cool
I'll update that :sweat_smile:
John Vandenberg
@jayvdb
Mar 18 2018 09:26
@virresh , please include all relevant parts of the log in the issue ; helps other find it later, and also the problem may not be the part you found
there are a lot of errors in that log
Ankit Joshi
@MacBox7
Mar 18 2018 09:37
@jayvdb regarding the promotion to developers role, is it necessary for the PR that you have reviewed to be merged?
John Vandenberg
@jayvdb
Mar 18 2018 09:44
highly preferred , but 'approved' also ok given the backlog we have atm
Ankit Joshi
@MacBox7
Mar 18 2018 09:48
I have completed all tasks except the one with a review on a PR that is being approved. I have made reviews on some but none of them has been approved yet.
I have dm you with the final milestones.
Viresh Gupta
@virresh
Mar 18 2018 09:54

@virresh , please include all relevant parts of the log in the issue ; helps other find it later, and also the problem may not be the part you found

Sure :smile:

John Vandenberg
@jayvdb
Mar 18 2018 10:07
and travis logs can disappear
or at least can be difficult to load
p.s. ive got a fix for the py33 problem
Viresh Gupta
@virresh
Mar 18 2018 10:11
Oh
Great ! :D
John Vandenberg
@jayvdb
Mar 18 2018 10:25
coala/coala-bears#2362
saksham189
@saksham189
Mar 18 2018 10:36
@jayvdb i have dm you with the work i have done with coala. Can i be promoted to the developer role?
Viresh Gupta
@virresh
Mar 18 2018 10:49

coala/coala-bears#2362

Phew,
That is a lot of dependency pins for the day :sweat_smile:

John Vandenberg
@jayvdb
Mar 18 2018 10:56
@anctartica , you've filled in the form?
saksham189
@saksham189
Mar 18 2018 11:20
yes i have filled it now :smile: @jayvdb
Vaibhav Rai
@RaiVaibhav
Mar 18 2018 12:04
reassign coala/coala-bears#2102 :sweat_smile:
It currently block by coala/coala-bears#2296
John Vandenberg
@jayvdb
Mar 18 2018 12:48
you've been told twice to fix your commit message, so that needs to be fix on your machine before it can possibly be ready for review
only use server rebase if it was correct and the build was broken for some unrelated reasons
Vaibhav Rai
@RaiVaibhav
Mar 18 2018 12:51
:+1:
Sorry for my action, but intention was something else here
laziness effects here so I rebased, sorry
Ankit Joshi
@MacBox7
Mar 18 2018 20:55
All tests pass coala/coala-bears#2334
Rohan
@rohanrk
Mar 18 2018 22:59
What does it mean if my tests pass Travis but not Circle?
They run the same script don’t they?