These are chat archives for coala/coala-bears

19th
Mar 2018
John Vandenberg
@jayvdb
Mar 19 2018 01:00
they run the same tests, but on different environments, and slightly different workarounds on each of them
Ankit Joshi
@MacBox7
Mar 19 2018 04:34
All tests pass coala/coala-bears#2334 Can the PR be merged ?
Rohan
@rohanrk
Mar 19 2018 09:14

@jayvdb So how would I go about debugging it if my CircleCI test isn’t passing? It fails at the test script.

FAIL Required test coverage of 100% not reached. Total coverage: 43.46%

Sangam Kumar
@sangamcse
Mar 19 2018 09:57
Have you tested it locally?
Rohan
@rohanrk
Mar 19 2018 09:57
Travis passes, I just tested it locally and all the tests pass except GoFMTBear because gofmt isn’t installed?
Sangam Kumar
@sangamcse
Mar 19 2018 09:59
Have you gone through the log of your circleci's tests?
Rohan
@rohanrk
Mar 19 2018 10:00
Yeah. There’s an error in collecting PySafetyBear’s requirements
I’m going through the stacktrace but I still can’t figure it out.
Sangam Kumar
@sangamcse
Mar 19 2018 10:01
43% coverage 😯 that means something is wrong
Please share your PR link
John Vandenberg
@jayvdb
Mar 19 2018 10:06
@sangamcse , ping me if you need help with ^
Sangam Kumar
@sangamcse
Mar 19 2018 10:10
Collecting pip
  Downloading pip-9.0.2-py2.py3-none-any.whl (1.MB)
    100% |████████████████████████████████| 1.MB 42kB/s 
Installing collected packages: pip
  Found existing installation: pip 9.0.1
    Uninstalling pip-9.0.1:
      Successfully uninstalled pip-9.0.1
Successfully installed pip-9.0.2
and travis is using previous pip. Have a look https://travis-ci.org/coala/coala-bears/jobs/355140184#L1245
Viresh Gupta
@virresh
Mar 19 2018 10:18
@rohanrk @sangamcse ,
The master branch was fixed for this particular issue recently , a simple rebase should do the trick
Sangam Kumar
@sangamcse
Mar 19 2018 10:18
Ahh
understood now
@rohanrk, can you repush your commit using git commit --amend --no-edit and git push -f
Rohan
@rohanrk
Mar 19 2018 10:25
Yes
Thanks! Makes sense
Rohan
@rohanrk
Mar 19 2018 11:05
@sangamcse @virresh Thanks for your help!
Sangam Kumar
@sangamcse
Mar 19 2018 11:06
I have requested one change, rest is ok with that. Also, you should add commit body in your commit.
Rohan
@rohanrk
Mar 19 2018 11:07
Isn’t the commit body optional? For this the issue goes over the reasoning of the change on its own
Sangam Kumar
@sangamcse
Mar 19 2018 11:08
Still you can show what this change will do
Rohan
@rohanrk
Mar 19 2018 11:08
Ok. I’ll amend.
Sangam Kumar
@sangamcse
Mar 19 2018 11:08
Appreciate it :wink:
John Vandenberg
@jayvdb
Mar 19 2018 11:37
I was just thinking about optional commit bodies ... https://github.com/coala/projects/pull/489#issuecomment-374183230
John Vandenberg
@jayvdb
Mar 19 2018 11:52
@RaiVaibhav , there is interested upstream to fix the pip dependency pyupio/safety#114
Vaibhav Rai
@RaiVaibhav
Mar 19 2018 12:24
I am adding this message into my bookmark many work is pending, currently do not want to divert my mind, focusing on what I can do in this short period of GSOC deadline :+1:
John Vandenberg
@jayvdb
Mar 19 2018 12:26
no worries
Rohan
@rohanrk
Mar 19 2018 15:48
@jayvdb coala/coala-bears#2367 is ready!
Sangam Kumar
@sangamcse
Mar 19 2018 15:50
^ This PR is more like difficulty/newcome issue :smile:
:laughing: ohk. no problem @rohanrk
Ankit Joshi
@MacBox7
Mar 19 2018 16:27
@jayvdb PR needs review coala/coala-bears#2334 :sweat_smile: