These are chat archives for coala/coala-bears

23rd
Mar 2018
Viresh Gupta
@virresh
Mar 23 2018 14:54
@jayvdb , I have separated the hg commit bear and git commit bear's common parts
Please review when possible :sweat_smile:
coala/coala-bears#2310
John Vandenberg
@jayvdb
Mar 23 2018 15:27
@virresh , whys isnt check_issue_reference in the base class ?
Viresh Gupta
@virresh
Mar 23 2018 15:30
for checking issue reference we are using host-based regexe's primarily...
So the hosts will be different for mercurial and git.
That's why I kept them in their respective classes
Viresh Gupta
@virresh
Mar 23 2018 15:36
I guess I can follow an abstract function based approach for uniting check_issue_reference as well
Will ping you after modifying it accordingly
Thanks :smile:
John Vandenberg
@jayvdb
Mar 23 2018 15:42
ta