These are chat archives for coala/coala-bears

6th
Apr 2018
John Vandenberg
@jayvdb
Apr 06 2018 02:31
@virresh, @RaiVaibhav, IMO we should only exclude 9.0.2, and possibly get ahead of the game and blacklist pip 10, because I am sure we dont want pip 10 until about pip 10.2.7
John Vandenberg
@jayvdb
Apr 06 2018 05:20
build speedup coala/coala-bears#2403
Viresh Gupta
@virresh
Apr 06 2018 07:17

@virresh, @RaiVaibhav, IMO we should only exclude 9.0.2, and possibly get ahead of the game and blacklist pip 10, because I am sure we dont want pip 10 until about pip 10.2.7

I thought so.
I will file an issue for it then

John Vandenberg
@jayvdb
Apr 06 2018 08:35
@manankalra, ping on coala/coala-bears#2335 ; push it so it has green CI and is back ready for review
easy fixes have been pointed out in review comments. dont let it fall
Manan Kalra
@manankalra
Apr 06 2018 08:42
@jayvdb I still have to write a test for it, will do it by tomorrow. Yeah, I did look at the review comments, will push the changes along with the test.
Btw, coala/coala-bears#2257 - this one also needs a review - I made the final changes as Mischa suggested. Hasn't been reviewed since a couple of months. :smile:
John Vandenberg
@jayvdb
Apr 06 2018 08:55
ok, im gonna look at that one next then
John Vandenberg
@jayvdb
Apr 06 2018 09:06
ok, got a question for you there
Manan Kalra
@manankalra
Apr 06 2018 10:51
@jayvdb addressed it
also, this one -> coala/coala#5252
John Vandenberg
@jayvdb
Apr 06 2018 11:25
@manankalra , replied.
John Vandenberg
@jayvdb
Apr 06 2018 12:01
@kriti21 , please stop pushing unless you've fixed the issues raised in the previous review
Kriti Rohilla
@kriti21
Apr 06 2018 12:02
I am sorry @jayvdb . I am working on it. Had some confusion that's why pushed it early but I have got it now.
John Vandenberg
@jayvdb
Apr 06 2018 12:05
test locally
also, regarding the diff_distance thing, providing 0 isn't the same as providing a negative number
John Vandenberg
@jayvdb
Apr 06 2018 12:18
what does 0 do?
John Vandenberg
@jayvdb
Apr 06 2018 12:34
that example code isnt very help. it should show what is in the resulting objects diffs
if I understand correctly, -1 will result in a diff for -a , another for -e , and a third for +f
Manan Kalra
@manankalra
Apr 06 2018 12:40

it should show what is in the resulting objects diffs

right

according to what split_diff does:

Splits this diff into small pieces, such that several continuously altered lines are still together in one diff. All subdiffs will be yielded.

^^this is the default behavior, providing distance == 1
if we provide 0, those continously altered lines aren't considered together in a single diff, and are yielded as a different Diff object

in case of a negative number, same as what you said

i.e.

-1 will result in a diff for -a , another for -e , and a third for +f

John Vandenberg
@jayvdb
Apr 06 2018 12:48
wow, I found a rabbit warren in coala/coala#2898
John Vandenberg
@jayvdb
Apr 06 2018 13:50
@manankalra , IMO, a docstring update is needed, and it should just say -1, not any negative value
Manan Kalra
@manankalra
Apr 06 2018 13:52
@jayvdb yeah, I'll file an issue
and change coala/coala#5252 accordingly.
any other changes?
i'm not sure
John Vandenberg
@jayvdb
Apr 06 2018 14:00
sure, but the documentation doesnt need to tell people to use any value at all
if everyone uses -1, the implementation can be modified and the -1 can be a trigger
maybe in the future we want to add another diff split result type, and would want to activate it with -2
Manan Kalra
@manankalra
Apr 06 2018 14:10
:+1:
John Vandenberg
@jayvdb
Apr 06 2018 15:07
@manankalra you have not replied to https://github.com/coala/coala-bears/pull/2257#discussion_r179699070 ; am I misunderstanding something here?
John Vandenberg
@jayvdb
Apr 06 2018 15:09
ok, if all flags are enabled by default, then all of our new settings should be enabled by default ...?
i.e. these new settings you are creating would be mostly used to deactivate undesirable checks?
Manan Kalra
@manankalra
Apr 06 2018 15:11

then all of our new settings should be enabled by default ...?

they already are, by the -all flag

i.e. these new settings you are creating would be mostly used to deactivate undesirable checks?

yes, yes, right
also, to activate only a particular check or a subset of checks or to disable a subset of checks

John Vandenberg
@jayvdb
Apr 06 2018 15:12
yup. ok
that was my main objective. we dont want all checks accidentally disabled ;-)
Manan Kalra
@manankalra
Apr 06 2018 15:13
:+1:
Kriti Rohilla
@kriti21
Apr 06 2018 15:14
@jayvdb I have some doubt related to GitCommitBear issue. Please address https://github.com/coala/coala-bears/pull/2241/commits/7f1e98b715392017a9e52938fbe604b4ab703094#r179789218 .
Manan Kalra
@manankalra
Apr 06 2018 15:14
I pushed that -1 change for the diff_distance thing.
John Vandenberg
@jayvdb
Apr 06 2018 15:38
@makman2, and others coala/coala#5252 looks ok to me, but more eyes would be good
John Vandenberg
@jayvdb
Apr 06 2018 15:52
another one merged, and im off to bed.
Sangam Kumar
@sangamcse
Apr 06 2018 15:53

@jayvdb, for coala/coala-bears#2386

def some_setting(select: str='--select',
                 ignore: str='--ignore',
                 select_check: typed_list(str)=(),
                 ignore_check: typed_list(str)=()):

    if set(select_check).intersection(set(ignore_check)):
          self.err("Some error message")
          self.err(set(select_check).intersection(set(ignore_check)))
          return

    if select_check:
        select_list = ','.join(part.strip() for part in select_check)
        args = (select, select_list,)

    if ignore_check:
        ignore_list = ','.join(part.strip() for part in ignore_check)
        args += (ignore, ignore_list,)

    return args

You mean something like this?

John Vandenberg
@jayvdb
Apr 06 2018 15:57
something like that
Sangam Kumar
@sangamcse
Apr 06 2018 15:58
Ohk. So where should I put this code? coala/coala or coala/coala-bears
John Vandenberg
@jayvdb
Apr 06 2018 16:11
So that is one style. The other common style is like the govet PR, with bools for each check