These are chat archives for coala/coala-bears

11th
Apr 2018
Boxuan Li
@li-boxuan
Apr 11 2018 02:27
especially the expected behaviour, and where you are putting the ^ symbols
@jayvdb Not sure if I understand, but I add some comment regarding the position of ^ symbol here: https://github.com/PyCQA/pylint/issues/2012#issuecomment-380305939
John Vandenberg
@jayvdb
Apr 11 2018 02:56
interesting ;-)
Giovan Isa Musthofa
@giovanism
Apr 11 2018 02:59
corobo cant assign?
John Vandenberg
@jayvdb
Apr 11 2018 03:02
ya, been out of order for a while. We have a GSoC project to bring it back up.
Vaibhav Rai
@RaiVaibhav
Apr 11 2018 14:23
pastebin @kriti21
Kriti Rohilla
@kriti21
Apr 11 2018 14:23
Oh sorry.. Right @RaiVaibhav Thanks
Kriti Rohilla
@kriti21
Apr 11 2018 14:29
@jayvdb Regarding coala/coala-bears#337 Here https://pastebin.com/R5iWKxks are some changes I have done. Does it look better now?
Ankit Joshi
@MacBox7
Apr 11 2018 20:23
A query regarding coala/coala-bears#2416 and the use of IGitt. Need help.
Ankit Joshi
@MacBox7
Apr 11 2018 21:15
@RaiVaibhav which environment are you talking about?
Vaibhav Rai
@RaiVaibhav
Apr 11 2018 21:15
your local environment
Ankit Joshi
@MacBox7
Apr 11 2018 21:16
Yes so if someone else uses coala he also needs to have his token stored in local environment.
Vaibhav Rai
@RaiVaibhav
Apr 11 2018 21:16
afcourse

Clear this point first

One way to approach this is that we can create our token and use it to query all issue state

Ankit Joshi
@MacBox7
Apr 11 2018 21:17
Yes, but that's what I am asking, I have my concerns that this won't be a recommended way.
Vaibhav Rai
@RaiVaibhav
Apr 11 2018 21:18
why you think it's not a recomended way
Ankit Joshi
@MacBox7
Apr 11 2018 21:18
Since you are forcing user to have some additional settings. i.e burdening him
Vaibhav Rai
@RaiVaibhav
Apr 11 2018 21:18
but access token is something which no one will share
so everyone has to import it's own token
Ankit Joshi
@MacBox7
Apr 11 2018 21:19
Yes but we can do this without asking user of his token
With the git apis
Vaibhav Rai
@RaiVaibhav
Apr 11 2018 21:19
GItcommitBear is a Global Bear
it may happen that it exceeds the rate limit (60)
so that's why we use token

With the git apis

You can but same here also rate limit problem

Ankit Joshi
@MacBox7
Apr 11 2018 21:21
I don't think it would run 60 times.
From a single ip
Vaibhav Rai
@RaiVaibhav
Apr 11 2018 21:22
what you can do is if GH_TOKEN is not set in the environment that then simply run it, if it's set import it without telling the user

From a single ip

I have exceeded 5000/hr many times :stuck_out_tongue:

A simple script and anyone can prove you wrong, lol
sorry
Ankit Joshi
@MacBox7
Apr 11 2018 21:24
@RaiVaibhav I had a discussion with @jayvdb about environment variables and he said a clear no. Let's hear what other reviers have to say regarding this matter. Anyways, thanks for the help.
Vaibhav Rai
@RaiVaibhav
Apr 11 2018 21:27
Then no other way :stuck_out_tongue_winking_eye: follow him, he is expert in security, it may happen that some how environment variables can cause the security problem or say security breach
Ankit Joshi
@MacBox7
Apr 11 2018 21:28
Ok :sweat_smile:
John Vandenberg
@jayvdb
Apr 11 2018 23:17
using environment variables for settings would need to be a coala core enhancement, and it would be very slow as lots of considerations, including security implications