These are chat archives for coala/coala-bears

5th
May 2018
Harsh Kumar Bhartiya
@harshhx17
May 05 2018 05:02
This file doesnot give an error with PEP8NotebookBear for line length greater than 79
 "cells": [
  {
   "cell_type": "code",
   "execution_count": 1,
   "metadata": {
    "collapsed": true
   },
   "outputs": [],
   "source": [
    "x = 'goodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgoodgood'"
   ]
  },
  {
   "cell_type": "markdown",
   "metadata": {},
   "source": [
    "a markdown cell is not a code cell"
   ]
  }
 ],
 "metadata": {},
 "nbformat": 4,
 "nbformat_minor": 0
}
Which I think it should
Should I create an issue about it
Need this to be fixed before solving coala/coala-bears#2443
John Vandenberg
@jayvdb
May 05 2018 05:32
try a long line which isnt a long string literal
I think even adding whitespace inside the string literal will make it error
Harsh Kumar Bhartiya
@harshhx17
May 05 2018 05:33
trying
Didn't work :disappointed:
John Vandenberg
@jayvdb
May 05 2018 05:45
ok, then create an issue
Viresh Gupta
@virresh
May 05 2018 07:02

@jayvdb
For the HgBear, since we are using the same SUPPORTED_HOST_REGEX for HgCommitBear and GitCommitBear, should I also add support for bitbucket in GitCommitBear in the same PR or make a different issue for that and solve that first ? (with reference to this)

(Since in any case we need bitbucket as a hoster for HgBear)

(Or another thing that can be done is to keep those two separately in GitCommitBear and HgCommitBear but probably not that elegant solution)

Vaibhav Rai
@RaiVaibhav
May 05 2018 07:04
Already issue opened related to max_line_length and it's our fault there a issue opened on their repo
*not
coala/coala-bears#2461
Harsh Kumar Bhartiya
@harshhx17
May 05 2018 10:10
Oh
John Vandenberg
@jayvdb
May 05 2018 10:29
@virresh , I guess you can just solve coala/coala-bears#1134 very easily now , adding BitBucket for git , and then in your HgCommitBear commit you shouldnt need to do anything extra for BitBucket for hg, as the patterns are the same
Viresh Gupta
@virresh
May 05 2018 10:48
@jayvdb
Does that issue require us to check the url using internet and see if the issue is open ?
John Vandenberg
@jayvdb
May 05 2018 10:53
no, that is coala/coala-bears#2369
Viresh Gupta
@virresh
May 05 2018 10:54

Oh
Cool
I think I get it now

Please assign me that one, I will try to get that done tonight :sweat_smile:

John Vandenberg
@jayvdb
May 05 2018 10:54
coala/coala-bears#1134 should probably be called "Support local repo issue numerical reference only"
or simply "Support BitBucket's very limited references"