These are chat archives for coala/coala-bears

9th
May 2018
Vaibhav Rai
@RaiVaibhav
May 09 2018 12:24
Error on unrelated change https://bpaste.net/show/6a6e8a1898b2
please verify and open a issue regarding that
@RaiVaibhav , if you have an error like that on CI, create an issue. The problem exists. You have evidence. Now is the time to document and investigate before some other variable changes
@virresh , you have some issues to create
Viresh Gupta
@virresh
May 09 2018 12:49

Yep

Got it
Will try writing instructions on reproducing this and file an issue :)

This one filed coala/coala#5451

I think one more to make for GitCommitBear for the WIP check
Let me know if I missed another one :sweat_smile:

John Vandenberg
@jayvdb
May 09 2018 13:00
yea the WIP one.
Viresh Gupta
@virresh
May 09 2018 13:01
Thanks
Will make it right away : )
John Vandenberg
@jayvdb
May 09 2018 13:01
and then I think there are a few issues to be raised about improving the tests; things you've fixed in Hg's tests
Boxuan Li
@li-boxuan
May 09 2018 13:35
Does anyone have interests to fix some linter bears? I'm pretty sure some bears will fail existing tests after next release, because they are reporting 0 row/column number, which would lead to an exception in the next release.
It could be a very simple one line fix like this one https://github.com/coala/coala-bears/pull/2413/files, but investigation consumes a lot of time as many linters don't have clear documentaion.
If anyone is using git version of coala, his pytest on coala-bears will definitely fail now (actually since many days ago)
John Vandenberg
@jayvdb
May 09 2018 13:37
we'll do a pre-release of coala once coala-utils and package-manager are released, and then coala-bears will break ;-)
Boxuan Li
@li-boxuan
May 09 2018 13:39
Oh yep, the pre-release of coala will make coala-bears break
John Vandenberg
@jayvdb
May 09 2018 19:48
Viresh Gupta
@virresh
May 09 2018 19:50
Ah
Missed it
John Vandenberg
@jayvdb
May 09 2018 19:54
@yukiisbored coala/coala-bears#2472
Viresh Gupta
@virresh
May 09 2018 20:22

@virresh , could you reply at https://github.com/coala/coala-bears/pull/2310#discussion_r187024240

Done :)

Also wrt to this, gitmate did indeed fail to show the patch, or maybe we saw it that way because github rendered the markdown instead of just letting that be ?
I am a little confused about the contents of the issue to file in :sweat_smile:

Also will get back to the other cEP comments today sometime around noon

virresh @virresh goes to sleep ;)
John Vandenberg
@jayvdb
May 09 2018 20:24
Viresh Gupta
@virresh
May 09 2018 20:24
Thanks a lot :D
John Vandenberg
@jayvdb
May 09 2018 20:25
or we need better comments somewhere in all of that
but for now, merged!
sleep well.
@khanchi97 (unreleased) coala now supports hg.
next : coala/coala-bears#2473
John Vandenberg
@jayvdb
May 09 2018 20:30
probably should create issues for other git hosters
esp those supported by the library we are using
Manan Kalra
@manankalra
May 09 2018 20:42
I'm getting ImportError for giturlparse
while running pytest
John Vandenberg
@jayvdb
May 09 2018 20:44
wonderful isnt it
means you need to install the new dependencies