These are chat archives for coala/coala-bears

10th
May 2018
Viresh Gupta
@virresh
May 10 2018 02:36 UTC

replied https://github.com/coala/coala-bears/pull/2310#discussion_r187165065 ; pick it up tomorrow

Opened two issues I found from the discussions in the PR :sweat_smile:
coala/coala-bears#2476 and coala/coala-bears#2475

but for now, merged!
sleep well.

Thanks a lot John :smile:

John Vandenberg
@jayvdb
May 10 2018 03:34 UTC
create a user docs issues, blocked on the next release
and i think the dev docs have git commit hooks in them, so we can now add the same for hg commit hooks
Viresh Gupta
@virresh
May 10 2018 03:57 UTC

User docs are these right ?
And just to re-confirm, we want an issue to create a document similar to this for hg on the user docs?

I couldn't find the commit hook section on the dev-docs...

John Vandenberg
@jayvdb
May 10 2018 05:19 UTC
git grep hook? In docs and coala repos
Viresh Gupta
@virresh
May 10 2018 05:42 UTC
Um
okay, so do we have two documentations, hosted separately ?
(or the dev one is not hosted and would be hosted at the next release ?)
Mischa Krüger
@Makman2
May 10 2018 05:49 UTC
The user docs are on a separate repo yes
coala/documentation
The API docs are inside coala/coala itself
Viresh Gupta
@virresh
May 10 2018 05:49 UTC
Ah
Thanks :)
Mischa Krüger
@Makman2
May 10 2018 05:51 UTC
That includes the actual API descriptions and some guides
;)
Viresh Gupta
@virresh
May 10 2018 05:55 UTC
@Makman2 , are these https://api.coala.io/en/latest/ hosted from coala/coala repository ?
(Sorry for silly questions, but I couldn't find the related rst files in coala/documentation )
Mischa Krüger
@Makman2
May 10 2018 05:56 UTC
Yes :)
docs.coala.io is from the separate documentation repo ;)
Viresh Gupta
@virresh
May 10 2018 05:56 UTC
Ah
Thanks a lot :smile:
Makman2 @Makman2 flight is departing, cya
Viresh Gupta
@virresh
May 10 2018 06:00 UTC
Happy journey :D
Tobias Paepke
@paepke
May 10 2018 07:37 UTC
@Makman2 thanks for the hint. I'll dig deeper.
Mischa Krüger
@Makman2
May 10 2018 09:44 UTC
:+1: :)
Manan Kalra
@manankalra
May 10 2018 09:44 UTC

@jayvdb coala/coala-bears#2335 passed

@manankalra try disabling a different go linter
One we dont support by an existing bear.

this did the trick, but I'm checking for golint here, which we already support
it doesn't pass with gotype however

John Vandenberg
@jayvdb
May 10 2018 09:59 UTC
Good. Crazy but good
John Vandenberg
@jayvdb
May 10 2018 13:35 UTC

@jayvdb coala/coala-bears#2335 passed

reviewed.

John Vandenberg
@jayvdb
May 10 2018 14:55 UTC
re-read my comment
Manan Kalra
@manankalra
May 10 2018 14:58 UTC
@jayvdb I'm already using gometalinter_config_file as a setting name.
Oh, do you mean to use the same name for both the functionalities?
John Vandenberg
@jayvdb
May 10 2018 14:59 UTC
bingo
Manan Kalra
@manankalra
May 10 2018 15:00 UTC
:+1: :+1: