These are chat archives for coala/coala-bears

20th
May 2018
John Vandenberg
@jayvdb
May 20 2018 09:38 UTC
@virresh one comment on the review
Viresh Gupta
@virresh
May 20 2018 10:34 UTC
Updated
John Vandenberg
@jayvdb
May 20 2018 11:10 UTC
Another question. Why do we have a .jj2 for the .cmd ?
Not a problem if we need it. Just curious
Viresh Gupta
@virresh
May 20 2018 11:37 UTC

I just separated the templates and include files
Like the folder name Templates prompted me to keep all files inside it as jj2 files
And we already had coala-mobans/templates on the moban's template_dir, so I just used a jj2 instead of adding assets to the path as well :sweat_smile:

We don't need it, we can simply add assets to the template_dir in .moban.yml and it will run the same, or just keep .cmd inside templates
Not sure which one would be better

John Vandenberg
@jayvdb
May 20 2018 11:50 UTC
Ah ok. Replied. We dont need the .jj2 then
Viresh Gupta
@virresh
May 20 2018 11:53 UTC
Cool
Will remove the jj2 then :)
Viresh Gupta
@virresh
May 20 2018 11:58 UTC
Updated
John Vandenberg
@jayvdb
May 20 2018 12:09 UTC
thx. merged
and IMO the implementation of new moban templates on the main repos is not a newcomer task. too complicated ;-) it is easier to do it ourselves to get it done quickly
Viresh Gupta
@virresh
May 20 2018 12:14 UTC
Right, now a synchronization pr for coala and one for bears 😅, apparently no one has claimed the issue on bears repo yet, should I send a PR for it then ?
John Vandenberg
@jayvdb
May 20 2018 12:32 UTC
Just send prs ;)
Ping me here when prs are green and ill review
But am at hackathon so may get distracted
Viresh Gupta
@virresh
May 20 2018 12:33 UTC

Oh
Happy hacking

Thx, will ping when ready

Viresh Gupta
@virresh
May 20 2018 14:15 UTC
Prs green:
coala/coala-bears#2495
and
coala/coala#5473
@jayvdb
John Vandenberg
@jayvdb
May 20 2018 14:22 UTC
Merged.
we need ppl to fix appveyor on our gitlab repos
@nemaniarjun ?
@anctartica ?
John Vandenberg
@jayvdb
May 20 2018 14:28 UTC
@ishanSrt ?
Ishan Srivastava
@ishanSrt
May 20 2018 14:28 UTC
Yes on it for quickstart
John Vandenberg
@jayvdb
May 20 2018 14:28 UTC
Thx
Also coala-utils
Ishan Srivastava
@ishanSrt
May 20 2018 14:31 UTC
Me? does it have anything to do with the mobans stuff?
John Vandenberg
@jayvdb
May 20 2018 14:32 UTC
Yes see above
Ishan Srivastava
@ishanSrt
May 20 2018 14:33 UTC
Then those may take a bit of time
John Vandenberg
@jayvdb
May 20 2018 14:33 UTC
Why?
Ishan Srivastava
@ishanSrt
May 20 2018 14:33 UTC
i don’t know what mobans is, atm
And got to take care of some issues with quickstart but will be on it 👍
Ishan Srivastava
@ishanSrt
May 20 2018 14:39 UTC
Will upgrading setuptools also break the build?
John Vandenberg
@jayvdb
May 20 2018 14:40 UTC
Which build?
Ishan Srivastava
@ishanSrt
May 20 2018 14:40 UTC
appveyor on coala-quickstart
John Vandenberg
@jayvdb
May 20 2018 14:42 UTC
I dont know. It should be ok
we find out..
Ishan Srivastava
@ishanSrt
May 20 2018 14:50 UTC

currently stuck at

The build phase is set to "MSBuild" mode (default), but no Visual Studio project or solution files were found in the root directory. If you are not building Visual Studio project switch build mode to "Script" and provide your custom build command.

on my fork

John Vandenberg
@jayvdb
May 20 2018 14:52 UTC
Msbuild should be disabled
Ishan Srivastava
@ishanSrt
May 20 2018 14:53 UTC
its the same config file from quickstart master
John Vandenberg
@jayvdb
May 20 2018 14:54 UTC
Have you tried using moban yet?
Ishan Srivastava
@ishanSrt
May 20 2018 14:54 UTC
no
John Vandenberg
@jayvdb
May 20 2018 14:55 UTC
why not?
Ishan Srivastava
@ishanSrt
May 20 2018 14:56 UTC
I didn’t fix any CI related issues before this
Kriti Rohilla
@kriti21
May 20 2018 14:58 UTC

@jayvdb Please help me with this

Regarding coala/coala-bears#1037 . I have made some changes in GitCommitBear locally https://pastebin.com/tZRTQ3GN
How to add tests for this change since these merge commits are automatically created by github?

John Vandenberg
@jayvdb
May 20 2018 15:00 UTC
they are just commits, you can create identical commits in tests
Kriti Rohilla
@kriti21
May 20 2018 15:02 UTC
Yes but how am I supposed to create a github merge commit
Especially one with multiple stacked PRs
that will interrupt with tests for other commits as well
John Vandenberg
@jayvdb
May 20 2018 15:04 UTC
it will not interrupt anything
The test runner will setup and teardown the test scenario
Kriti Rohilla
@kriti21
May 20 2018 15:09 UTC
Okay. Thanks