These are chat archives for coala/coala-bears

10th
Jun 2018
Boxuan Li
@li-boxuan
Jun 10 2018 02:07
@jayvdb @Makman2 What's the final decision for https://github.com/coala/coala-bears/pull/2517#issuecomment-395996860? Regarding package-lock.json
John Vandenberg
@jayvdb
Jun 10 2018 02:14
the benefit of it is that fork builds will have a set of dependencies that is more consistent with the main repos cache
the potential harm is if people think they should be updating it with micro releases JS dependencies, which is silly as this file isnt how our users get those dependencies
and will result in lots of churn for a mostly irrelevant file
John Vandenberg
@jayvdb
Jun 10 2018 02:19
im inclined to proceed with checking in package-lock.json , and seeing how it goes
Boxuan Li
@li-boxuan
Jun 10 2018 02:21
@KaplanAlex :point_up:
Alexander Kaplan
@KaplanAlex
Jun 10 2018 04:29
sounds good. Thanks for asking @li-boxuan
John Vandenberg
@jayvdb
Jun 10 2018 04:39

uncached bears is broken coala/coala-bears#2529

fixed in coala/coala-bears#2530

@kriti21 re coala/coala-bears#2527 , please test on your own travis fork - i.e. https://travis-ci.org/kriti21/coala-bears
Kriti Rohilla
@kriti21
Jun 10 2018 04:53
okay
Kriti Rohilla
@kriti21
Jun 10 2018 05:07
I used this PR to write tests for coala/coala-bears#2501 .
Is that not right ?
John Vandenberg
@jayvdb
Jun 10 2018 05:09
no
you should write tests on your local machine
Satwik Kansal
@satwikkansal
Jun 10 2018 17:30
suggestions desired for coala/coala-bears#2532