These are chat archives for coala/coala-bears

3rd
Jul 2018
John Vandenberg
@jayvdb
Jul 03 2018 01:47
@yukiisbored @anctartica ^
O
Guangyuan (Charlie) Yang
@yzgyyang
Jul 03 2018 02:00
how do you like something like https://gitlab.com/coala/package_manager/merge_requests/133 for the actual installation?
John Vandenberg
@jayvdb
Jul 03 2018 02:12
Classes should
never do stuff in init
It is for initialisation
It should
be as cheap as possible
Doing stuff means class instances cant be created to be inspected, which is the first level of non-passive static analysis
Guangyuan (Charlie) Yang
@yzgyyang
Jul 03 2018 02:30
I get it, and this is definitely not intended to be merged as-is. I am just wondering, should package_manager handles the installation (actually triggers install_package()), or it should just provide methods?
Guangyuan (Charlie) Yang
@yzgyyang
Jul 03 2018 02:36
If latter, do we ensure dependencies in bear init?
John Vandenberg
@jayvdb
Jul 03 2018 02:38
Yes. There is a hook for that
search bears for setup
and we need it to be recursive. See sils patch in package_manager
It needs to be merged , or your project fails :P
Guangyuan (Charlie) Yang
@yzgyyang
Jul 03 2018 02:43
Is it check_prerequisites() or setup_dependencies() in some of the bears?
@jayvdb where is the sils patch you talked about :|
John Vandenberg
@jayvdb
Jul 03 2018 03:21
... in package_manager
saksham189
@saksham189
Jul 03 2018 06:25

and we need it to be recursive. See sils patch in package_manager
It needs to be merged , or your project fails :P

are there any more changes to be made to that? I think we can merge it as is

John Vandenberg
@jayvdb
Jul 03 2018 06:59
need to convince @sils to rebase it ;-)
did it have 100% test coverage ?
saksham189
@saksham189
Jul 03 2018 07:20
yes it does
John Vandenberg
@jayvdb
Jul 03 2018 09:00
coala-bears is green again; rebase any PRs that need to be reviewed
John Vandenberg
@jayvdb
Jul 03 2018 09:44
@li-boxuan ^
really curious to see how many errors your PR fixes, and what remaining problems there are
Boxuan Li
@li-boxuan
Jul 03 2018 09:48
which PR? You mean the pylint one?
John Vandenberg
@jayvdb
Jul 03 2018 09:48
yup
need to make sure that approach works on pylint at least, and then try the same on the other two bears
Boxuan Li
@li-boxuan
Jul 03 2018 09:51
Oh okay. Hmm, Is there anything I should do other than investigating other two bears?
John Vandenberg
@jayvdb
Jul 03 2018 09:52
@nemaniarjun , please get coala/coala-bears#2446 tidied up while the tree is still green
John Vandenberg
@jayvdb
Jul 03 2018 16:18
@kriti21 , you may want to turn off your Circle CI while we try to get the first patch merged , or try rebuilding your Circle CI a few times
Kriti Rohilla
@kriti21
Jul 03 2018 16:18
okay . Turning it off
John Vandenberg
@jayvdb
Jul 03 2018 16:26
coala/coala-bears#2570 - another bug preventing using coala master in coala-bears
John Vandenberg
@jayvdb
Jul 03 2018 17:19
@kriti21 congrats on getting one merged.
here is a nice easy one coala/coala-bears#2575
Kriti Rohilla
@kriti21
Jul 03 2018 17:20
Thanks :)
John Vandenberg
@jayvdb
Jul 03 2018 18:00
@sangamcse, you might like to do coala/coala-bears#2564 , related to the object comparable work
it is a problem caused by the error messages that are now generated by coala-core master for Result objects which are not identical
Sangam Kumar
@sangamcse
Jul 03 2018 18:06
Ah ok, I will check it later today.