These are chat archives for coala/coala-bears

5th
Jul 2018
John Vandenberg
@jayvdb
Jul 05 2018 03:45
Because a line number isnt appropriate if the error is linked to a file , not linked to any particular line
And checkstyle line 0 implies the line number either the error is about the file, or the line number cant be trusted as it violates their standard
This could be a general solution for any line number 0 . Instead of an error, emit a warning and strip the line number. At least then the user sees the linter error, and also sees the fact that the linter reported a bad line number. But the error isnt incorrectly pinned to an irrelevant line because we stripped the line number
John Vandenberg
@jayvdb
Jul 05 2018 03:50
The reason against that is that bear writers and reviewers might not see the warning.
I believe there is a pytest plugin which converts any logging warning to be an error
But that plugin would not be usable for us as we have way too many unexpected warnings in our tests
John Vandenberg
@jayvdb
Jul 05 2018 06:19
Need to get these fixed real fast, or revert the coalib change which caused it
We have issues about all errors i believe
Boxuan Li
@li-boxuan
Jul 05 2018 06:26
Not sure how to fix checkstyle issue. If it requires another linter parameter, then need changes on coala repo first…?
John Vandenberg
@jayvdb
Jul 05 2018 06:44
Yes
And reporting all problems upstream
John Vandenberg
@jayvdb
Jul 05 2018 07:01
@refeed keeps finding bugs in filename bear ;) coala/coala-bears#2579
Assigned coala/coala-bears#2564 to @refeed
Boxuan Li
@li-boxuan
Jul 05 2018 07:03
The end of GSoC second coding phase is approaching, I am scary :worried:
Would someone else take the CheckStyleBear issue?
John Vandenberg
@jayvdb
Jul 05 2018 07:05
You know the problem better than anyone
Ill focus on your gsoc project prs this arvo
Kriti Rohilla
@kriti21
Jul 05 2018 07:07
Review request coala/coala-bears#2543 @jayvdb
John Vandenberg
@jayvdb
Jul 05 2018 07:08
Not today. bears is effectively broken atm
Kriti Rohilla
@kriti21
Jul 05 2018 07:08
okay
John Vandenberg
@jayvdb
Jul 05 2018 07:09
Aspects project can not create prs because of this
Vaibhav Rai
@RaiVaibhav
Jul 05 2018 07:49
was trying to update the PySafetyBear to prevent the breakage of appveyor CI for 3.7 job but they remove the cve-key from there code instead they uses the vuln_id which I don't like it as if I want to know about the vulnerability more then I first have go to the json data to get its cve value then I will google that for further reading.
John Vandenberg
@jayvdb
Jul 05 2018 07:50
ok thx for heads up. we absolutely need to be supporting 3.7 in the next release
Vaibhav Rai
@RaiVaibhav
Jul 05 2018 07:54
:+1:
Boxuan Li
@li-boxuan
Jul 05 2018 14:08
@jayvdb Please take a look at my comment https://github.com/coala/coala/issues/5600#issuecomment-402734081 regarding 0 line/column number
John Vandenberg
@jayvdb
Jul 05 2018 15:22
Only checkstyle bear and ClangComplexityBear tests failing now