These are chat archives for coala/coala-bears

7th
Jul 2018
John Vandenberg
@jayvdb
Jul 07 2018 00:49
@refeed, do you know what is happening with the IndentationBear errors at https://travis-ci.org/coala/coala-bears/jobs/400943111#L4571 ?
im worried that there was some problem in recently merged coala/coala#5595
John Vandenberg
@jayvdb
Jul 07 2018 02:52
@li-boxuan , when it passes the relevant tests, ping me, ill check, then remove the 'use coalib master' commit and rebuild.
Boxuan Li
@li-boxuan
Jul 07 2018 02:53
okay
John Vandenberg
@jayvdb
Jul 07 2018 02:53
we also need to check your build for this IndentationBear error that appears in refeed's log. if it occurs in your one too, ill need to panick
circileCI fails for some reason I don't know
John Vandenberg
@jayvdb
Jul 07 2018 03:34
oh how I love magically appearing failures
let me verify that all offset problems are fixed, so we can get your PR merged
ive verified it on your previous build. will wait for current build to finish.
John Vandenberg
@jayvdb
Jul 07 2018 03:48
@li-boxuan , all good. remove the 'use coalib master' commit and rebuild. I'm hoping that circle ci will pass, but probably will merge even if not
circle ci is optional as @kriti21 has fixed GitCommitBear so it works on Travis
Boxuan Li
@li-boxuan
Jul 07 2018 07:01
@jayvdb Build done. coala/coala-bears#2413 circle ci doesn't pass.
John Vandenberg
@jayvdb
Jul 07 2018 07:16
travis didnt pass ;-(
oh , of course ... the new Linter args are now missing.
oh well, the Indentation problem is now a blocker that needs to be investigated. If nobody beats me, I'll sort that out tonight
Boxuan Li
@li-boxuan
Jul 07 2018 07:52
:+1:
MajAK
@kUSHAL0601
Jul 07 2018 09:02
@RaiVaibhav here is the travis-ci build link
John Vandenberg
@jayvdb
Jul 07 2018 10:42
@pareksha , i suspect your merged comment delimiters patch is the cause of the new failures. It probably doesnt support languages without any conment delimiter. Please investigate. Also coala/coala-bears#2587 is broken
Sangam Kumar
@sangamcse
Jul 07 2018 11:04
I am getting tons of comment delimiters warnings in coala and coala-bears repo
[WARNING][16:32:30] The property `comment_delimiter` of Language module is deprecated and will be removed soon. Please use `comment_delimiters` which returns a tuple containing all the comment delimiters supported by the language.
John Vandenberg
@jayvdb
Jul 07 2018 11:09
yup; that should have been temporary, as we move towards using coala master
but we hit a snag; see above
Sangam Kumar
@sangamcse
Jul 07 2018 11:11
Yes, I was going through that
Also, coala/coala#5564 changes are done. Need your review @jayvdb
John Vandenberg
@jayvdb
Jul 07 2018 11:13
nod. it is in the queue. afraid that isnt a priority atm
getting coalib working on master has been the focus. and getting py37 working. etc
Pareksha Manchanda
@pareksha
Jul 07 2018 14:54

@pareksha , i suspect your merged comment delimiters patch is the cause of the new failures. It probably doesnt support languages without any conment delimiter. Please investigate.

@jayvdb, I've looked into it and I've found that it works. It gives AttributeError as is required when the user asks for an attribute that is not present in the language

John Vandenberg
@jayvdb
Jul 07 2018 14:56
Hmm..
Pareksha Manchanda
@pareksha
Jul 07 2018 14:56
Can you send the link of the ci which is failing so that I can see if I am missing something
John Vandenberg
@jayvdb
Jul 07 2018 14:56
See message to @refeed above
and messages by @li-boxuan
and now TextLintBearTest.test_bad_alex_no_dead_link is failing on your PR .. :/
John Vandenberg
@jayvdb
Jul 07 2018 15:02
lets see if circle passes
John Vandenberg
@jayvdb
Jul 07 2018 15:08
http://httpstat.us/404 = Service Unavailable - i guess that is it
John Vandenberg
@jayvdb
Jul 07 2018 15:15
who wants to do coala/coala-bears#2588 ?
Pareksha Manchanda
@pareksha
Jul 07 2018 15:16

http://httpstat.us/404 = Service Unavailable - i guess that is it

There's timeout with this, that is why error is there

Pareksha Manchanda
@pareksha
Jul 07 2018 15:23
Now I am getting Service Unavailable
Pareksha Manchanda
@pareksha
Jul 07 2018 15:33
@jayvdb http://httpbin.org/status/404 is saying Service currently unavailable
John Vandenberg
@jayvdb
Jul 07 2018 16:06
not for me. it replies with 404 as expected
Pareksha Manchanda
@pareksha
Jul 07 2018 16:15
it's different for me, I guess and now http://httpstat.us/404 is saying 404 for me
It might be a temporary bug in there
Will you give it a look once?
Vaibhav Rai
@RaiVaibhav
Jul 07 2018 16:17
Screenshot from 2018-07-07 21-46-50.png
Pareksha Manchanda
@pareksha
Jul 07 2018 16:18
Let's do with http://httpbin.org/status/404 then, I'll make the PR
Vaibhav Rai
@RaiVaibhav
Jul 07 2018 16:18
http://httpstat.us/404 is working fine
Sangam Kumar
@sangamcse
Jul 07 2018 16:18
For http://httpbin.org/status/404, It says "503 | The deployment is currently unavailable."
Pareksha Manchanda
@pareksha
Jul 07 2018 16:18

For http://httpbin.org/status/404, It says "503 | The deployment is currently unavailable."

I am getting the same

http://httpstat.us/404 is working fine

:+1:

Sangam Kumar
@sangamcse
Jul 07 2018 16:19
Yeah, http://httpstat.us/404 is fine
Pareksha Manchanda
@pareksha
Jul 07 2018 16:20
I'll rebase and push again to see if tests pass
John Vandenberg
@jayvdb
Jul 07 2018 16:44
maybe it was a temporary failure
Pareksha Manchanda
@pareksha
Jul 07 2018 16:45

@pareksha , i suspect your merged comment delimiters patch is the cause of the new failures.

I think I got it. The problem is caused by https://github.com/coala/coala-bears/blob/570b7dadd45e2b6f90bf5300f11bc3fa419ea78f/tests/general/IndentationBearTest.py#L17. It should be comment_delimiters instead as it's already a tuple

John Vandenberg
@jayvdb
Jul 07 2018 16:47
omg .. yes .. that was assuming it allowed multiple :/
Pareksha Manchanda
@pareksha
Jul 07 2018 16:49
All tests green here coala/coala-bears#2587. Yippie

omg .. yes .. that was assuming it allowed multiple :/

I'll create an issue and make the PR now itself

John Vandenberg
@jayvdb
Jul 07 2018 16:53
definitely create the issue. but i'll create a PR which pushes all of the outstanding problems together
Pareksha Manchanda
@pareksha
Jul 07 2018 16:56
Okay :+1:
Pareksha Manchanda
@pareksha
Jul 07 2018 17:02
I've created the issue here coala/coala-bears#2589