These are chat archives for coala/coala-bears

10th
Jul 2018
Kriti Rohilla
@kriti21
Jul 10 2018 14:00
Travis build green in coala/projects#600 . @jayvdb Please review
Also coala/coala-bears#2543 was approved by my mentor around a week before. I have rebased it with the current changes. This one blocks other PRs that I have to make. Please review.
John Vandenberg
@jayvdb
Jul 10 2018 14:28
@kriti21 coala/projects#593 sets up multiple jobs in .travis.yml ; if we merge that, your PR becomes a bit easier
and it uses the newer jobs instead of matrix
Kriti Rohilla
@kriti21
Jul 10 2018 14:29
okay :+1:
Kriti Rohilla
@kriti21
Jul 10 2018 15:51
btw.. Can I make this change in other repos like coala-quickstart , docker-coala-base etc ? Because I am guessing they will need some updates too. @jayvdb
John Vandenberg
@jayvdb
Jul 10 2018 16:11
docker-coala-base is broken beyond repair atm.
coala-quickstart is not just using coala for ci -- it depends on coala, so that is a bit more complicated
corobo is probably the next target
but while gitmate is spewing out lots of errors, creating PRs isnt helpful
Kriti Rohilla
@kriti21
Jul 10 2018 16:13
ok.
John Vandenberg
@jayvdb
Jul 10 2018 16:17
coala/coala-quickstart#226 - this is a pre-req for getting coala-bears master onto coala-quickstart - just pushed; gitmate still going nuts
MajAK
@kUSHAL0601
Jul 10 2018 23:28
Can someone please merge this coala/coala-bears#2603
John Vandenberg
@jayvdb
Jul 10 2018 23:45
@kUSHAL0601 it says "from unknown repository" - you must have deleted your repository
our newcomer/git guide says to never do that
MajAK
@kUSHAL0601
Jul 10 2018 23:47
Yeah... so do I make a PR again ?
John Vandenberg
@jayvdb
Jul 10 2018 23:47
no, you've already done two :-(
MajAK
@kUSHAL0601
Jul 10 2018 23:48
So what should I be doing ?
John Vandenberg
@jayvdb
Jul 10 2018 23:48
if you delete your repo or close a PR again, you'll be removed from coala org
you should have just waited, and follow our guides
MajAK
@kUSHAL0601
Jul 10 2018 23:49
Actually it was failing on travis-ci from a long time. Anyways I will keep it in mind !
John Vandenberg
@jayvdb
Jul 10 2018 23:50
it had been approved by me. dont close PRs that a maintainer has approved
MajAK
@kUSHAL0601
Jul 10 2018 23:51
Alright thanks for your help
John Vandenberg
@jayvdb
Jul 10 2018 23:51
gah, it is going to fail now because it isnt rebased
MajAK
@kUSHAL0601
Jul 10 2018 23:53
Sorry for the consequences!