These are chat archives for coala/coala-bears

22nd
Jul 2018
John Vandenberg
@jayvdb
Jul 22 2018 03:17
if we can get in coala/coala-bears#2631 , I can push in coala/coala-bears#1429 or nudge the contributor to finish it
@ishanSrt needed for coala-quickstart to not crash on any reasonably sized project
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 04:02
@jayvdb Wating for your review :P
coala/coala-bears#2626
John Vandenberg
@jayvdb
Jul 22 2018 04:20
done
getting close now
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 04:40

John you comment is little bit confusing to me as I didn't find any function name
get_database_file in safety module and you said

The hack should be in setup_dependencies .

Do you want me to hack each key cve of each package in setup_dependencies instead of doing in get_vulnerabilities

John Vandenberg
@jayvdb
Jul 22 2018 04:41
should have been fetch_database_file
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 04:48

Can you explain little bit here

add the cve in a hack of get_database_file instead of a hack of get_vulnerabilities.

Because I am not able to relate as json file already have cve key for some of the packages and for some of them its null and fetch_database_file work is only to read the json file

John Vandenberg
@jayvdb
Jul 22 2018 04:50
you are hacking the data structure of a entry. hack it in fetch_database_file, not in get_vulnerabilities.
also added another review comment
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 04:53
Seen :+1:
let suppose I am passing 3 packages on which I need check so to do same hack I will will either rely on get_vulnerabilites as it is yielding data for each package entry in data base or second is to iterate through all the json file and perform hack and further safety will call get_vulnerabilities and further processing happens
second one is what you are saying do hack in fetch_database_file
John Vandenberg
@jayvdb
Jul 22 2018 04:59
ive added alternative on PR
no time to discuss further
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 05:00
:+1:
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 06:34
Can you review coala/coala-bears#2626
don't know why it become platform dependent made changes after your review, build in appyevor failed and passsed on Travis so I restarted it but same result
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 06:40
how to check on CI whether it cache the files of setup_dependencies?
saksham189
@saksham189
Jul 22 2018 07:35
coala/coala-bears#2230 build passing
John Vandenberg
@jayvdb
Jul 22 2018 07:50
@RaiVaibhav eh? Travis is failing
@anctartica , is there any way to add these extra rulesets to ESLint bear instead of JSStandard bear ?
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 07:52
yeah seen now same error on travis for python3.6 (passing locally on 3.6.5) but on appveyor the two jobs are on 3.4 and 3.5 and they failed and on travis 3.4 and 3.5 they passed means somehow it become platform dependent but don't know how
John Vandenberg
@jayvdb
Jul 22 2018 07:52
probably cache dependant
read the logs
@anctartica it feels a bit strange adding these features to 'JSStandardBear' ;-)
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 07:54
yeah but don't know why last time all the CI passed, I am also using os.path.dirname
John Vandenberg
@jayvdb
Jul 22 2018 07:54
at least markdown and html
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 07:54

read the logs

How to get log of cache file?

John Vandenberg
@jayvdb
Jul 22 2018 07:55
you read the log to see which parts of install were cached and which were not
oh , it is JS in markdown and JS in HTML. hmm .. ok .. it is coming back to me now
saksham189
@saksham189
Jul 22 2018 08:02
yes we could be adding the same settings for eslintbear but we also need them for JSStandardBear since standard is a set of eslint rules therefore requiring no configuration files
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 08:27
@jayvdb both insecure.json and insecure_full.json is needed and thats how safety run :sweat_smile:
Intially it store all the keys from insecure.json and after that iterate through all the keys and performs logic i.e., check package provided by user then fetch further information of key or package from insecure_full.json and then yield a Vulnerability tuple
I am hoping this time all the CI pass :/
John Vandenberg
@jayvdb
Jul 22 2018 08:52
@anctartica , you're not going to like my review .. ;-)
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 09:46
@jayvdb some problem occurred in coala-bears repo on appveyor
IMO it because pip version 18 is getting installed instead of 10
Ankit Joshi
@MacBox7
Jul 22 2018 09:47
Yeh. Happened with me too.
On gitlab.
Mor Elmaliach
@MorTD
Jul 22 2018 09:48
How do I update my PR with the new commit I made?
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 09:49
squash both the commit
and force push
Mor Elmaliach
@MorTD
Jul 22 2018 09:49
what do you mean?
as squash
Mor Elmaliach
@MorTD
Jul 22 2018 09:50
thank you
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 09:51
git have one advance feature git rebase -i( interactive rebase) [ Don't know whether mercurial have this or not :P]
Ankit Joshi
@MacBox7
Jul 22 2018 09:52
get_installed_distributions has been removed from pip. We need to pin pip. Wasn't this done before?
John Vandenberg
@jayvdb
Jul 22 2018 10:07
Yes it is pinned
You need to install test-requirements first
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 10:08
it failing on appveyor
on every PR
@MorTD use git rebase -i HEAD~5
after that read the instructions which git will give you.
you already made 5 commit in same PR
John check this, this is definitely because of new release
Ankit Joshi
@MacBox7
Jul 22 2018 10:15
Need to change test-requirements.txt from pip!=9.0.2, !=10.0.* to pip!=9.0.2, !=10.0.*, !=18.0.
But I think we should think for a more concrete solution.
John Vandenberg
@jayvdb
Jul 22 2018 10:15
Ah yes
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 10:19
from pip import get_installed_distributions changed to
from pip._internal.utils.misc import get_installed_distributions
@MacBox7 opening a PR?
Ankit Joshi
@MacBox7
Jul 22 2018 10:21
It's an upstream issue. pytest itself isn't working with pip18
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 10:22
:+1: I was in hurry because of PySafetyBear :sweat_smile:
Ankit Joshi
@MacBox7
Jul 22 2018 10:22

from pip import get_installed_distributions changed to
from pip._internal.utils.misc import get_installed_distributions

Where are you proposing this change?

Vaibhav Rai
@RaiVaibhav
Jul 22 2018 10:22
No it was just a information
Ankit Joshi
@MacBox7
Jul 22 2018 10:23

Need to change test-requirements.txt from pip!=9.0.2, !=10.0.* to pip!=9.0.2, !=10.0.*, !=18.0.

@jayvdb should I create a PR in moban for this?

Vaibhav Rai
@RaiVaibhav
Jul 22 2018 10:24
yeah I was talking about your above message i.e., change in moban
Ankit Joshi
@MacBox7
Jul 22 2018 10:25
Let the reply come. Would make it.
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 10:32
Issue reported 12 days ago di/pytest-reqs#17
John Vandenberg
@jayvdb
Jul 22 2018 10:51
@MacBox7 yes
Ankit Joshi
@MacBox7
Jul 22 2018 11:01
Created a PR in moban. Creating a PR for coala-bears to fix it.
John Vandenberg
@jayvdb
Jul 22 2018 11:07
Moban merged
Need prs everywhere
No issues, just coordinate here who is doing which ones
Ankit Joshi
@MacBox7
Jul 22 2018 11:08
I am creating for bears.
John Vandenberg
@jayvdb
Jul 22 2018 11:09
:+1:
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 11:12
@MacBox7 create everywhere :+1: :)
Ankit Joshi
@MacBox7
Jul 22 2018 11:13

@MacBox7 create everywhere :+1: :)

Err. I'll be going afk after bears. Got to run some errands.

Wouldn't have mind otherwise.
John Vandenberg
@jayvdb
Jul 22 2018 11:15
@ishanSrt ^
@yzgyyang ^
@pareksha you want to update pyprint?
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 11:17
Ankit coala run failed on bears
John Vandenberg
@jayvdb
Jul 22 2018 11:18
coala-utils someone
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 11:18
Test passes :)
John Vandenberg
@jayvdb
Jul 22 2018 11:19
We may need to do repos in order : libraries first and up the stack
We havent had a failure like this when using master everywhere. we get to learn how it works
Im on mobile only for a few hours. out for dinner
Ankit Joshi
@MacBox7
Jul 22 2018 11:21
Gemfile.jj2 failed in coala run. Odd.
Ankit Joshi
@MacBox7
Jul 22 2018 11:30
@anctartica should I close my PR? You could do the complete sync.
Or let your PR get merge. I'll rebase on top of it.
saksham189
@saksham189
Jul 22 2018 11:34
no I believe @jayvdb wanted this to get merged first coala/coala-bears#2612
John Vandenberg
@jayvdb
Jul 22 2018 11:34
doesnt matter which one
They are the same. And all generated
saksham189
@saksham189
Jul 22 2018 11:36
then i can close mine since it doesn't have all the changes rn
John Vandenberg
@jayvdb
Jul 22 2018 11:38
no closing prs :P
saksham189
@saksham189
Jul 22 2018 11:39
can you merge coala/coala-bears#2620 and then @MacBox7 can rebase on top of it
Ankit Joshi
@MacBox7
Jul 22 2018 11:40
Yup. That would be good.
@MorTD run coala locally before pushing.
Ankit Joshi
@MacBox7
Jul 22 2018 11:45
@anctartica ur tests won't pass until my PR gets merged. 😅
You should re sync moban.
John Vandenberg
@jayvdb
Jul 22 2018 11:45
We only need one, and only one
Ankit Joshi
@MacBox7
Jul 22 2018 11:46
Moban has been updated.
saksham189
@saksham189
Jul 22 2018 11:47
but then ur PR won't be needed @MacBox7
John Vandenberg
@jayvdb
Jul 22 2018 11:48
Doesnt matter whose pr wins
Green wins
Ishan Srivastava
@ishanSrt
Jul 22 2018 11:53
put .moban.hashes in .gitignore
Ankit Joshi
@MacBox7
Jul 22 2018 11:53
Yeah. @anctartica not a problem.
@ishanSrt we can use .gitignore from moban.
Ishan Srivastava
@ishanSrt
Jul 22 2018 11:55
Yeah I meant is there an issue there for it?
John Vandenberg
@jayvdb
Jul 22 2018 11:57
.gitignore is a separate pr
Already waiting for review for weeks
Ankit Joshi
@MacBox7
Jul 22 2018 11:58
As far as I remember I did on one. Was it documentation?
John Vandenberg
@jayvdb
Jul 22 2018 11:59
Most repos are done
Bears isnt
Ankit Joshi
@MacBox7
Jul 22 2018 11:59
Okay.
John Vandenberg
@jayvdb
Jul 22 2018 11:59
this years gsic students are not good at watching the pr queue
@ishanSrt have you created pr for quickstart?
Ishan Srivastava
@ishanSrt
Jul 22 2018 12:01
Here it is coala/coala-quickstart#270
John Vandenberg
@jayvdb
Jul 22 2018 12:03
@ksdme need one for vs-code. Not -ls
@nvzard corobo ^
@sks444 community ^
Someone review my gedit pr and create a test-requirements moban patch on top of my pr
Same with sublime
Gitlab's webservices needs something
Im not sure if moban made it there yet
Ishan Srivastava
@ishanSrt
Jul 22 2018 12:15
is somebody working on some plugin to automatically create and merge moban sync PRs?
John Vandenberg
@jayvdb
Jul 22 2018 12:17
MobanBear + gitmate plugin next gsoc ;)
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 12:17
A type of Bear? which will run
John Vandenberg
@jayvdb
Jul 22 2018 12:17
moban and it provides patches
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 12:18
Cool :+1:
Pareksha Manchanda
@pareksha
Jul 22 2018 12:19

@pareksha you want to update pyprint?

I'll do it :+1:

Ishan Srivastava
@ishanSrt
Jul 22 2018 12:20

MobanBear + gitmate plugin

will it be big enough for a gsoc project?

Vaibhav Rai
@RaiVaibhav
Jul 22 2018 12:20
Sync MobanBear with gitmate will take time @ishanSrt and it can be IMO
John Vandenberg
@jayvdb
Jul 22 2018 12:23
automatic creation of PRs is a hard problem to do well
Needs to work well with humans who close prs created by bots, and who do other strange things
And needs to update existing open PR instead of create new dups
And should auto rebase prs by humans when mobans are uodated
Mor Elmaliach
@MorTD
Jul 22 2018 12:30
please PR #2624 :-)
Ishan Srivastava
@ishanSrt
Jul 22 2018 12:34
staticman is pretty fast, as soon as somebody comments on the GitHub.io site, it modifies a .md file which stores comments and merges to the GitHub.io.site in no time. If Gitmate is not a necessity, one could mimic what’s happenning over there.
the rebase problem will be only when someone creates a PR exactly in the time frame when something is merged in moban and by the time the plugin merges in the repo
of course it would need to bypass the checks
Ankit Joshi
@MacBox7
Jul 22 2018 12:35
@MorTD squash your commits and change the message.
Only 1 commit to do the changes
Do not close PR
Do not delete branch
Pareksha Manchanda
@pareksha
Jul 22 2018 12:48
Kilari Teja
@ksdme
Jul 22 2018 13:06
@jayvdb test-requirements.txt.jj2 does not cover the test requirements for coala-vs-code, should I submit a PR adding it first?
John Vandenberg
@jayvdb
Jul 22 2018 13:13
Check if master builds ok
Kilari Teja
@ksdme
Jul 22 2018 13:14
The master was out of sync even before this update.
John Vandenberg
@jayvdb
Jul 22 2018 13:14
sure. But does master build ok?
If not, a manual fix might be better for that repo
John Vandenberg
@jayvdb
Jul 22 2018 13:18
Ok leave it
Kilari Teja
@ksdme
Jul 22 2018 13:18
:thumbsup:
John Vandenberg
@jayvdb
Jul 22 2018 13:42
Is someone doing coala core?
Kilari Teja
@ksdme
Jul 22 2018 13:43
If no one is then I can take it up.
John Vandenberg
@jayvdb
Jul 22 2018 13:46
All yours
Kilari Teja
@ksdme
Jul 22 2018 13:47
:thumbsup:
John Vandenberg
@jayvdb
Jul 22 2018 13:48
And coala utils
Kilari Teja
@ksdme
Jul 22 2018 13:49
:thumbsup:
Kilari Teja
@ksdme
Jul 22 2018 14:14
PR (coala-core): coala/coala#5660, The build is failing I think because of https://github.com/coala/coala/blob/master/requirements.txt#L4.
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 14:20
Line 4 or line 6?
John Vandenberg
@jayvdb
Jul 22 2018 14:22
oh, you cant replace the pytest-reqs
That is purposely out of sync
Kilari Teja
@ksdme
Jul 22 2018 14:23
Oh, then maybe keep it that way but update the pip requirement?
John Vandenberg
@jayvdb
Jul 22 2018 14:23
Yup
Kilari Teja
@ksdme
Jul 22 2018 14:23
:thumbsup:
Vaibhav Rai
@RaiVaibhav
Jul 22 2018 14:45
@jayvdb build green coala/coala-bears#2626
Kilari Teja
@ksdme
Jul 22 2018 14:51
coala/coala#5660, Build is passing.
Nitanshu
@nvzard
Jul 22 2018 16:35
corobo moban sync coala/corobo#590
mpac
@mpac
Jul 22 2018 19:56
What's the best place to get a list of bears? I tried some links but the information was deprecated or the page wasn't there.
Kilari Teja
@ksdme
Jul 22 2018 19:58
Try https://github.com/coala/coala-bears/tree/master/bears, coala --show-bears and coala --help for more.
mpac
@mpac
Jul 22 2018 20:00
Thanks @ksdme!
Mor Elmaliach
@MorTD
Jul 22 2018 20:22
sorry for all the issues, I'm trying to make the commits squash... never used these features of git before
apologies, I will make sure it's merged into 1 message before asking to PR again
Ankit Joshi
@MacBox7
Jul 22 2018 20:56
Change the commit message too as requested.
Mor Elmaliach
@MorTD
Jul 22 2018 21:06
I hope I did not short fused the gitmate bot, but I think I managed to fix that.. if someone could take a looksee, it would be best and really appreciated. I learned from this alot, lol, and will work on #477 tomorrow if this is approved.
Kilari Teja
@ksdme
Jul 22 2018 21:09
URL?
Ankit Joshi
@MacBox7
Jul 22 2018 21:18
@MorTD nice you squashed the commits. Now fix the errors displayed by gitmate. They are just simple changes so that your code adheres to coding standard.
After making changes type git commit --amend
And change you commit message. Then do a force push.
Mor Elmaliach
@MorTD
Jul 22 2018 21:21
I will do, thank you @MacBox7