These are chat archives for coala/coala-bears

29th
Jul 2018
John Vandenberg
@jayvdb
Jul 29 2018 05:33 UTC
@MacBox7 , can you review coala/coala-bears#2646
if ok, ill merge it, then use gitmate to rebase the newcomer PR and merge it
(it is already not rebased, but they have learnt comment amending, so that is enough for now)
@kriti21 @refeed ^ . I've cancelled the travis build on the merge inspect bear, so above can happen quicker
im reviewing it now.
Kriti Rohilla
@kriti21
Jul 29 2018 05:40 UTC
ok
I have updated coala/coala-bears#2523 also . Can I push the changes ?
John Vandenberg
@jayvdb
Jul 29 2018 05:43 UTC
not yet ... need to push in already rebased PRs , and get the newcomer PR merged (before it breaks and they cant fix it)
Kriti Rohilla
@kriti21
Jul 29 2018 05:43 UTC
:+1:
John Vandenberg
@jayvdb
Jul 29 2018 06:01 UTC
coala/coala-bears#2646 passed tests; moban job underway. pls review
Ankit Joshi
@MacBox7
Jul 29 2018 06:02 UTC
Yes reviewing.
John Vandenberg
@jayvdb
Jul 29 2018 06:17 UTC
replied
Ankit Joshi
@MacBox7
Jul 29 2018 06:19 UTC
Approved :+1:
John Vandenberg
@jayvdb
Jul 29 2018 06:21 UTC
rebasing newcomer PR
John Vandenberg
@jayvdb
Jul 29 2018 07:24 UTC
Merged
Your turn @kriti21
Kriti Rohilla
@kriti21
Jul 29 2018 07:27 UTC

Your turn @kriti21

On it

John Vandenberg
@jayvdb
Jul 29 2018 09:24 UTC
@anctartica , please rebuild you repo without merge commits. https://github.com/anctartica/bear-packages/commits/master
saksham189
@saksham189
Jul 29 2018 10:05 UTC
done
Ishan Srivastava
@ishanSrt
Jul 29 2018 10:09 UTC
John Vandenberg
@jayvdb
Jul 29 2018 10:12 UTC
thx @anctartica ;-)
use fast forward from now on pls ;-)
saksham189
@saksham189
Jul 29 2018 10:13 UTC
yes understood..
John Vandenberg
@jayvdb
Jul 29 2018 10:14 UTC
@ishanSrt pls ping again when green
@kriti21 , one merged
Kriti Rohilla
@kriti21
Jul 29 2018 10:15 UTC
Yup..Thanks
John Vandenberg
@jayvdb
Jul 29 2018 10:15 UTC
GitLinearCommitBear now exists to scream out whenever a merge commit was used.
Kriti Rohilla
@kriti21
Jul 29 2018 10:15 UTC
Only one test pending in coala/coala-bears#2523 as well. You might wanna review
John Vandenberg
@jayvdb
Jul 29 2018 10:15 UTC
lets rebase a PR with a merge commit and see what happens
Kriti Rohilla
@kriti21
Jul 29 2018 10:16 UTC
:+1:
Ishan Srivastava
@ishanSrt
Jul 29 2018 10:24 UTC
John Vandenberg
@jayvdb
Jul 29 2018 10:28 UTC
im doing a rebase on coala/coala-bears#2647 , and it is closed because it was an empty PR ;-)
Kriti Rohilla
@kriti21
Jul 29 2018 10:47 UTC