These are chat archives for coala/coala-bears

3rd
Aug 2018
Ishan Srivastava
@ishanSrt
Aug 03 2018 12:16 UTC
I will take a look at it
John Vandenberg
@jayvdb
Aug 03 2018 13:07 UTC
if you dont get time, due to the strategy you're taking (ive had a quick look), then we can do it after gsoc
Ishan Srivastava
@ishanSrt
Aug 03 2018 13:09 UTC
that would be better
John Vandenberg
@jayvdb
Aug 03 2018 13:17 UTC
your priority needs to be on effective results from green mode. they wont be as good without Setting support, but may still be effective enough
you may want to focus on specific languages or something, a subset of bears that are typical in certain types of repos
Viresh Gupta
@virresh
Aug 03 2018 14:57 UTC

coala/mobans!68

^This template seems to work towards modularising the setup.cfg even more, but how to actually use the coverage_pragma block ?
Extending setup.cfg.jj2 won't work anymore
And Extending coveragerc.jj2 won't work either since setup.cfg.jj2 is already hardcoding coveragerc.jj2

@anctartica @jayvdb

saksham189
@saksham189
Aug 03 2018 15:13 UTC
alright so, currently you cannot override an included block from a child template
the simplest solution would be put the block definition back to setup.cfg.jj2
Viresh Gupta
@virresh
Aug 03 2018 15:14 UTC
Alright
I'll send in an MR for the quick fix
saksham189
@saksham189
Aug 03 2018 15:15 UTC
thanks. I had not realized this before.
Viresh Gupta
@virresh
Aug 03 2018 15:39 UTC
Up for review : coala/mobans!70
John Vandenberg
@jayvdb
Aug 03 2018 16:30 UTC
@virresh , replied - you were abusing that section
Viresh Gupta
@virresh
Aug 03 2018 16:54 UTC
Alright
I understood about the include section
but for the omit section I think we still need some work around
Since --ignore will still count that directory for coverage
It won't detect any tests residing in the directory, but the directory's coverage is still taken into account
(I might be wrong on this, please correct if so)
Viresh Gupta
@virresh
Aug 03 2018 17:02 UTC
John Vandenberg
@jayvdb
Aug 03 2018 17:03 UTC
We add a extra_omit or something. Create new issue about your need
Viresh Gupta
@virresh
Aug 03 2018 17:03 UTC
Alright
Viresh Gupta
@virresh
Aug 03 2018 17:36 UTC
coala/mobans!71
Attempted this as a solution for extra_omit, pls review
John Vandenberg
@jayvdb
Aug 03 2018 17:45 UTC
See issue.
Im off to sleep. Ill assess tmr
Viresh Gupta
@virresh
Aug 03 2018 17:46 UTC
Thanks
Night !