These are chat archives for coala/coala-bears

5th
Aug 2018
John Vandenberg
@jayvdb
Aug 05 2018 03:55
@ishanSrt please rebase coala/coala-quickstart#263 ; i suggest rechecking coverage before pushing, as coala/coala-quickstart#283 may result in a few corners of your code now being reported as not covered
Ishan Srivastava
@ishanSrt
Aug 05 2018 03:59
👍
We always aim for 100% coverage even when codecov tests pass
John Vandenberg
@jayvdb
Aug 05 2018 04:02
also note I assigned coala/coala-quickstart#280 to you ; it is project code, so needs to be 100% coverage
Ishan Srivastava
@ishanSrt
Aug 05 2018 04:03
hmm pytest doesn’t detect that?
John Vandenberg
@jayvdb
Aug 05 2018 04:03
@ishanSrt , ya, but when not enforced, minor bits are missed. and more importantly, branch coverage wasnt enabled before, so you will have not noticed when certain flows were missing coverage
if foo: is only covered properly if there is a test case for not foo
Ishan Srivastava
@ishanSrt
Aug 05 2018 04:05
you mean partial coverage on conditional statements?
John Vandenberg
@jayvdb
Aug 05 2018 04:07
ya. google branch coverage and ping if you need a hand on understanding what is missing
the ppl in coala and bears repos will especially be able to help you, as they hit this all the time. iirc you did do a bit of coala & bears work before this project, so you probably did encounter it a bit
Ishan Srivastava
@ishanSrt
Aug 05 2018 04:16
yeah i know what it is. i guess an extra commit with some modification was made to that by me which didn’t have 100% coverage. Will add more tests
John Vandenberg
@jayvdb
Aug 05 2018 04:19
yup; that happens when it isnt enforced by computers ;-)
can I get a review of coala/coala-bears#2615 pls. Need that in order to use the setup.cfg template
Ishan Srivastava
@ishanSrt
Aug 05 2018 04:35
@jayvdb can this be added as a dependency for QuickStart? https://pypi.org/project/anytree/
John Vandenberg
@jayvdb
Aug 05 2018 04:37
looks ok, except, pls fork and run a 3.7 test on travis
they have decent test coverage, so any bugs on 3.7 are likely to cause a test failure
Sladyn
@sladyn98
Aug 05 2018 12:57
I am working on : coala/coala-bears#2479
Can anyone here help me on how does the bear_requirements.py read the language dependencies
John Vandenberg
@jayvdb
Aug 05 2018 13:15
It uses coala . Specifically it asks coala for all bear objects. Then it reads the REQUIREMENTS attribute of each bear
The script is in the .ci directory. Please read it