These are chat archives for coala/coala-bears

11th
Aug 2018
Kriti Rohilla
@kriti21
Aug 11 2018 15:56
I just rebased my branch for coala/coala-bears#2652 and coverage has dropped even for already accepted bears which had 100% coverage. Any idea why this happened ?
John Vandenberg
@jayvdb
Aug 11 2018 16:03
@kriti21 , you have a test failure - fix that before asking for other help
Kriti Rohilla
@kriti21
Aug 11 2018 16:05
Yes.. I have been talking to my mentor about that.. Tried everything he suggested and everything that I thought might work.
Still working on it
John Vandenberg
@jayvdb
Aug 11 2018 16:07
dont worry about coverage till you have tests passing
Kriti Rohilla
@kriti21
Aug 11 2018 16:08
ok.. working on it
John Vandenberg
@jayvdb
Aug 11 2018 17:28
omg @ishanSrt i see green
Ishan Srivastava
@ishanSrt
Aug 11 2018 17:29
Yes i disabled multiprocessing for windows altogether, added a FIXME as we didn’t know that whether it was appveyor making a fuss or it would fail pytest too on windows
John Vandenberg
@jayvdb
Aug 11 2018 17:44
:+1:
slow is better than broken