These are chat archives for coala/coala-bears

12th
Aug 2018
John Vandenberg
@jayvdb
Aug 12 2018 01:39
John Vandenberg
@jayvdb
Aug 12 2018 01:44
lots of things on coala/coala-quickstart#288 havent been replied to
Ishan Srivastava
@ishanSrt
Aug 12 2018 02:14
coverage increases a lil bit with my commits
Overall 98.17—>98.64 but the uncovered lines in Bears.py are after it returns the values required for green mode
I think the coverage at FileGlobs.py can’t increase even with the addition of the next PR
Until tests for coala_quickstart.py are added
Ishan Srivastava
@ishanSrt
Aug 12 2018 02:20

too many comments from previous PR not done for this to be reviewed again.

don’t what other too many comments I am supposed to take care of in this PR

Ishan Srivastava
@ishanSrt
Aug 12 2018 02:28
is it the importing of modules in alphabetical order?
Ishan Srivastava
@ishanSrt
Aug 12 2018 06:55
@jayvdb will posix include linux + unix?
John Vandenberg
@jayvdb
Aug 12 2018 06:56
yup
Ishan Srivastava
@ishanSrt
Aug 12 2018 10:10
pycodestylebear on quickstart isn’t detecting those spaces around operators
are you sure you cant get the other lines of Bears.py ?
are you going to get them in the next PR ?
Ishan Srivastava
@ishanSrt
Aug 12 2018 11:55
@jayvdb :point_up: August 12, 2018 7:44 AM no a few lines get covered but the function at Bears.py returns early for green_mode and the coverage of the remaining lines remain as it is
John Vandenberg
@jayvdb
Aug 12 2018 11:57
merging
added a link to that on the PR
merged
Ishan Srivastava
@ishanSrt
Aug 12 2018 12:30
@jayvdb small one coala/coala-quickstart#290
John Vandenberg
@jayvdb
Aug 12 2018 12:34
@anctartica after bashate is merged, let the current Gherkin build finish, then ill check it, and you can rebase if approved
@kriti21 , a commit has been merged so rememeber to rebase
(when you are ready, not before, CI is struggling at the moment)
Ishan Srivastava
@ishanSrt
Aug 12 2018 13:04
@jayvdb made the changes coala/coala-quickstart#290
John Vandenberg
@jayvdb
Aug 12 2018 13:12
reviewed
Ishan Srivastava
@ishanSrt
Aug 12 2018 14:08
@jayvdb can’t seem to understand why the test I have added isn’t running coala/coala-quickstart#291
i remember it occurring after you added that pragma rules PR
John Vandenberg
@jayvdb
Aug 12 2018 14:17
I am pretty sure you are misremembering
because your tests doesnt reach Project.py 151 at all
lots of coala_quickstart.py isnt covered either
you can remove the rule about args.green_mode in .nocover.yaml to see more areas not covered
that might help you see the paths missing
if you want to check if I did anything, then disable the plugins in setup.cfg addopts
also branch = False will give you a view closer to what you saw before
John Vandenberg
@jayvdb
Aug 12 2018 15:32
@ishanSrt style error
unused variable o_O
Ishan Srivastava
@ishanSrt
Aug 12 2018 15:49
i renamed the file, that’s what causing the tests to not run
John Vandenberg
@jayvdb
Aug 12 2018 15:52
deadline pressure mistakes ;-)
Ishan Srivastava
@ishanSrt
Aug 12 2018 15:52
unused code part is fixed using the coala_utils will take a bit of time
John Vandenberg
@jayvdb
Aug 12 2018 15:53
how many patches do you have after this one?
Ishan Srivastava
@ishanSrt
Aug 12 2018 15:53
2
John Vandenberg
@jayvdb
Aug 12 2018 15:54
do you have school tmr ?
Ishan Srivastava
@ishanSrt
Aug 12 2018 15:54
out of which the last one is a bit broken due to recent changes

do you have school tmr ?

yea

broken due to recent changes

especially because of the second last patch where the files are aggregated into globs

John Vandenberg
@jayvdb
Aug 12 2018 15:56
ok, then skip Question for now
Ishan Srivastava
@ishanSrt
Aug 12 2018 15:56
skip the PR or skip using coala_utils?
John Vandenberg
@jayvdb
Aug 12 2018 15:57
skip using coala_utils
Ishan Srivastava
@ishanSrt
Aug 12 2018 15:58
ok thanks, I will create an issue about it to use Question in other places of quickstart too
John Vandenberg
@jayvdb
Aug 12 2018 16:32
crossing fingers
if you get time, you can try to get JSStandardBear updated, but if not, at least now you can include ^ one
saksham189
@saksham189
Aug 12 2018 16:34
yes thanks this was my second PR ever after newcomer issue
John Vandenberg
@jayvdb
Aug 12 2018 16:36
long journey
John Vandenberg
@jayvdb
Aug 12 2018 16:41
@ishanSrt , after this, I'd like to see a single branch with the other stuff to go in on top of master
and some notes on how to demo it, so I can see it working
if it doesnt work, there isnt any point we keep trying to merge it