These are chat archives for coala/coala-bears

14th
Aug 2018
Rafid Aslam
@refeed
Aug 14 2018 01:28
Is coala-bears repo using mobans that is in https://gitlab.com/coala/mobans ?
I guess so, but why it isn't synced until now?
John Vandenberg
@jayvdb
Aug 14 2018 01:36
our main repos regularly get out of sync
Rafid Aslam
@refeed
Aug 14 2018 02:06
Hmm okay, btw, is the sync done one by one file? I've been waiting for the .gitignore sync here
John Vandenberg
@jayvdb
Aug 14 2018 02:58
ah, there is a PR for that
and it is blocked
Rafid Aslam
@refeed
Aug 14 2018 04:26
Ah, coala/coala-bears#2531 , I'm gonna take a look to the blocker
John Vandenberg
@jayvdb
Aug 14 2018 04:44
@refeed , the problem is after npm install , a bunch of symlinks are created, and coala halts
if npm install isnt done
all is well
and then a different bug that ignoring node_modules doesnt work properly on windows
Rafid Aslam
@refeed
Aug 14 2018 04:53
@jayvdb Is there a ticket for that? I thought the blocker was https://github.com/coala/coala-bears/pull/2531#issuecomment-405330225
John Vandenberg
@jayvdb
Aug 14 2018 04:56
yup ; same problem
those failed builds are all using a .gitignore which is 'everything unless ignored'
hard to explain ; too busy atm with quickstart ;)
John Vandenberg
@jayvdb
Aug 14 2018 05:02
coala/coala-quickstart#294 ping @ishanSrt ; it was green in previous build
John Vandenberg
@jayvdb
Aug 14 2018 05:13
grr.. windows has to be different
John Vandenberg
@jayvdb
Aug 14 2018 05:33
@ishanSrt so 50 is a good option to use ?
Ishan Srivastava
@ishanSrt
Aug 14 2018 05:35
I just added another commit, fetch the PR again
http://pycodestyle.pycqa.org/en/latest/intro.html#error-codes these are all the errors that pycodestyle can detect
John Vandenberg
@jayvdb
Aug 14 2018 05:55
@ishanSrt fix your commit messages. "Fix a bug" isnt good enough
lots of them
still havent done textwrap.dedent
John Vandenberg
@jayvdb
Aug 14 2018 06:01
Ishan Srivastava
@ishanSrt
Aug 14 2018 07:08
trying send out a patch for the running of bear deps, can’t concentrate on that ^^
John Vandenberg
@jayvdb
Aug 14 2018 07:11
np. i need it for testing .. i can cherry pick it as needed
John Vandenberg
@jayvdb
Aug 14 2018 07:21
@ishanSrt , why couldnt you use the existing functions in BearRunning ?
maybe we can enhance BearRunning to give you what you need
Ishan Srivastava
@ishanSrt
Aug 14 2018 07:28
I took a look at those
seemed difficult to manipulate get_local_dependency_results()
John Vandenberg
@jayvdb
Aug 14 2018 07:35
but why not run_bear() ?
Ishan Srivastava
@ishanSrt
Aug 14 2018 07:37
That doesn’t run bears from BEAR_DEPS
At least thats what i interpretted when i looked at it
Ishan Srivastava
@ishanSrt
Aug 14 2018 07:58
patch is successfully made, don’t know how in the world it is gonna be tested
but again on it
John Vandenberg
@jayvdb
Aug 14 2018 08:15
testing locally to see if InvalidLinkBear is fixed
oh , you havent pushed yet ?
Ishan Srivastava
@ishanSrt
Aug 14 2018 09:03
No writing tests
also on pytest repo ran everything with 2000 value, been running since like an hour
definitely greater than 100 values for pycodestyleselect and pycodestyleignore
John Vandenberg
@jayvdb
Aug 14 2018 09:07
currently running with 90 ; will try a higher number if that doesnt work
Ishan Srivastava
@ishanSrt
Aug 14 2018 09:08
Maybe i should have added something such that if the number of values for settings exceed, the number provided, it still selects some max-values at random from all possible values
John Vandenberg
@jayvdb
Aug 14 2018 09:12
at least a console message to say the number used isnt high enough
50 did nothing. the user needs to know that
Ishan Srivastava
@ishanSrt
Aug 14 2018 09:21

patch is successfully made,

was able to push with one pragma no cover

green_mode doesn’t seem so harsh on the cpu, but consumes a lot of ram
John Vandenberg
@jayvdb
Aug 14 2018 09:29
:+1:
my guess is you can get rid of the pragma by having different args in the top level and dependent bears
very likely bugs in all of this. fwiw, Session.run is my guess for what you should be using to run the bears with all dependencies included
but if it works on limited scenarios, it can get merged
need commit messages updated and other review comments done
Ishan Srivastava
@ishanSrt
Aug 14 2018 09:36
i can get rid of the pragma by using a one liner over there

Session.run

you mean methods like run_bear_from_section and all that?

I had tried that in phase 2 but coala does much more stuff between call of that method and running of the bear, that wasn’t required and also because it was creating innumerable errors and exceptions
John Vandenberg
@jayvdb
Aug 14 2018 09:39
no, Session.run
part of Core
Ishan Srivastava
@ishanSrt
Aug 14 2018 09:48
the commits in the old PR have been there for quite a while now, almost a month. Maybe if that was suggested/reviewed earlier I could have used it
John Vandenberg
@jayvdb
Aug 14 2018 09:49
I am talking about the new bug fixes you have just added in last 24 hrs
in this PR
Ishan Srivastava
@ishanSrt
Aug 14 2018 09:49
so only the bear deps could use the Session.run?
John Vandenberg
@jayvdb
Aug 14 2018 09:50
I assume so , but we can worry about that later
if your hack gets deps working, we're good for now
John Vandenberg
@jayvdb
Aug 14 2018 09:55
keep going
if it is consistently 3.5 we could disable it
it is also happening on the others, sparodically, that isnt an option ;-)
Ishan Srivastava
@ishanSrt
Aug 14 2018 10:33
After running for nearly 3 hours, Pycodestyle section:
[all.PycodestyleBear1]
max_line_length = 1274
bears = PycodestyleBear
pycodestyle_ignore = E126, E223
ignore += /home/ishansrivastava/pytest-httpbin/setup.py, /home/ishansrivastava/pytest-httpbin/tests/test_server.py, /home/ishansrivastava/pytest-httpbin/tests/test_httpbin.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/plugin.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/plugin.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs/cert.pem, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs/cacert.pem, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs/key.pem
files = /home/ishansrivastava/pytest-httpbin/**.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/**
pycodestyle_select = E111, E203, E741, W602
John Vandenberg
@jayvdb
Aug 14 2018 10:36
mine is still going :)
anyways ... let me check using your .coafile
Ishan Srivastava
@ishanSrt
Aug 14 2018 10:38
[all]
ignore = **/*.~, *.~, **/*.swp, *.swp, **/__pycache__/**, **/__pycache__, __pycache__, __pycache__/**, **/*.py[cod], *.py[cod], **/*.so, *.so, **/bin/**, **/bin, bin, bin/**, **/build/**, **/build, build, build/**, **/develop-eggs/**, **/develop-eggs, develop-eggs, develop-eggs/**, **/dist/**, **/dist, dist, dist/**, **/eggs/**, **/eggs, eggs, eggs/**, **/lib/**, **/lib, lib, lib/**, **/lib64/**, **/lib64, lib64, lib64/**, **/parts/**, **/parts, parts, parts/**, **/sdist/**, **/sdist, sdist, sdist/**, **/var/**, **/var, var, var/**, **/*.egg-info, *.egg-info, **/.installed.cfg/**, **/.installed.cfg, .installed.cfg, .installed.cfg/**, **/*.egg, *.egg, **/MANIFEST/**, **/MANIFEST, MANIFEST, MANIFEST/**, **/pip-log.txt/**, **/pip-log.txt, pip-log.txt, pip-log.txt/**, **/pip-delete-this-directory.txt/**, **/pip-delete-this-directory.txt, pip-delete-this-directory.txt, pip-delete-this-directory.txt/**, **/.tox/**, **/.tox, .tox, .tox/**, **/.coverage/**, **/.coverage, .coverage, .coverage/**, **/.cache/**, **/.cache, .cache, .cache/**, **/nosetests.xml/**, **/nosetests.xml, nosetests.xml, nosetests.xml/**, **/coverage.xml/**, **/coverage.xml, coverage.xml, coverage.xml/**, **/*.mo, *.mo, **/docs/_build/**, **/docs/_build, docs/_build, docs/_build/**, .git/**
[all.InvalidLinkBear1]
follow_redirects = True
bears = InvalidLinkBear
ignore += /home/ishansrivastava/pytest-httpbin/setup.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs/cert.pem, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs/cacert.pem, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs/key.pem
files = /home/ishansrivastava/pytest-httpbin/**.py, /home/ishansrivastava/pytest-httpbin/**.yml, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/**
[all.PycodestyleBear1]
max_line_length = 1274
bears = PycodestyleBear
pycodestyle_ignore = E126, E223
ignore += /home/ishansrivastava/pytest-httpbin/setup.py, /home/ishansrivastava/pytest-httpbin/tests/test_server.py, /home/ishansrivastava/pytest-httpbin/tests/test_httpbin.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/plugin.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/plugin.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs/cert.pem, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs/cacert.pem, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs/key.pem
files = /home/ishansrivastava/pytest-httpbin/**.py, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/**
pycodestyle_select = E111, E203, E741, W602
[all.LineCountBear1]
exclude_blank_lines = True
bears = LineCountBear
ignore += /home/ishansrivastava/pytest-httpbin/.gitignore, /home/ishansrivastava/pytest-httpbin/.coafile, /home/ishansrivastava/pytest-httpbin/runtests.sh, /home/ishansrivastava/pytest-httpbin/tox.ini, /home/ishansrivastava/pytest-httpbin/.project_data.yaml, /home/ishansrivastava/pytest-httpbin/setup.cfg, /home/ishansrivastava/pytest-httpbin/MANIFEST.in, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs/cert.pem, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs/cacert.pem, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/certs/key.pem
files = /home/ishansrivastava/pytest-httpbin/*, /home/ishansrivastava/pytest-httpbin/pytest_httpbin/**
max_lines_per_file = 1000
heavy usage of globs makes the settings like max_lines_per_file very huge, otherwise it should have created different sections for different values for the same bear
John Vandenberg
@jayvdb
Aug 14 2018 10:42
green
Ishan Srivastava
@ishanSrt
Aug 14 2018 10:42
I was asked to make the files field small so that we could later ask the user whether he would like to run coala on the inconsistent files i.e. the files that are in the ignore field by making a coafile with the values in ignore field as in the files field and the same bear settings
John Vandenberg
@jayvdb
Aug 14 2018 10:42
killed my one
ill check InvalidLinkBear now
John Vandenberg
@jayvdb
Aug 14 2018 10:48
green again
ok, tidy up and lets get it merged
Ishan Srivastava
@ishanSrt
Aug 14 2018 10:50
here’s a coafile with more files field and almost no ignores https://pastebin.com/x1FSyD4h this can be changed by changing the values of some constants

almost no ignores

or may be they were not working at that time

I had one more eg of a coafile with which you can limit the globs and make it produce different sections for different settings, can’t find it atm
John Vandenberg
@jayvdb
Aug 14 2018 13:37
@ishanSrt anything left in coala/coala-quickstart#263 ?
Ishan Srivastava
@ishanSrt
Aug 14 2018 13:37
no
John Vandenberg
@jayvdb
Aug 14 2018 13:38
:+1: