These are chat archives for coala/coala-bears

11th
Oct 2018
Ishan Srivastava
@ishanSrt
Oct 11 2018 09:25
you can install all the bears alternatively by cloning the repo, and running pip install . or pip install -e .(for development setup) in the root directory
John Vandenberg
@jayvdb
Oct 11 2018 09:59
@Dhiraj240, I reviewed your PR. Could you also rebase when you fix that, so it can be merged immediately if it passes
John Vandenberg
@jayvdb
Oct 11 2018 12:00
hiya @ishanSrt , do you have time tonight to try to get quickstart green?
Ishan Srivastava
@ishanSrt
Oct 11 2018 12:01
Yes, I do
John Vandenberg
@jayvdb
Oct 11 2018 12:03
ok, which PR needs to go in first to get the repo green? it will now need an extra commit for the moban sync
or ... if it is coala/coala-quickstart#314 ... I can merge it, it will be a red master build, and then moban sync after
eww ... that PR still has the MP stuff in it
Ishan Srivastava
@ishanSrt
Oct 11 2018 12:05
you asked me to try out, not disabling MP for python3.4
yet that day i couldn’t make it green without doing so,
i didn’t test it again yet
John Vandenberg
@jayvdb
Oct 11 2018 12:06
ok, still remove that MP stuff.. that is not the solution
if necessary, we ignore the travis failure, and solve it the right way
Ishan Srivastava
@ishanSrt
Oct 11 2018 12:09
just pushed
John Vandenberg
@jayvdb
Oct 11 2018 12:12
k, looks ok, ping when CI is finished
Ishan Srivastava
@ishanSrt
Oct 11 2018 12:34
looks like appveyor is picking up the wrong version of colorama. The changes must be done in test-requirements.txt.jj2. We should have test-requirements pinning values from another key like test-dependencies, the same way its implemented for dependencies in .moban.yaml
It doesn’t seem like we have an issue for it
ping @jayvdb
John Vandenberg
@jayvdb
Oct 11 2018 12:55
ill take a look.
the root of the problem is more likely that quickstart isnt using master yet, it is the only 'main' repo hasnt been updated to use master per meta#100.
Dhiraj Sharma
@Dhiraj240
Oct 11 2018 13:15
@jayvdb Fine, i will try to rebase it.
Dhiraj Sharma
@Dhiraj240
Oct 11 2018 14:39
coala/coala-bears#2696 CI is failing for Python 3.5
@jayvdb Fine, i will try to rebase it.
Ishan Srivastava
@ishanSrt
Oct 11 2018 16:17
The wrong version of colorama was obtained from pytest. I doubt how not having master branch of coala as a dependency is related to that
John Vandenberg
@jayvdb
Oct 11 2018 16:20
You can find issues about it in our repos.
@Dhiraj240 you need to regenerate (and re-edit) the yaml file.
The log is showing a wild amount of changes.
Dhiraj Sharma
@Dhiraj240
Oct 11 2018 16:36
@Dhiraj240 you need to regenerate (and re-edit) the yaml file.
I executed the requirements script where i got warnings but no error
will update the yaml file.
Ishan Srivastava
@ishanSrt
Oct 11 2018 16:38

You can find issues about it in our repos.

was that for me? 😅

John Vandenberg
@jayvdb
Oct 11 2018 16:49
@Dhiraj240 , check your commit before pushing, using git show
@ishanSrt ya, I'm pretty sure I remember issues about colorama versions which we've already solved.
pytest is often a trigger of dependency problems because packages setup.py often contain setup_requires=pytest, so that setup.py test uses pytest instead of old boring unittest .
(they should use test_requires , but then they can't import pytest into setup.py)
Ishan Srivastava
@ishanSrt
Oct 11 2018 17:02
the pytest in coala-quickstart’s test-requirements (line 10) provided with the wrong version, not some other module having pytest as a dependency triggered by setup_requires=pytest
Dhiraj Sharma
@Dhiraj240
Oct 11 2018 17:14
@jayvdb okay, did the same thing, now build will take sometime.