These are chat archives for coala/coala-bears

13th
Oct 2018
Ishan Srivastava
@ishanSrt
Oct 13 2018 09:13
We can't solve issues with coala-quickstart obtaining wrong version of a certain packages in case its receiving it, from one of its own test-requirements.txt's dependency, in our case being wrong version of colorama being received from pytest. It doesn’t happen in other repos because colorama-0.40 from pytest-3.6.1 is acceptable for them. May be its also for quickstart, should be checked but I don’t see how this is related to quickstart not using dev versions of other coala repos. 😟
:point_up: October 11, 2018 10:32 PM
ping @jayvdb

also can you tell me how are we acheiving this

We dot not want the testbed for repos to be even slightly different, because that is a slippery slope.

when test-requirements.txt.jj2 contains so many repository specific rules?

John Vandenberg
@jayvdb
Oct 13 2018 09:22
I have already explained the problem with colorama; you just dont believe me.
im not into repeating myself
the differences in test-requirements.txt.jj2 are pretty self-explanatory if you look at what the various repos are which have specific rules
some even have a issue link describing why.
Ishan Srivastava
@ishanSrt
Oct 13 2018 09:30
I am really sorry @jayvdb
but the explanation that you gave me for colorama seems wrong to me
you talked about wrong colorama version being received from setup.py of other modules as deps using pytest for tests
whereas I explained :point_up: October 11, 2018 10:32 PM that its not the case, the pytest dependency that is providing the wrong colorama version is in the test-requirements.txt of quickstart’s own repo
John Vandenberg
@jayvdb
Oct 13 2018 11:19
'seems wrong' that is nice, but I know without doubt that you are wrong.
I've tried to guide you towards how you can independently investigate this
logically, the test bed we use for coala and coala-bears is complicated and yet it is working correctly.
coala-quickstart depends on coala-bears , and thus it must use the same test bed. to not use the same test bed is begging for it to have to go through all the dependency hell issues itself
which is what you have been seeing.
moreover, irrespective of whether I am right or wrong about colorama, coala-quickstart must be updated to use coala master , otherwise it is useless. So you could quite easily attempt to get quickstart working with coala/bears master, and you would have found that ... suprise ... the test-requirments work just fine
Ishan Srivastava
@ishanSrt
Oct 13 2018 15:18
So quick start will get its test-requirements dependencies from other coala repos?
Ishan Srivastava
@ishanSrt
Oct 13 2018 15:25
Even so those dependencies might be test dependencies in something like coala bears
John Vandenberg
@jayvdb
Oct 13 2018 16:39
coala-quickstart depends directly on coala-bears. its test bed must be compatible with the test bed of coala-bears. otherwise it cant be installed.
anyway, seems I'll have to fix this myself.
you're not getting the fact that coala-quickstart is useless until it has been updated to use coala master, and is blocking our release
Ishan Srivastava
@ishanSrt
Oct 13 2018 17:10

I don’t seem to understand the fact, how will the test beds become compatible if we add the dev version of coala-bears as the dependency instead of the older version we use right now. The test-requirements of the dependencies don’t get installed, (if i am correct) so it won’t affect the problem with colorama and its kind we have right now.

If a module in a test-dependency is supplying with an incompatible module (in our case pytest) then i don’t see how this will get solved by using dev versions of other repos as they don’t have pytest as their requirement, only in their test requirement

And even if they do so because of the setup.py, as you tried to explain, currently is see both the older and the dev version will supply same versions of pytest and colorama i.e. 0.40. while other coala repos may be compatible with that colorama version, quickstart isn’t and there is a possiblity (which i am completely not sure of) that on using the dev version of other coala repos, the 0.40 version of colorama might become compatible with quickstart too, if that is what you mean.

John Vandenberg
@jayvdb
Oct 13 2018 17:13
i've given up explaining. code talks
John Vandenberg
@jayvdb
Oct 13 2018 20:03