These are chat archives for coala/coala-bears

25th
Oct 2018
John Vandenberg
@jayvdb
Oct 25 2018 11:29
anyone encountering pytest-reqs or pip problems, uninstall pytest-reqs and reinstall it according to test-requirements.txt
Rishabh Garg
@rishabhgarg25699
Oct 25 2018 13:29
I am doing this issue i.e coala/coala-bears#2702 Now I make changes and after making changes it also pass local test when I run test locally . But now when i push it, travis ci is not passing it . I see the logs of it and IMO it is due to some other issue . If it is due to some other issue then I move to next issue or if it is due to my changes then please suggest changes then I will do this issue
John Vandenberg
@jayvdb
Oct 25 2018 13:40
have you used the bear locally ?
does it work ?
Rishabh Garg
@rishabhgarg25699
Oct 25 2018 16:21
@jayvdb I run bear locally It is not showing any error. And it is working
John Vandenberg
@jayvdb
Oct 25 2018 16:22
a bear doesnt work unless it shows errors
bears show errors. that is what they do
Rishabh Garg
@rishabhgarg25699
Oct 25 2018 16:22
Means bear is showing its error and no coding error
I take the sample file from here https://github.com/coala/bear-docs/blob/master/docs/PEP8NotebookBear.rst and run bear on this
John Vandenberg
@jayvdb
Oct 25 2018 16:24
does it show your error, about line length ?
Rishabh Garg
@rishabhgarg25699
Oct 25 2018 16:25
In coafile i did the max_line_lenght =0 but it does not show any error about its lenght
it is because it the sample file no line is longer
But now when I did the max_line_lenght = 20(only for experiment) still now it is not showing error
John Vandenberg
@jayvdb
Oct 25 2018 16:31
if you can not have the error appear and disappear , it is not working
Rishabh Garg
@rishabhgarg25699
Oct 25 2018 18:12
Is I am running bear locally . Please see my process
  1. I copy the PEP8Notebookbear fron the clone repo in local
  2. Then I made changes in that bear.
  3. Then in one folder I put that bear and file on which I want to run bear .
  4. Then I run command coala -b PEP8NotebookBear -d /home/rishabh/Desktop/Testing -f some_notebook.ipynb --save
  5. Then it creates pycachefolder and .coafile
then that bear runs on that file
Is this correct ? It also run my changes that I do in PEP8Notebookbear ?
John Vandenberg
@jayvdb
Oct 25 2018 19:05
how do you know it runs your changes? you dont need me to confirm that . you can add code to your copy of the bear which prints logging or whatever to prove to yourself that it is running.
Rishabh Garg
@rishabhgarg25699
Oct 25 2018 19:32
@jayvdb In this line i.e https://github.com/coala/coala-bears/blob/master/bears/python/PEP8NotebookBear.py#L76 if we change max_line_length from 79 to 500 then this bear allow the length of 500 in testing file ??
length of a single line
John Vandenberg
@jayvdb
Oct 25 2018 20:22
@rishabhgarg25699 , this is a simple problem. i am not giving you hints. either you do the work yourself or you dont.
Rishabh Garg
@rishabhgarg25699
Oct 25 2018 21:13
@jayvdb IMO my changes are right in my PR and i an doing mistake in running bear because when i run the different bear i.e PEPBear which has same infinite line length issue and that is merged is also doing the same mistake . It means my changes are correct but I am doing mistake in running my changes