These are chat archives for coala/coala-bears

4th
Nov 2018
I'll have to ignore the bears, some way or the other. This way seems more appropriate
John Vandenberg
@jayvdb
Nov 04 2018 05:45
yes, and I let it be that time because it was python in json, and it was your first decent PR
onwards and upwards, do it properly this time, because this case is much simpler
Bhushan Khanale
@bkhanale
Nov 04 2018 05:47
So are you suggesting me to make changes in the .coafile instead?
John Vandenberg
@jayvdb
Nov 04 2018 05:51
no.
you are writing python code. you need to construct a string of characters which is longer than 80 chars. without your source line being longer than 80 chars. This is a python coding challenge.
Bhushan Khanale
@bkhanale
Nov 04 2018 06:33
Understood, thanks :)
Bhushan Khanale
@bkhanale
Nov 04 2018 06:53
@jayvdb I had made the changes, the build failed but for very different reason https://travis-ci.org/coala/coala-bears/jobs/450405436#L827
John Vandenberg
@jayvdb
Nov 04 2018 07:00
network problem - restart the job
Bhushan Khanale
@bkhanale
Nov 04 2018 07:01
:+1:
John Vandenberg
@jayvdb
Nov 04 2018 07:30
100% test coverage
nice.
reviewed
should be easy to finish now
Anuj Sharma
@phoenixking25
Nov 04 2018 09:40
hey can anyone help me in this i am getting error ImportError: cannot import name 'get_installed_distributions' on executing python setup.py test in coala-bears
John Vandenberg
@jayvdb
Nov 04 2018 09:59
Hiya @phoenixking25 , that will be a pip version problem. Update your clone from upstream and reinstall test-requirements.txt
Anuj Sharma
@phoenixking25
Nov 04 2018 10:00
thanks @jayvdb , in progress .....
John Vandenberg
@jayvdb
Nov 04 2018 10:02
no need to ping for acknowledgements ... save your pings for when you really need them
Bhushan Khanale
@bkhanale
Nov 04 2018 10:06
@jayvdb Please check now
John Vandenberg
@jayvdb
Nov 04 2018 10:11
merging
Bhushan Khanale
@bkhanale
Nov 04 2018 10:15
Awesome, thanks :)
John Vandenberg
@jayvdb
Nov 04 2018 10:18
no , thank you
further down the rabbit hole ... ?
Bhushan Khanale
@bkhanale
Nov 04 2018 10:28
@jayvdb Yep, sure :laughing:
John Vandenberg
@jayvdb
Nov 04 2018 10:36
@bkhanale coala/coala#5877
Bhushan Khanale
@bkhanale
Nov 04 2018 10:43
@jayvdb Thanks, I will work on it :)