These are chat archives for coala/coala-bears

15th
Nov 2018
Sharikzama
@ZamaSharik
Nov 15 2018 01:50
Even if I commit my changes to my fork those changes commited in the pull request!
Boxuan Li
@li-boxuan
Nov 15 2018 02:51
@Sidsharik Yes, that's why we say do not push.
Sharikzama
@ZamaSharik
Nov 15 2018 02:52
so now I just need to squash my commits using git rebase -i origin/master right?
origin/master might work, depending on what commit your origin/master is on
Sharikzama
@ZamaSharik
Nov 15 2018 02:57
I have a branch called JSONFormatBear through which I am doing all the changes
John Vandenberg
@jayvdb
Nov 15 2018 04:21
You do not need to rebase ATM. That just makes a bigger mess. You need to squash your commits so you only have one commit. Read 'git log' . Work out which commits are not your code . Then git rebase -i HEAD~16 and remove the commits which are not your code.
Boxuan Li
@li-boxuan
Nov 15 2018 06:29
@ZamaSharik Please, please do not push until you verify it locally.
You are creating a mess again :(
John Vandenberg
@jayvdb
Nov 15 2018 09:43
just close the PR, unassign, etc.
Boxuan Li
@li-boxuan
Nov 15 2018 09:49
@ZamaSharik Sorry you lose the chance to fix the PR. unassigned.
Prashant Sharma
@gutsytechster
Nov 15 2018 17:38
Please review coala/coala-bears#2710
Finally, the CI is happy :relieved:
@jayvdb