These are chat archives for coala/coala-bears

30th
Jan 2019
John Vandenberg
@jayvdb
Jan 30 07:08
@refeed , can you finish up coala/coala-bears#1894 ; your commit looks ok, but I cant see the PR. dont stress if the CI is failing - we've got a backlog of red-ness happening
John Vandenberg
@jayvdb
Jan 30 11:07
@/all issue 2833 is current breakage. Need solutions
Abhinav Kaushlya
@abhishalya
Jan 30 12:35
@jayvdb Gometalinter no longer follows the --installflag, so it needs to be changed.
As per here we need change here
Utkarsh Gupta
@utkarsh2102
Jan 30 12:46
Alternatively, should we consider enabling only those linters that we actually want?
CC: @abhishalya @jayvdb
Naveen Naidu
@Naveenaidu
Jan 30 12:53

@/all issue 2833 is current breakage. Need solutions

@jayvdb Do you mean issue 2843? Because as i see 2833 is already fixed

Naveen Naidu
@Naveenaidu
Jan 30 13:21

@jayvdb Gometalinter no longer follows the --installflag, so it needs to be changed.

@abhishalya IMHO, it's not the --install flag which is leading to the error. Yes! It is true that the Gometalinter v2 no longer supports the flag. But iirc we are still using the v1 of that and it supports the flag. The problem we are facing here is that few of the linters that Gometalinter(eg: staticcheck) has have given up the support for Go 1.5 and hence the we need to find a way around it. Most Probably by disabling the bears that do not support the version of Go that we use in our CI

Utkarsh Gupta
@utkarsh2102
Jan 30 13:25

@abhishalya IMHO, it's not the --install flag which is leading to the error. Yes! It is true that the Gometalinter v2 no longer supports the flag. But iirc we are still using the v1 of that and it supports the flag. The problem we are facing here is that few of the linters that Gometalinter(eg: staticcheck) has have given up the support for Go 1.5 and hence the we need to find a way around it. Most Probably by disabling the bears that do not support the version of Go that we use in our CI

The workaround I think is by disabling all the linters and then adding the only linters that we want.

John Vandenberg
@jayvdb
Jan 30 13:31
I recently disabled some linters. The same approach can be used
Abhinav Kaushlya
@abhishalya
Jan 30 13:35
Yeah, saw the issue now @Naveenaidu
Which Go version should we move up now?
Naveen Naidu
@Naveenaidu
Jan 30 13:36
Ideally we need to move up to Go 1.9 but I don't think the ci we use now supports 1.9 we are still running on go 1.5
The quick fix for now would be as @utkarsh2102 suggested. We can use the method provided here
The only linter that I found now that's giving us a problem is staticcheck.

iirc Unfortunately gometalinter doesn't have a --disable option which would help us disable only specific linters. So we have use the --disable-all option and enable them with --enable.

They should have added a feature of --disable option :P

Utkarsh Gupta
@utkarsh2102
Jan 30 13:41

The only linter that I found now that's giving us a problem is staticcheck.

Are you sure that's the only barrier?
@jayvdb is there any more that you found would be causing a problem here?

Naveen Naidu
@Naveenaidu
Jan 30 13:41
Checking out more linters to find the problems.
But then again the error undefined: types.SizesFor from the travis log worries me, a quick search tells that this is only supported by Go 1.9! Would this be a problem?
Shouldn't we actually upgrade our Go version to the latest? I mean looking at the way the linters are dropping support for the old go version.
Utkarsh Gupta
@utkarsh2102
Jan 30 13:45

Shouldn't we actually upgrade our Go version to the latest? I mean looking at the way the linters are dropping support for the old go version.

Ideally, we should.

Abhinav Kaushlya
@abhishalya
Jan 30 13:45
Travis supports Go 1.9 right?
Naveen Naidu
@Naveenaidu
Jan 30 13:46
It does. But we are using 1.5 in our ci
Utkarsh Gupta
@utkarsh2102
Jan 30 13:46

Travis supports Go 1.9 right?

No, we are using 1.5 in CI.

Oh yeah, it does. We need to upgrade.
We're at 1.5 at the moment.
Abhinav Kaushlya
@abhishalya
Jan 30 13:46
Then we can test everything out with newer version and then upgrade
It will take time but will be a stable solution for the problem
Utkarsh Gupta
@utkarsh2102
Jan 30 13:48
Ideally, we should. That's a bit harder as what John suggested.
So a quick fix is to disable the 2 broken ones.
And a long time fix is to upgrade to 1.9.
Abhinav Kaushlya
@abhishalya
Jan 30 13:49

Yeah so

So we have use the --disable-all option and enable them with --enable.

Should work fine til then

John Vandenberg
@jayvdb
Jan 30 13:49
It doesnt matter what travis supports. We need to install everything into a single ubuntu xenial worker
upgrading go means installing it ourselves. That is one of many possible fixes to the problem
Utkarsh Gupta
@utkarsh2102
Jan 30 13:51

It doesnt matter what travis supports. We need to install everything into a single ubuntu xenial worker

Then why not Bionic itself?
Currently, we're at Trusty.

John Vandenberg
@jayvdb
Jan 30 13:52
Does travis provide bionic workers?
Currently we are using xenial repos. Read .travis.yml and .ci/deps.* to check this
Utkarsh Gupta
@utkarsh2102
Jan 30 13:54
Oh yeah. WIP for Bionic, as what I see.
Shashank Batra
@shashank-b
Jan 30 13:54

Does travis provide bionic workers?

I don't think so

Naveen Naidu
@Naveenaidu
Jan 30 13:54
What do you suggest. Which way do you seem to be fit. Upgrading the go version or using the --disableAll option for gometalinter
Utkarsh Gupta
@utkarsh2102
Jan 30 13:55

What do you suggest. Which way do you seem to be fit. Upgrading the go version or using the --disableAll option for gometalinter

Upgrading the version is the ideal solution, undoubtedly.

Naveen Naidu
@Naveenaidu
Jan 30 13:56
Yeah! I agree with that.
Naveen Naidu
@Naveenaidu
Jan 30 14:25
@jayvdb For a quick fix should i create a PR using --disableAll method?
John Vandenberg
@jayvdb
Jan 30 15:13
ideally, each of you tries a different approach and see who gets it fixed first. :P
Utkarsh Gupta
@utkarsh2102
Jan 30 15:14
Haha :P
Except for staticcheck, what else is broken?
Naveen Naidu
@Naveenaidu
Jan 30 15:19
hehehe :laughing: