These are chat archives for coala/coala-bears

6th
Feb 2019
Bhanu Kashyap
@bnu123
Feb 06 13:00
please help me with the issue: coala/coala-bears#2738.
I made a commit to a file then reverted that commit and ran GitRevertInspectBear on that file, coala ran successfully, I am confused as to what I've to do.
Bhanu Kashyap
@bnu123
Feb 06 13:23
Thanks @sanchit48
Sanchit Khare
@sanchit48
Feb 06 13:26
:+1:
Amol Grover
@frextrite
Feb 06 14:37

https://github.com/coala/coala-bears/blob/master/.ci/appveyor.yml#L50

2 questions:

  1. Why do we have these dependencies installed in the first place?
  2. Why are we removing them for running appveyor build?
Ayan Banerjee
@ayan-b
Feb 06 14:49
@frextrite in Windows those dependencies cannot be installed, that's why they are being removed.
At this moment, I highly suggest you to sync moban and then make a PR.

Why do we have these dependencies installed in the first place?

Because, they are required for bears and in Linux they run quite well.

Amol Grover
@frextrite
Feb 06 14:51
Current moban template is old. If I sync and push appveyor fails.
Ayan Banerjee
@ayan-b
Feb 06 14:52
Have you pushed?
Ayan Banerjee
@ayan-b
Feb 06 14:53
Line no?
Ayan Banerjee
@ayan-b
Feb 06 14:57
In your repo have you enabled Travis CI?
moban is passing.
Which is not related to your changes.
Amol Grover
@frextrite
Feb 06 15:00

I agree moban is passing. On the other hand, the build breaks appveyor so it's a nogo right?

moban is passing.

@ayan-b I'm inclined to believe that's not the case.

Which is not related to your changes.

Take a look at the actual changes that were made after the sync
Ayan Banerjee
@ayan-b
Feb 06 15:02
Got it.
Your sync does not seem to be done properly.
Amol Grover
@frextrite
Feb 06 15:02
  1. Ruby was not in path
  2. Neither was node_modules folder

Your sync does not seem to be done properly.

Followed gitlab/coala/mobans steps.

I need to edit the actual template files to fix this right?
That's what I'm doing rn. Should I continue?
Ayan Banerjee
@ayan-b
Feb 06 15:05
Please have a look at the git blame and check how the sed , node_modules etc were added.
I found this PR: coala/coala-bears#2819
Can you please analyze it?
It seems the the seds were added manually.
Ayan Banerjee
@ayan-b
Feb 06 15:13
Also this one: coala/coala-bears#2817
It appears to me they were added manually.
Ayan Banerjee
@ayan-b
Feb 06 15:19

That's what I'm doing rn. Should I continue?

Yup, you are in the right direction. :smile:

John Vandenberg
@jayvdb
Feb 06 15:47
@frextrite you need to understand and "own" each change you make. moban is just a guide to help you see differences which could be applied. some differences will mean the templates need to be enhanced.
the templates are designed to work on as many repos as possible, but often are not able to support the more complicated repos
Amol Grover
@frextrite
Feb 06 15:57
@jayvdb Gotcha. Working on updating the template and syncing the bears repository.
btw can you explain why were the installation of a lot of linters skipped? The commit msg just states Skip installation of linters where bear tests fail on AppVeyor.
John Vandenberg
@jayvdb
Feb 06 16:02
@frextrite , dont try updating the template yet . sync the bears repo. create issues in mobans repo for enhancements needed
installing stuff on windows is hard
Ayan Banerjee
@ayan-b
Feb 06 16:03
@frextrite some of the node js modules are not properly installed in Windows. That's why they are removed.
John Vandenberg
@jayvdb
Feb 06 16:03
all sorts of new bugs because the upstream repos dont do testing on windows
Amol Grover
@frextrite
Feb 06 16:03

@frextrite , dont try updating the template yet . sync the bears repo. create issues in mobans repo for enhancements needed

but that would break appveyor build.

John Vandenberg
@jayvdb
Feb 06 16:03
@frextrite , choose which lines you are going to import
own the changes you make
they are your changes
every character
dont add stuff which breaks the repo
Amol Grover
@frextrite
Feb 06 16:07
So basically I do a sync. (Push them?) The template being old would obviously break appveyor but travis would go green. Then I create issues in mobans repo for the enhancements(updates) in the templates that would once again fix appveyor right?
John Vandenberg
@jayvdb
Feb 06 16:08
your bears PR should have all of the good changes in the templates, and exclude any bad ones
we merge that first
muarachmann
@muarachmann
Feb 06 16:08
@jayvdb did my newcomer PR and was merge can i have a difficulty low issue?
Amol Grover
@frextrite
Feb 06 16:09

Got this. But that's just one change. Most of the changes(80-90%) have to be done in the actual template.

your bears PR should have all of the good changes in the templates, and exclude any bad ones

That's why I wanted to know the template should be updated first or the bears. :sweat_smile:
Amol Grover
@frextrite
Feb 06 16:59
@jayvdb PR is up coala/coala-bears#2865
Amol Grover
@frextrite
Feb 06 17:41
gitmate-bot down?