These are chat archives for coala/coala-bears

8th
Feb 2019
John Vandenberg
@jayvdb
Feb 08 03:33

Travis is failing after this coala/coala-bears#2845 was merged. Coverage is not 100%.

ping @rajdeepbharati , you and I broke the repo CI. gotta fix it.

someone create an issue about it
Amol Grover
@frextrite
Feb 08 04:57
Issue already created coala/coala-bears#2866
Amol Grover
@frextrite
Feb 08 05:04
John Vandenberg
@jayvdb
Feb 08 05:22
@frextrite ok , great
Assigned coala/coala-bears#2866 to you as you're active ;-)
Amol Grover
@frextrite
Feb 08 05:27
We put in a lot of effort to fix Travis and it got broken again. Not done XD
Amol Grover
@frextrite
Feb 08 08:01
coala/coala-bears#2806 what did this issue actually mean? If I run LineContinuationBear on a file containing a backslash in a docstring, the bear should spit out an error and that needed to be fixed?
Tried running LineContinuationBear(before the above PR was merged) and it didn't throw any errors around that line. Does that mean the bear is working as intended?
Can anyone run the bear and confirm the result?
Abhinav Kaushlya
@abhishalya
Feb 08 08:36
@frextrite If the import statement has a \ then the line continuation bear should throw an error. It doesn't do anything for import statement specifically, it just finds if \ is at the end of the line or not, if it is then an errror is thrown
And the issue is to add specific behaviour to the bear as neglecting the \ in case of import statements
Amol Grover
@frextrite
Feb 08 08:40
Got it. Thanks.
The docstring in the above file had an ignore comment which I missed. My bad.
Amol Grover
@frextrite
Feb 08 09:00
@jayvdb #2868
John Vandenberg
@jayvdb
Feb 08 09:48
green again. thx @frextrite
Amol Grover
@frextrite
Feb 08 09:56
welcome :tada:
Amol Grover
@frextrite
Feb 08 12:09
#2865 going green again
John Vandenberg
@jayvdb
Feb 08 13:42
hmm , ack'd but gitmate isnt responding
John Vandenberg
@jayvdb
Feb 08 13:56
@frextrite ok, create one issue in mobans repo about one of the sync problems you encountered - whichever you think you understand the best
Amol Grover
@frextrite
Feb 08 13:57
on it
Amol Grover
@frextrite
Feb 08 14:39
John Vandenberg
@jayvdb
Feb 08 14:40
@frextrite please rewrite it to be about one problem, and think how the template needs to be enhanced in a generic way, not only for coala-bears
coala-bears is just the problem which has the problem first -- other repos will encounter the same problem one day - we build templates to solve the current problem in a way that also solves it for other repos.
Naveen Naidu
@Naveenaidu
Feb 08 14:49
@jayvdb Any good issues that I can work on, I would implement the changes suggested in my Jinja Bear PR and send it up by tonight latest. Please do let me know, if there are any urgent issues that needs to be solved. I would love to dig my hands in :D
John Vandenberg
@jayvdb
Feb 08 14:52
@Naveenaidu assigned you to coala/coala-bears#2869
Naveen Naidu
@Naveenaidu
Feb 08 14:53
Thanks! Working on it :)
Amol Grover
@frextrite
Feb 08 16:17
@jayvdb I thought of that but the changes I suggested are specific for coala-bears. Other repositories may or may not have to incorporate these changes. We can have an issue for adding generic changes that apply to all repos but some complex repos(coala, coala-bears) need to have a specific segment and this issue happens to address those specific changes that are needed.
Rajdeep Bharati
@rajdeepbharati
Feb 08 16:56
@frextrite my bad. I forgot to add the \
@jayvdb I’m working on the complete logic for coala/coala-bears#2806, as you asked in https://github.com/coala/coala-bears/pull/2845#discussion_r253382671. I will send a pr once it is complete