These are chat archives for coala/documentation

20th
Feb 2018
Boxuan Li
@li-boxuan
Feb 20 2018 17:26
Hi, I found the documentation here http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html a little bit misleading. The example 3 uses "Fixes" instead of "Closes" when fixing a typo. Seems the common practice is to use "Fixes" only when fixing a bug.
Mischa Krüger
@Makman2
Feb 20 2018 17:38
Oh, in that case please file an issue :)
@li-boxuan
Boxuan Li
@li-boxuan
Feb 20 2018 17:45
Sure, thank you @Makman2 . Would you also review coala/cEPs#103 if you have some time :smile: One reviewer has just reviewed it (thanks for his advice on changing 'Fixes' to 'Closes' btw), but it's still under 'pending review'. I guess it needs ack from someone with high level of privilege.
Mischa Krüger
@Makman2
Feb 20 2018 18:37
Yeah i hope soon. The review queue is already quite long, i hope i can once feel again what it means to have 0 notifications...
Nityesh Agarwal
@nityeshaga
Feb 20 2018 18:39
Hey @Makman2 didn't coala used to have this system where other developers could ack a PR too?
Mischa Krüger
@Makman2
Feb 20 2018 18:40
You can still "ack" but without triggering the gitmate approval
And that wouldn't help, i have to review all of them anyway to be sure reviews are proper
I mean it wouldn't help to allow normal devs to use ack
To actually make CI green
Nityesh Agarwal
@nityeshaga
Feb 20 2018 18:42
Okay yeah that makes sense :p