Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 11:39
    Fluffyrodent commented #2844
  • 11:38
    Fluffyrodent commented #2844
  • 11:37
    Fluffyrodent commented #2844
  • 11:33
    Fluffyrodent commented #2844
  • 11:32
    Fluffyrodent commented #2844
  • 11:30
    Fluffyrodent commented #2844
  • 11:29
    Fluffyrodent commented #2844
  • 11:29
    Fluffyrodent commented #2844
  • 11:28
    Fluffyrodent commented #2844
  • 10:59
    codecov[bot] commented #3230
  • 10:57
    codecov[bot] commented #3230
  • 10:51
    codecov[bot] commented #3230
  • 10:51
    SchoolGuy synchronize #3230
  • 10:51

    SchoolGuy on redundant-directory-creation

    distro_build_configs: Add corre… (compare)

  • 10:46
    codecov[bot] commented #3230
  • 10:41
    codecov[bot] commented #3230
  • 10:39
    codecov[bot] commented #3230
  • 10:39
    SchoolGuy synchronize #3230
  • 10:39

    SchoolGuy on redundant-directory-creation

    system-tests: Add SUSE webdir t… (compare)

  • 10:31
    codecov[bot] commented #3230
consus
@consus:matrix.org
[m]
I want to use this: https://github.com/marketplace/actions/test-reporter for report generation
egotthold
@egotthold:matrix.org
[m]
consus: That looks great! Let's do it!
consus
@consus:matrix.org
[m]
For some reason new workflow is not kicking in
I'm pretty sure I'm doing something wrong with Actions
https://github.com/cobbler/cobbler/blob/bb4cf6749cbff22fdde8927c3dcc01a4adeb6fa3/.github/workflows/system_testing_report.yml
This one
egotthold
@egotthold:matrix.org
[m]
I believe the reason is the types: you set.
It might be that completed is only set on successfull runs.
consus
@consus:matrix.org
[m]
The docs say that completion == finished
A workflow run is triggered regardless of the result of the previous workflow.
The docs for test reporter mention that public forks are not entitled to create check jobs
And the whole reason for a separate workflow is to put it in master branch
egotthold
@egotthold:matrix.org
[m]
Note: This event will only trigger a workflow run if the workflow file is on the default branch.
consus
@consus:matrix.org
[m]
Yep
I was expecting a failure
egotthold
@egotthold:matrix.org
[m]
Should we merge and then check if it is working?
consus
@consus:matrix.org
[m]
But it's just silently ignored
If that's okay with you
egotthold
@egotthold:matrix.org
[m]
Is there a reason why we can't put this into a single workflow?
Nvm saw the example from the Action.
So yeah. Cleanup what you want and then I'll merge. If it fails we fix it with a followup PR. Not nice but we have no other choice afaik.
consus
@consus:matrix.org
[m]
I expect this to work on master
So we can do this right ahead
egotthold
@egotthold:matrix.org
[m]
Okay. Git is clean in your eyes? consus
consus
@consus:matrix.org
[m]
Yeah
egotthold
@egotthold:matrix.org
[m]
consus still not triggered
consus
@consus:matrix.org
[m]
https://github.com/cobbler/cobbler/runs/3965159754?check_suite_focus=true
it kinda is
but failed
egotthold
@egotthold:matrix.org
[m]
What
Ah okay
Yeah but that is a problem with XML?
consus
@consus:matrix.org
[m]
I think so
Found it: The outer<testsuites> is not expected and causes issues. trimming those and it works.
Hmm
I guess that's the problem
Someone being naughty and not follows the spec
I'm not sure who though xD
k, should be fine now
consus
@consus:matrix.org
[m]
Nah, it requires some attributes that should be optional
Goddamit
egotthold
@egotthold:matrix.org
[m]
Okay. Just ping me once it is ready.
consus
@consus:matrix.org
[m]
Screw that
It seems that Github Actions sucks dick
The test report cannot be bigger than 65k bytes and no screenshots, no links, nothing
As a bonus Check Jobs cannot be properly positioned in multi-workflow build
So the result will pop under random workflows
I suggest Allure and GitHub pages
We can paste the unit test results there too
egotthold
@egotthold:matrix.org
[m]
consus How did you come to that conclusion with 65kb? It seems rather small.