Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Ying Li
    @cyli
    Right, I get the partial covering - I definitely appreciate it. It's the thing that branches
    Steve Peak
    @stevepeak

    Preferably:

    + varname := StructType{
    +     Field1: 1,
    +    Field2: 2,
    }

    3 stmts. But It 100% depends on coverage data presented

    Given that line 2 can be an expression of the following field1: (a > 1) ? 2 : 0,
    This all comes down to the language and what coverage reports they create.
    Ying Li
    @cyli
    @stevepeak Go doesn't seem to be counting line coverage, it's counting statement coverage, so a user formatting their code differently (wrapping at 80 columns instead of letting lines go on forever, for instance) don't have different coverage percentages than those who don't format their code nicely.
    Steve Peak
    @stevepeak
    Furthermore: I'm open to specific suggestions for Go coverage. Soon Codecov will overlay intensity (just like gocov.html does) but we still want to record entire lines because a lot of Codecov features rely on knowing line coverage.
    Ying Li
    @cyli
    I think go was counting that example I gave as a single statement. If there was an if in there, it'd probably count it as 2? I'm not sure
    Steve Peak
    @stevepeak
    Depends on what Go coverage report says.
    Ying Li
    @cyli
    I don't have an exact sample of that to say :D

    but it counts:

    func(params) returnVals {
       if ...

    as 2 statements

    Steve Peak
    @stevepeak
    Right that is a good thing
    Ying Li
    @cyli
    yes
    Steve Peak
    @stevepeak
    I think the first steps to improve this are (1) removing coverage on empty lines (2) remove coverage for lines that contain only }
    Then we can (3) introduce the intensity
    from there we can review the State of Go Coverage and adjust accordingly ;)
    brb 15m
    Ying Li
    @cyli
    Sounds good, thanks for all the help :)
    Ying Li
    @cyli
    Many apologies for the confusion - I see what you are getting at now :D Thanks for taking the time to explain!
    Nicolas Ruflin
    @ruflin
    @stevepeak coverage reports look good again. thanks for the fix
    Steve Peak
    @stevepeak
    @ruflin thank you :) very happy to help out!
    I'm going to make this week to fix the empty line issue. I'll ping you when I've got it in staging to run some simulations. :+1:
    Nicolas Ruflin
    @ruflin
    :+1:
    Steve Peak
    @stevepeak
    codecov/codecov-bash@28e49aa Server side will handle the reduction of data
    Nicolas Ruflin
    @ruflin
    @stevepeak was that for me?
    Steve Peak
    @stevepeak
    Will be soon :) I'm making progress on this. Hitting 3 x :bird: with one :rocket:
    Nicolas Ruflin
    @ruflin
    :-D
    Steve Peak
    @stevepeak
    @ruflin do you have a repo I can test this on? Thank you!
    Steve Peak
    @stevepeak
    We can give this a shot with the upcoming bash uploader: bash <(curl -s https://raw.githubusercontent.com/codecov/codecov-bash/master/codecov)
    Nicolas Ruflin
    @ruflin
    sure, will run it on filebeat
    @stevepeak can I use the same token as before?
    same command -> heroku url?
    Steve Peak
    @stevepeak
    @ruflin you can submit the reports to codecov.io the changes were deployed. Thanks!
    Nicolas Ruflin
    @ruflin
    same token as last time?

    / | | |
    | | _
    | | _
    | | / \ / _` |/ \/
    / _ \ \ / /
    | || (_) | (| | / (| () \ V /
    __\/ _,|_|___/ \/
    tbd

    (url) https://codecov.io
    (root) .
    ==> No CI detected, using git/mercurial for branch and commit sha.
    ==> Targeting specific file(s)
    ==> Detecting git/mercurial file structure
    ==> Reading reports

    • coverage/full.cov bytes=231798
      ==> Fixing report lines
      (query) package=bash-tbd&branch=master&commit=89410957be0163fe2e999cab0efffdeb6ab926c5&build=&build_url=&slug=&service=&pr=&job=&token=7bf718b3-97a6-4323-be9f-226f4b80aae4
      ==> Uploading reports
      Pinging Codecov

    Reports queued to HTTP 400 HTTPError

    Repository not found. Please provide a repository upload token.

    I think I need a new token
    @stevepeak
    Steve Peak
    @stevepeak
    @ruflin can you see the token here: https://codecov.io/github/elastic/filebeat/features/token
    Nicolas Ruflin
    @ruflin
    @stevepeak I'm doing some refactoring with Elastica. All files are now in sub folders and there are multiple files: build/coverage/*-coverage.xml
    What should I define with the -f param. The folder or a pattern?
    Steve Peak
    @stevepeak
    @ruflin if build/coverage is folder that exists (or produced) within the project then the uploader will find files with that pattern. The -f options takes a single file only atm.
    @cyli ^^
    Note all the -1 (will remove shortly) these lines where the ones I've parsed out because they are empty.
    Steve Peak
    @stevepeak
    Comment are getting the axe as well. You can skip thees adjustments by -X fix if they are not desired: http://bit.ly/1O4eBpt
    But IMO: empty lines, comments, and ending brackets should not be considered as lines covered. As Codecov grows it will be important to have this distinction.
    Nicolas Ruflin
    @ruflin
    @stevepeak it finds the files as expected :+1:
    Alex Bjørlig
    @alexbjorlig
    Hi guys. I am thinking about adding codecov to my Angular5 CLI project - do you have any links how to do the setup?
    罗登
    @RonDen
    Is there any one know how to use codecov for django project
    I use the command python manage.py test, but I don't kown how to report it to codecov