These are chat archives for codefellows/Mentor-Match

13th
Nov 2014
Philip Q Nguyen
@philipqnguyen
Nov 13 2014 00:08
@tonycchung thanks! We indeed completed the features for users to accept and decline friendship requests. The favorites features is something we have not worked on (We probably deleted that in our efforts to trim off the app =X). Friendship model was intitially confusing, but we eventually figured it out. But if you want to work on the splash screen or add the favorites feature, go ahead!
Reed Nelson-Saunders
@reedns
Nov 13 2014 00:09
I upgraded to 4.2. The tests pass with a bunch of deprecation warnings about using configuring ActiveJob with sidekiq. It seems to work fine locally
Philip Q Nguyen
@philipqnguyen
Nov 13 2014 01:07
I merged ur pr @reedns , additionally can u check my PR for the safari and mozilla fix
Reed Nelson-Saunders
@reedns
Nov 13 2014 01:12
Cool, will do.
Merged it.
Reed Nelson-Saunders
@reedns
Nov 13 2014 01:25
I pushed it to production
Philip Q Nguyen
@philipqnguyen
Nov 13 2014 01:52
Cool man
Tony Chung
@tonycchung
Nov 13 2014 05:52
@philipqnguyen Thanks! I could probably get the favorites done - what do you guys need for the splash screen?
Philip Q Nguyen
@philipqnguyen
Nov 13 2014 05:59
I'm not sure. I'll be in school tomorrow though and talk more to brook and other concerned people and figure what needs attention. Also my # is 775-771-0110 if you need it.
Tony Chung
@tonycchung
Nov 13 2014 06:01
Cool man thanks!
Brook Riggio
@brookr
Nov 13 2014 18:10
Splash screen just needs a different image. Either one of the 2 photos would work fine, if those files are available.
Brook Riggio
@brookr
Nov 13 2014 18:40
Do you have New Relic running a ping-check on the production server, @reedns? That will keep heorku from falling asleep.
Brook Riggio
@brookr
Nov 13 2014 19:19
What ruby/rails version is on production now?
Philip Q Nguyen
@philipqnguyen
Nov 13 2014 19:22
rails is 4.2.0.beta4
Brook Riggio
@brookr
Nov 13 2014 19:23
thanks, ruby version?
Philip Q Nguyen
@philipqnguyen
Nov 13 2014 19:23
2.1.2... i think
Actually it is not specified in the gemfile
I just checked heroku, we are running ruby 2.0.0p594 in production
Brook Riggio
@brookr
Nov 13 2014 19:49
Specify it in the gemfile, please, and in a .ruby-version file.
Looks like Heroku supports 2.1.5, which is great.
I bet there is some way to have the gemfile read from the .ruby-versions file, so you can maintain it in just one place.
Reed Nelson-Saunders
@reedns
Nov 13 2014 19:52
I don't have New Relic running a ping-check. Are the New Relic docs the place to look for how to set that up?
Brook Riggio
@brookr
Nov 13 2014 19:56
You can probably find it in the dashboard/settings for the NR add on.
Reed Nelson-Saunders
@reedns
Nov 13 2014 20:08
I think it's set up now.
Brook Riggio
@brookr
Nov 13 2014 20:08
Nice. Let's watch out to see if any of us can catch it sleeping, to ensure it works.
Reed Nelson-Saunders
@reedns
Nov 13 2014 20:10
I will keep an eye on it.
Philip Q Nguyen
@philipqnguyen
Nov 13 2014 21:02
For some reason, I cannot install 2.1.5 from rbenv, is anyone having this issue?
Philip Q Nguyen
@philipqnguyen
Nov 13 2014 21:11
Our test coverage increased to 97.1%!
Reed Nelson-Saunders
@reedns
Nov 13 2014 21:45
I have rvm. Nice! Did you add more tests?
Philip Q Nguyen
@philipqnguyen
Nov 13 2014 22:23
@tonycchung 's PR bumped up our coverage
Tony Chung
@tonycchung
Nov 13 2014 22:25
haha nice. it was just one test and deleted some unused fixtures?
Philip Q Nguyen
@philipqnguyen
Nov 13 2014 22:33
:+1: