Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Philip Q Nguyen
    @philipqnguyen
    I have a PR up to fix up some details for mentor match. @reedns do you want to review that?
    Reed Nelson-Saunders
    @reedns
    @philipqnguyen just merged your pr. @brookr I used Sidekiq with ActiveJob for the background jobs. I can switch to sucker_punch tomorrow if you think thats the preferred approach.
    Brook Riggio
    @brookr
    @reedns I'd love to hear your thoughts on differences in the approach. Some comments indicated some problems with holding open database connections?
    Reed Nelson-Saunders
    @reedns
    @brookr for a small app like this where we are using only one dyno sucker_punch does seem like a better option. You don't have to configure unicorn to spawn workers or ensure redis doesn't hit the connection limit. Honestly I stuck with sidekiq out of laziness. It was already implemented I just needed to tweak it. Since we upgraded to Rails 4.2 after setting up the background jobs I didn't look into what ActiveJob was; I only figured out how to configure ActiveJob to use sidekiq. Now that I have read a little bit more about ActiveJob it seems conceptually similar sucker_punch in that they both perform the jobs in a single rails process itself instead of a separate process.
    I am heading into CodeFellows this afternoon also.
    Reed Nelson-Saunders
    @reedns
    Also it seems like sidekiq would probably be better suited for larger apps with complicated background tasks where you need multiple dynos.
    Brook Riggio
    @brookr
    Sounds like a good analysis, thanks, Reed.
    Reed Nelson-Saunders
    @reedns
    @philipqnguyen I made a pr for sucker_punch
    can you review it when you get a chance?
    Philip Q Nguyen
    @philipqnguyen
    :+1:
    Brook Riggio
    @brookr
    Gents: Will, our CTO, will be evaluating the MM app tomorrow, to verify it is ready to put in front of partners.
    Can you please give it a thurough review this afternoon/evening? I really want this to get the greenlight, but it has to be professionally presentable before we can turn it on.
    Philip Q Nguyen
    @philipqnguyen
    awesome. There's a lot of changes not on production, I'll do that in a min.
    Clarify, I'll push them to production in a min
    Brook Riggio
    @brookr
    Thanks!
    Marco Lindsay
    @Marco-Lindsay
    It's great you guys got it this far 👍
    Reed Nelson-Saunders
    @reedns
    I am really sick today with a stomach bug. I can take a look but probably won't be much help. :worried:
    Philip Q Nguyen
    @philipqnguyen
    No problem @reedns ! @brookr or @reedns (if you are up to it) I just made a major PR, can you take a look at the and accept the change if it looks good?
    Reed Nelson-Saunders
    @reedns
    I can take a look now
    One question. Is there any reason to keep the dashboard path?
    As a route
    Philip Q Nguyen
    @philipqnguyen
    good point, absolutely no reason at all
    I'll make that change now and push it to the PR
    dashboard_path now removed... you should see that change on the PR as well
    Reed Nelson-Saunders
    @reedns
    Merge it
    *Merged
    Philip Q Nguyen
    @philipqnguyen
    Production now has latest changes =)
    Brook Riggio
    @brookr
    What's the status of #7? We need to make sign-in and account creation as easy as possible for Mentors.
    Philip Q Nguyen
    @philipqnguyen
    We havent worked on that yet...
    Brook Riggio
    @brookr
    Specificially, if they can sign in with a click or two, and we can grab basic LinkedIn data (which will have current company, email, etc)...
    Ah, ha.
    Brook Riggio
    @brookr
    That'd be a killer feature. I'm not sure it's needed right now, stay tuned.
    Philip Q Nguyen
    @philipqnguyen
    ok
    Brook Riggio
    @brookr
    It looks like we can move forward with out it.
    The last big thing may just be ensuring the app doesn't look like crap on mobile. :]
    Not sure if Gina has found UX help for that?
    Philip Q Nguyen
    @philipqnguyen
    It looks like crap on mobile right now
    crap
    Lol
    Is it possible to simply grid up the html as a quick fix?
    @brookr
    Brook Riggio
    @brookr
    I'm not sure how the flexbox system will work with grids. Maybe @bwstud could advise on a short/effective path to something reasonable?
    Brian Studwell
    @bwstud
    @brookr @philipqnguyen flexbox can work with a grid. None was in place for that design, so implementing one now may not be the fastest path.
    Brian Studwell
    @bwstud
    I'm looking at your production app on Heroku from my phone (Android). I've got a couple of other projects I'm working on for school. What's your timeframe for making this presentable?
    Brook Riggio
    @brookr
    Know you are busy, @bwstud. Is there some guidance you can give on how to approach it? We'll try to find a UX volunteer who can hack on it a bit.
    Brian Studwell
    @bwstud

    @brookr I think the most glaring problems are the layouts not covering the window on several screens. That's where I would start.

    On the landing page fixing the secondary image alignments and either reintroducing some text, or removing that explanatory section entirely would improve the appearance. The white button text is difficult to read when it creeps up into the light portion of the image. Fixing the size of the about match button would be good, too.

    The account creation pages look pretty good. The word, "submit" needs to be re-centered vertically in it's button.

    When viewing your profile the "other technologies" label should align-right in accordance with the other three fields, and the link to gravatar should flow under the placeholder (and shouldn't appear if you have one).

    The user cards are too small for mobile. They need to be enlarged, maybe only show one at a time and provide pagination. Ryan had added a paginated mechanism previously.
    That stuff would get you somewhere
    I hope it's helpful. Sorry I can't be of more use.
    Brook Riggio
    @brookr
    Thanks, that's definitely helpful! We'll see what we can do with it!