These are chat archives for codexa/firetext

10th
Feb 2015
Joshua Smith
@joshua-s
Feb 10 2015 02:20
Do you think we could split the document actions into two sections?
To make it less overwhelming ?
Daniel Huigens
@twiss
Feb 10 2015 02:23
Yep, good idea
Maybe separate create+import+open from the rest
Joshua Smith
@joshua-s
Feb 10 2015 02:24
So, actions on this document, and actions on other documents
Daniel Huigens
@twiss
Feb 10 2015 02:25
Or export+print from the rest
Yep
Joshua Smith
@joshua-s
Feb 10 2015 02:25
Sounds good. I'll put it in this week.
(it is minor)
Daniel Huigens
@twiss
Feb 10 2015 02:26
I came up with a way to exempt images from the filter, but it's slow and triggers tiling bugs in Chrome (parts of the document don't show up)
Basically, enumerate all images and pass the locations of them to svg
Joshua Smith
@joshua-s
Feb 10 2015 02:27
hmm, do you have it in a branch?
Daniel Huigens
@twiss
Feb 10 2015 02:28
nightmode-invert-2
Also, I've pushed an updated version of the original approach to nightmode-invert
So if you want that maybe you could test if scrolling works with that
Daniel Huigens
@twiss
Feb 10 2015 02:36
nightmode-invert-2 is in twiss/firetext, and doesn't work in Firefox atm
before it I had a proof of concept which did work in Firefox, though
Joshua Smith
@joshua-s
Feb 10 2015 02:36
k
Whatever we land should work in Firefox
Daniel Huigens
@twiss
Feb 10 2015 02:38
Yep, we could land nightmode-invert and at some point in the future land nightmode-invert-2
Unless we get it to work now, ofc
Joshua Smith
@joshua-s
Feb 10 2015 02:42
So yeah, nightmode-invert works fine on my device
Let's land that
Daniel Huigens
@twiss
Feb 10 2015 02:44
Alright, want me to merge? odt is ready as well
Joshua Smith
@joshua-s
Feb 10 2015 02:44
Sure!
Daniel Huigens
@twiss
Feb 10 2015 03:04
Cool! We're feature complete.
In what browser was the print button disabled?
Joshua Smith
@joshua-s
Feb 10 2015 03:05
Firefox Desktop
I am working on #192. I don't know if it will be done in time
Daniel Huigens
@twiss
Feb 10 2015 03:08
Alright
Print button works for me though
If you click inspect element, does the iframe have height?
Joshua Smith
@joshua-s
Feb 10 2015 04:02
The importing issue was a problem with my browser setup
Joshua Smith
@joshua-s
Feb 10 2015 04:59
@twiss can you review #281?
There is one small issue that I can see: updating the document in design mode messes up indentation
Is that serious enough to block merge?
Daniel Huigens
@twiss
Feb 10 2015 05:03
Don't think so, that's a separate issue
Joshua Smith
@joshua-s
Feb 10 2015 05:04
Great!
So, it is ready for merge?
Daniel Huigens
@twiss
Feb 10 2015 05:14
If you want I will look at it more tomorrow, but I don't really expect anything big
So you could merge it now if you prefer
Joshua Smith
@joshua-s
Feb 10 2015 05:15
Ok. I'll wait until tomorrow.
Daniel Huigens
@twiss
Feb 10 2015 05:16
Alright
Joshua Smith
@joshua-s
Feb 10 2015 13:18
hmm, scrolling isn't working on mobile
Joshua Smith
@joshua-s
Feb 10 2015 18:17
Congrats all! We have fixed 47 issues in this release!
Special thanks to @twiss who fixed a great deal of them