These are chat archives for codexa/firetext

27th
May 2015
Joshua Smith
@joshua-s
May 27 2015 00:24
Do you think we should release the next version as 0.5 or 0.4.1?
Daniel Huigens
@twiss
May 27 2015 00:29
No idea, you wanted to just add locales right? Maybe 0.4.1
Joshua Smith
@joshua-s
May 27 2015 00:29
Well, I have almost gotten OAuth2 working for dropbox, and your PRs are nice
So, might as well include more than just locales
Daniel Huigens
@twiss
May 27 2015 00:30
Also, why don't you want to add language strings? Is it because fallback to english doesn't work?
Or is that fixed now?
Joshua Smith
@joshua-s
May 27 2015 00:30
It works
Daniel Huigens
@twiss
May 27 2015 00:30
The update fixed it?
Joshua Smith
@joshua-s
May 27 2015 00:31
Yeah. Localizers generally don't like strings thrown at them less than a month before a release
Daniel Huigens
@twiss
May 27 2015 00:31
I see
Joshua Smith
@joshua-s
May 27 2015 00:31
(Mozilla lost a few over that)
Daniel Huigens
@twiss
May 27 2015 00:31
Well, we could release an update and then merge
Joshua Smith
@joshua-s
May 27 2015 00:31
Yup
Daniel Huigens
@twiss
May 27 2015 00:33

I have almost gotten OAuth2 working for dropbox

Does that mean Firetext will actually finally work on Firefox desktop? :)

Joshua Smith
@joshua-s
May 27 2015 00:33
Maybe, I don't know for sure
It will be less in danger of breaking for sure
Daniel Huigens
@twiss
May 27 2015 00:33
Alright, cool
Joshua Smith
@joshua-s
May 27 2015 01:21
The code is in the dropbox-oauth2 branch
It was built on your PR
One issue: it seems to authenticate fine, but the popup closes and nothing happens
Any ideas?
Joshua Smith
@joshua-s
May 27 2015 02:06
Ok, so in chrome we get this error: Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('https://codexa.github.io') does not match the recipient window's origin ('http://codexa.bugs3.com').
Joshua Smith
@joshua-s
May 27 2015 02:13
Do you think changing the origin in https://github.com/dropbox/dropbox-js/blob/stable/src/auth_driver/browser.coffee#L476 to * would mitigate this?
Joshua Smith
@joshua-s
May 27 2015 02:43
IT WORKED :)
Daniel Huigens
@twiss
May 27 2015 10:32
At first thought that doesn't sound like a good idea security wise though, are you sure there isn't an issue?
Joshua Smith
@joshua-s
May 27 2015 12:42
Hmm, it really isn't
a good idea
I just don't know how else to do it...
Desktop Firefox app - does it have a url???
Firefox OS app - the origin is constantly changing, right? (e.g. app://0123456789.gaiamobile.org/)
Android Firefox app - does it have a url???
Testing - localhost or file:///
Daniel Huigens
@twiss
May 27 2015 12:56
Judging by the error message it's not about the url of the app but of your hosting, e.g. https://codexa.github.io and http://codexa.bugs3.com. If you move everything to the same domain it might work
Joshua Smith
@joshua-s
May 27 2015 12:58
codexa.bugs3.com was where I hosted a test version of the app
The packaged app is hosted in some mystery location on the device that one cannot know before it is installed
Everything works until the point where the popup needs to postMessage back to the app
Daniel Huigens
@twiss
May 27 2015 13:02
oh, right
and why can't the popup be "hosted" inside the app?
Joshua Smith
@joshua-s
May 27 2015 13:06
It needs to be on a known https origin
It needs to be on a whitelisted https origin
Joshua Smith
@joshua-s
May 27 2015 17:30
@twiss what do you think about #294?
Daniel Huigens
@twiss
May 27 2015 21:43
To me, Connect to Dropbox sounds like the correct phrase, on the other hand, Use Dropbox is shorter and thus looks better. Personally I don't mind to postpone it after this release, although the same release as OAuth2 would make sense (but it isn't important)
Do you think #293 would be acceptable for merge after release?
Daniel Huigens
@twiss
May 27 2015 21:49
Also, if you'd agree with the approach of merging after release, personally I'd like to have release channels, e.g. merge into the release branch now and cherry pick any later commits you want in, and freely merge into develop