These are chat archives for codexa/firetext

28th
May 2015
Joshua Smith
@joshua-s
May 28 2015 01:12
What about using Use Dropbox for this release, and changing that string to Connect Dropbox in future releases?
#293 would be acceptable for merge (although we still might want to strategize ways to use less strings)
That strategy sounds good, although we might run into problems with the different commit histories
Daniel Huigens
@twiss
May 28 2015 01:16
Right
Joshua Smith
@joshua-s
May 28 2015 01:19

Do you think it would create problems? E.g. one branch's history (in order of increasing recency) is:
Commit A
Commit B
Commit C

If you merge commit C, then B into release, and then merge commit A later, release would have the history:
Commit C
Commit B
Commit A

Daniel Huigens
@twiss
May 28 2015 01:19
Idk, does Use Dropbox mean to you "access your documents in Dropbox"?
Joshua Smith
@joshua-s
May 28 2015 01:19
Yes, although Connect Dropbox is definitely better
Daniel Huigens
@twiss
May 28 2015 01:23
Well, it seems like a bad idea to write one thing today and another tomorrow, otoh, our desktop user base is very small so far, so it doesn't really matter either way
Joshua Smith
@joshua-s
May 28 2015 01:24
So, could we get away with changing the string in the en-us locale and shipping without waiting for other locales?
(which will use the translation of Use Dropbox instead)
Daniel Huigens
@twiss
May 28 2015 01:25
Well, do you want to switch the other use of Use Dropbox to Connect to Dropbox as well?
Joshua Smith
@joshua-s
May 28 2015 01:25
I think both should be the same
(use the same l10n id)
Daniel Huigens
@twiss
May 28 2015 01:25
Yeah
The only thing is it being a setting rather than an action button Use Dropbox does make sense
Maybe we could make it Connect to Dropbox / Disconnect from Dropbox
Buttons
The setting is nicer though
Joshua Smith
@joshua-s
May 28 2015 01:27
Yeah, and it uses less l10n
Although the connect/disconnect is truer to what is actually happening
Daniel Huigens
@twiss
May 28 2015 01:28
Let's just change the l10n to Connect to Dropbox, I think it would make enough sense in both places
Joshua Smith
@joshua-s
May 28 2015 01:29
ok, so just change the use-dropbox string in en.app.properties to "Connect Dropbox"
Daniel Huigens
@twiss
May 28 2015 01:31
yes, but isn't the phrase "Connect to"?
Joshua Smith
@joshua-s
May 28 2015 01:31
That would work
Daniel Huigens
@twiss
May 28 2015 01:33
I like this chat, but I suspect it's not really accessible for any more than two people
It doesn't have a topic or anything, and a lot of content to catch up to
Joshua Smith
@joshua-s
May 28 2015 01:34
Yeah :/ Nobody else seems to like to use it
Do you have a better idea?
Daniel Huigens
@twiss
May 28 2015 01:36
Not really, mailing lists are a bit old fashioned and therefore inaccessible as well
It would be nice to have issue-specific chat
Daniel Huigens
@twiss
May 28 2015 01:42
E.g. like comments, but... smaller
Joshua Smith
@joshua-s
May 28 2015 01:47
Less "difficult"
Daniel Huigens
@twiss
May 28 2015 01:48
Yes. gitter does actually have a topic
Joshua Smith
@joshua-s
May 28 2015 01:49
Ooh cool!
IMO gitter is way better than irc
Daniel Huigens
@twiss
May 28 2015 01:50
I haven't used irc much, this is more accessible at least
The topic is not very prominent though
twiss @twiss
Joshua Smith
@joshua-s
May 28 2015 01:52
What is that ^
Daniel Huigens
@twiss
May 28 2015 01:52
./me
Joshua Smith
@joshua-s
May 28 2015 01:53
This message was deleted
twiss @twiss without the dot first time
joshua-s @joshua-s no dot
joshua-s @joshua-s is excited
Daniel Huigens
@twiss
May 28 2015 01:53
well, we could use this
joshua-s @joshua-s changed the topic to issue #300
Daniel Huigens
@twiss
May 28 2015 01:54
yes
what about it? :p
jk
Joshua Smith
@joshua-s
May 28 2015 01:55
So, in issue #174, we talked about using a regular directory structure
With different storage systems as the top level storage "disks" if you will
Daniel Huigens
@twiss
May 28 2015 01:56
Oh, right
Joshua Smith
@joshua-s
May 28 2015 01:56
Do you think #300 is a simpler approach?
It might be easier to find documents
Daniel Huigens
@twiss
May 28 2015 01:58
Well, the most urgent problem #174 would solve is having too many documents
Joshua Smith
@joshua-s
May 28 2015 01:58
Yeah
Daniel Huigens
@twiss
May 28 2015 01:58
Which can have multiple causes/solutions, e.g. in Firefox Android app runtime we're simply showing the wrong documents
Another solution would be an infinite scroll sort of thing
Joshua Smith
@joshua-s
May 28 2015 01:59
Yup.
I don't know how devicestorage would work with that
It is really bare-bones
Daniel Huigens
@twiss
May 28 2015 02:00
It wouldn't, the only performance advantage if any would be in the DOM
Same with fixing #174
Joshua Smith
@joshua-s
May 28 2015 02:00
Yeah, they desparately need shallow enumeration
Anyways, do you think we could merge the two strategies?
Daniel Huigens
@twiss
May 28 2015 02:01
Idk, there's still things on both sides that can be done to improve performance
Uh,
Joshua Smith
@joshua-s
May 28 2015 02:02
E.g. have a #300 style recents "storage"
Daniel Huigens
@twiss
May 28 2015 02:03
Well, we could have a dropdown or a menu or something to switch between the different modes
If that qualifies for merging
Joshua Smith
@joshua-s
May 28 2015 02:04
That might work
Or, a button at the top (similar to the first-use buttons)
Daniel Huigens
@twiss
May 28 2015 02:05
I feel like whichever we do we should 1) make it persistent and 2) try to make the default actually as useful as possible regardless of the other modes
Joshua Smith
@joshua-s
May 28 2015 02:06
:+1:
joshua-s @joshua-s changed topic to dropbox oauth2
Joshua Smith
@joshua-s
May 28 2015 02:16
So, should we merge regardless of the security issue?
IIRC the old oauth script does not check origin
Daniel Huigens
@twiss
May 28 2015 02:33
That's true, but they hint at it being OAuth2 specific: dropbox/dropbox-js@9674840
Joshua Smith
@joshua-s
May 28 2015 02:38
Hmm
Maybe pass along the origin of the app to the popup somehow
And, use that as "*"
Although, that doesn't seem much more secure
It'd be so much easier to host Firetext, but I don't think we can do that atm
Daniel Huigens
@twiss
May 28 2015 17:54
So, I found two manifest settings that both can be used to solve this: origin and redirects. redirects sounds like the easier of the two. However, the problem with both of these is that they are Firefox OS specific and make it hard or impossible to use Firetext on another or no domain. OTOH, I don't know another solution.
Joshua Smith
@joshua-s
May 28 2015 18:03
This message was deleted
This message was deleted
This message was deleted
Actually, hmm
Firefox Desktop and Firefox Android don't follow origin/redirects, right?
Daniel Huigens
@twiss
May 28 2015 18:08
I think so
Daniel Huigens
@twiss
May 28 2015 18:15
I think they do, I mean
Joshua Smith
@joshua-s
May 28 2015 18:28
I wish there was a way to test packaged apps on desktop
Daniel Huigens
@twiss
May 28 2015 18:49
There is
Also, Firefox's created a firetext dir somewhere on your computer now with a zip inside, you can edit that to debug the desktop webapprt
Joshua Smith
@joshua-s
May 28 2015 18:58
Oh, right