These are chat archives for codexa/firetext

2nd
Jul 2015
Josh Smith
@joshua-s
Jul 02 2015 00:41
That would work
Josh Smith
@joshua-s
Jul 02 2015 04:29
Fixed!
Daniel Huigens
@twiss
Jul 02 2015 12:12
:+1:
Josh Smith
@joshua-s
Jul 02 2015 13:43
Is there some way we could avoid eval here?
Daniel Huigens
@twiss
Jul 02 2015 13:57
not sure, why?
Josh Smith
@joshua-s
Jul 02 2015 13:59
I'm trying to fix csp errors that could be the source of breakage on 1.1
eval is not allowed
Daniel Huigens
@twiss
Jul 02 2015 14:31
No, I don't know of another way that works in Firefox. You could remove that line to see if it fixes anything though
Josh Smith
@joshua-s
Jul 02 2015 14:50
It didn't fix it :/
Daniel Huigens
@twiss
Jul 02 2015 15:17
I've got the simulator to work, thanks. If you press refresh, errors show up
It has something to do with the template element support missing: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/template
At least the translationElement error, don't know if that's why there's a blank screen
Josh Smith
@joshua-s
Jul 02 2015 15:20
So, it is because of l10n.js
Daniel Huigens
@twiss
Jul 02 2015 15:35
Yes, it does indeed cause the blank screen
Daniel Huigens
@twiss
Jul 02 2015 15:37
The second problem is that editor.html never finishes loading
I don't think that's sufficient since it doesn't patch document.createElement
Daniel Huigens
@twiss
Jul 02 2015 15:40
Same thing
The only thing that's needed is setting .content = document.createDocumentFragment()
Daniel Huigens
@twiss
Jul 02 2015 15:54
Maybe the editor.html thing is simulator specific? I don't know. Want me to create a PR or you'll figure the template thing out?
Josh Smith
@joshua-s
Jul 02 2015 16:02
I am working on the template issue (found polymer's polyfill)
If you want to make a PR (or push to master), feel free
Daniel Huigens
@twiss
Jul 02 2015 16:19
Created a PR. It's not really a polyfill but oh well, it's simpler this way.
Josh Smith
@joshua-s
Jul 02 2015 16:19
About #311. It is good, but I am a little scared to modify l10n.js (if we update, we'll lose it)
Daniel Huigens
@twiss
Jul 02 2015 16:20
Right, but it was already modified
Josh Smith
@joshua-s
Jul 02 2015 16:20
It is simpler though
Daniel Huigens
@twiss
Jul 02 2015 16:20
Less intrusively so though
Daniel Huigens
@twiss
Jul 02 2015 16:26
Where do you want to have a polyfill? firetext.js or a new file?
Josh Smith
@joshua-s
Jul 02 2015 16:26
A new file
Oh, I forgot I modified it
(To support an unsupported rtl locale)
Nevermind then
Daniel Huigens
@twiss
Jul 02 2015 16:28
Alright
Josh Smith
@joshua-s
Jul 02 2015 16:45
It loads now. I am investigating dropbox oauth breakage
Also, the polyfill appears to have broken html l10n strings
Josh Smith
@joshua-s
Jul 02 2015 16:50
E.g. in settings where one has Use <b>Dropbox</b>
Daniel Huigens
@twiss
Jul 02 2015 18:23
Hmm, strange, that worked for me
Josh Smith
@joshua-s
Jul 02 2015 18:36
Which worked?
Daniel Huigens
@twiss
Jul 02 2015 18:45
I looked at the settings and all the strings were there
Josh Smith
@joshua-s
Jul 02 2015 18:45
In their complete form?
Daniel Huigens
@twiss
Jul 02 2015 18:52
Oh, no, you're right. Didn't notice that.
Daniel Huigens
@twiss
Jul 02 2015 20:25
Can I force push a fix to develop?
Josh Smith
@joshua-s
Jul 02 2015 20:25
Sure
Daniel Huigens
@twiss
Jul 02 2015 20:42
l10n.js also gives TypeError: targets.forEach is not a function, which is easily fixable, but I don't think anything is actually broken. It handles the case where html changes to include new untranslated stuff
Josh Smith
@joshua-s
Jul 02 2015 22:23
What exactly did you do in the push?
Daniel Huigens
@twiss
Jul 02 2015 22:26
I messed up the first time I pushed, sorry. The second time I pushed develop from before the merge plus the polyfill commit. No merge commit.