These are chat archives for codexa/firetext

23rd
Sep 2015
Joshua Smith
@joshua-s
Sep 23 2015 03:28
Is the file preview option worth the code complexity and performance impact?
I introduced the pref a while ago so that we could start to phase it out if we want. Should I switch it off by default and collect usage data first?
Daniel Huigens
@twiss
Sep 23 2015 10:18
We have a pref to toggle file previews?
Daniel Huigens
@twiss
Sep 23 2015 10:23
Also I don't mean creating actual thumbnails, just putting the doc in an iframe and scaling down. But yeah at least we shouldn't recreate the doc list when you close a document, and preferably we shouldn't recreate all of the iframes when a document is added or something.
Or yeah, we could render the document to a canvas, that's actually possible. Then we could cache all you want
Joshua Smith
@joshua-s
Sep 23 2015 12:17
Yeah, the pref is in settings.
Hmm, I like the canvas idea
Do you believe that the benefit to the user is worth the implementation cost?
(previews are only shown on recents documents)
Daniel Huigens
@twiss
Sep 23 2015 12:23
Well, if we implement #300 we'd show previews for all documents, lazily loaded.
Daniel Huigens
@twiss
Sep 23 2015 12:30
Personally I find these things with loading documents in iframes or canvases or trying to fix night mode quite fun to implement, it's more the surrounding changes to interface and filesystem code that I don't always look forward to
Joshua Smith
@joshua-s
Sep 23 2015 12:57
Ok!
One more thing: I think we could upgrade from Mozilla's gesture library to hammer.js (http://hammerjs.github.io/)
Is that a good idea?
Daniel Huigens
@twiss
Sep 23 2015 13:06
Sure, are you trying to fix #240 with that?
Joshua Smith
@joshua-s
Sep 23 2015 13:13
Yeah
Daniel Huigens
@twiss
Sep 23 2015 13:24
:+1: